Skip to content

WIP: OCPBUGS-36152: Set required-scc for openshift workloads #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

WIP: OCPBUGS-36152: Set required-scc for openshift workloads #360

wants to merge 10 commits into from

Conversation

@ShazaAldawamneh
Copy link

@ShazaAldawamneh ShazaAldawamneh commented Jun 25, 2024

OCPBUGS-36152

Manual cherry-pick of #573

AOS Automation Release Team and others added 10 commits November 28, 2023 03:01
Updating ose-cluster-openshift-controller-manager-operator-container …
2e3529b 
…image to be consistent with ART

Reconciling with https://github.com/openshift/ocp-build-data/tree/9dc2a375bf335e7e4e3d7e75abc5c3bdbb0c0e98/images/ose-cluster-openshift-controller-manager-operator.yml
@ardaguclu
Disable deployer-controller when deploymentconfig is disabled
7c5df4e
@ardaguclu
fix unit tests
6175d69
Replace 'coreydaley' with 'sayan-biswas'
39a2554
Merge pull request openshift#327 from openshift-cherrypick-robot/cher…
1ba446b 
…ry-pick-326-to-release-4.15

[release-4.15] OCPBUGS-28946: Replace 'coreydaley' with 'sayan-biswas' in OWNERS file
@openshift-merge-bot
Merge pull request openshift#319 from openshift-bot/art-consistency-o…
f189a00 
…penshift-4.15-ose-cluster-openshift-controller-manager-operator

OCPBUGS-24086: Updating ose-cluster-openshift-controller-manager-operator-container image to be consistent with ART
@apoorvajagtap
updates opentelemetry packages
83242b1
@openshift-merge-bot
Merge pull request openshift#322 from openshift-cherrypick-robot/cher…
e9845aa 
…ry-pick-320-to-release-4.15

[release-4.15] OCPBUGS-25985: Disable deployer-controller when deploymentconfig is disabled
@openshift-merge-bot
Merge pull request openshift#342 from apoorvajagtap/update-openteleme…
9c4fb81 
…try-dependency-415

[release-4.15] OCPBUGS-31708: Update opentelemetry dependency 415
@ShazaAldawamneh
manifests: set required-scc for openshift workloads
fa4db41 
Signed-off-by: Shaza Aldawamneh <shaza.aldawamneh@hotmail.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 25, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 25, 2024

@ShazaAldawamneh: This pull request references Jira Issue OCPBUGS-36152, which is invalid:

  • expected the bug to target either version "4.17." or "openshift-4.17.", but it targets "4.15.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

OCPBUGS-36152

Manual cherry-pick of #573

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 25, 2024
@ShazaAldawamneh ShazaAldawamneh deleted the OCPBUGS-36152 branch June 25, 2024 15:41
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 25, 2024

@ShazaAldawamneh: This pull request references Jira Issue OCPBUGS-36152. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

OCPBUGS-36152

Manual cherry-pick of #573

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 25, 2024
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Jun 25, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ShazaAldawamneh ShazaAldawamneh restored the OCPBUGS-36152 branch June 25, 2024 15:44
@openshift-ci openshift-ci bot requested review from deads2k and sayan-biswas June 25, 2024 15:52
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ShazaAldawamneh
Once this PR has been reviewed and has the lgtm label, please assign soltysh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2024

@ShazaAldawamneh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images fa4db41 link true /test images
ci/prow/security fa4db41 link false /test security
ci/prow/verify fa4db41 link true /test verify
ci/prow/e2e-upgrade fa4db41 link true /test e2e-upgrade
ci/prow/unit fa4db41 link true /test unit
ci/prow/e2e-aws-ovn fa4db41 link true /test e2e-aws-ovn
ci/prow/openshift-e2e-aws-builds-techpreview fa4db41 link false /test openshift-e2e-aws-builds-techpreview
ci/prow/e2e-aws-operator fa4db41 link true /test e2e-aws-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ShazaAldawamneh ShazaAldawamneh deleted the OCPBUGS-36152 branch June 25, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@sayan-biswas sayan-biswas Awaiting requested review from sayan-biswas

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ShazaAldawamneh @openshift-ci-robot @openshift-merge-robot @ardaguclu @apoorvajagtap