Skip to content

OCPBUGS-78769: Add patch permission to provisioner role#685

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.16from
tsmetana:add-patch-permission
Mar 19, 2026
Merged

OCPBUGS-78769: Add patch permission to provisioner role#685
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.16from
tsmetana:add-patch-permission

Conversation

@tsmetana
Copy link
Member

We want to rebase the SMB CSI operator in 4.16 to the 4.18 version. For that to work correctly (be able to remove the finalizer) we also need to backport #482 to 4.16.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 18, 2026
@openshift-ci-robot
Copy link
Contributor

@tsmetana: This pull request references Jira Issue OCPBUGS-78769, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-78769 to depend on a bug targeting a version in 4.17.0, 4.17.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

We want to rebase the SMB CSI operator in 4.16 to the 4.18 version. For that to work correctly (be able to remove the finalizer) we also need to backport #482 to 4.16.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link

coderabbitai bot commented Mar 18, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e0bce565-6203-4976-8c73-2fbc1a247f61

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from bertinatto and jsafrane March 18, 2026 10:20
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 18, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tsmetana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2026
@tsmetana
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@tsmetana: This pull request references Jira Issue OCPBUGS-78769, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-78769 to depend on a bug targeting a version in 4.17.0, 4.17.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tsmetana
Copy link
Member Author

/retest

@tsmetana
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@tsmetana: This pull request references Jira Issue OCPBUGS-78769, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tsmetana
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 18, 2026
@openshift-ci-robot
Copy link
Contributor

@tsmetana: This pull request references Jira Issue OCPBUGS-78769, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.z) matches configured target version for branch (4.16.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-78772 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-78772 targets the "4.17.0" version, which is one of the valid target versions: 4.17.0, 4.17.z
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Phaow
Copy link
Contributor

Phaow commented Mar 18, 2026

/retest-required

@gnufied
Copy link
Member

gnufied commented Mar 18, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2026
@Phaow
Copy link
Contributor

Phaow commented Mar 18, 2026

Pre merge test with clusterbot build 4.16.0-0-2026-03-18-121356-test-ci-ln-whstv62-latest (build 4.16,openshift/cluster-storage-operator#685) passed

# Check the clusterrole updated as expected permissions
$ oc get clusterrole openshift-csi-main-provisioner-role -o yaml \
| yq '.rules[] | select(.resources[] == "persistentvolumes")'
apiGroups:
  - ""
resources:
  - persistentvolumes
verbs:
  - get
  - list
  - watch
  - create
  - delete
  - patch

# Rerun the reclaimPolicy "Retain" test passed in the smb csi driver operator installed with the release-4.18 build version

$ go test -v ./test/e2e \
  -ginkgo.focus='should retain PV with reclaimPolicy "Retain"' \
  -ginkgo.v
=== RUN   TestE2E
I0318 22:27:49.333599   76434 smb_driver.go:47] Using smb driver: smb.csi.k8s.io
Running Suite: SMB CSI Driver End-to-End Tests - /Users/wangpenghao/Upstream/csi-driver-smb/test/e2e
====================================================================================================
Random Seed: 1773844069

Will run 1 of 13 specs
------------------------------
[BeforeSuite] 
/Users/wangpenghao/Upstream/csi-driver-smb/test/e2e/suite_test.go:113
  Mar 18 22:27:49.334: INFO: The --provider flag is not set. Continuing as if --provider=skeleton had been used.
2026/03/18 22:27:49 WINDOWS_SERVER_VERSION  
[BeforeSuite] PASSED [0.000 seconds]
------------------------------
SSSSSS
------------------------------
Dynamic Provisioning should retain PV with reclaimPolicy "Retain" [smb.csi.k8s.io] [Windows]
/Users/wangpenghao/Upstream/csi-driver-smb/test/e2e/dynamic_provisioning_test.go:264
  STEP: Creating a kubernetes client @ 03/18/26 22:27:49.334
  Mar 18 22:27:49.334: INFO: >>> kubeConfig: /Users/wangpenghao/.kube/config
  I0318 22:27:49.334442   76434 driver.go:93] Enabling controller service capability: CREATE_DELETE_VOLUME
  I0318 22:27:49.334450   76434 driver.go:93] Enabling controller service capability: SINGLE_NODE_MULTI_WRITER
  I0318 22:27:49.334453   76434 driver.go:93] Enabling controller service capability: CLONE_VOLUME
  I0318 22:27:49.334456   76434 driver.go:112] Enabling volume access mode: SINGLE_NODE_WRITER
  I0318 22:27:49.334459   76434 driver.go:112] Enabling volume access mode: SINGLE_NODE_READER_ONLY
  I0318 22:27:49.334461   76434 driver.go:112] Enabling volume access mode: SINGLE_NODE_SINGLE_WRITER
  I0318 22:27:49.334464   76434 driver.go:112] Enabling volume access mode: SINGLE_NODE_MULTI_WRITER
  I0318 22:27:49.334466   76434 driver.go:112] Enabling volume access mode: MULTI_NODE_READER_ONLY
  I0318 22:27:49.334469   76434 driver.go:112] Enabling volume access mode: MULTI_NODE_SINGLE_WRITER
  I0318 22:27:49.334471   76434 driver.go:112] Enabling volume access mode: MULTI_NODE_MULTI_WRITER
  I0318 22:27:49.334670   76434 server.go:118] Listening for connections on address: &net.UnixAddr{Name:"//tmp/csi-a3e69e9a-22d6-11f1-8649-caf084d1269e.sock", Net:"unix"}
  STEP: Building a namespace api object, basename smb @ 03/18/26 22:27:49.336
  STEP: Waiting for a default service account to be provisioned in namespace @ 03/18/26 22:27:51.093
  STEP: Waiting for kube-root-ca.crt to be provisioned in namespace @ 03/18/26 22:27:51.603
2026/03/18 22:27:52 Check driver pods if restarts ...
check the driver pods if restarts ...
no driver pods have restarted
======================================================================================
2026/03/18 22:27:54 Check successfully
  STEP: setting up the StorageClass @ 03/18/26 22:27:54.82
  STEP: creating a StorageClass  @ 03/18/26 22:27:54.82
  STEP: setting up the PVC and PV @ 03/18/26 22:27:55.17
  STEP: creating a PVC @ 03/18/26 22:27:55.17
  STEP: waiting for PVC to be in phase "Bound" @ 03/18/26 22:27:55.443
  Mar 18 22:27:55.443: INFO: Waiting up to timeout=5m0s for PersistentVolumeClaims [pvc-k57wz] to have phase Bound
  Mar 18 22:27:55.709: INFO: PersistentVolumeClaim pvc-k57wz found but phase is Pending instead of Bound.
  Mar 18 22:27:57.971: INFO: PersistentVolumeClaim pvc-k57wz found and phase=Bound (2.527883542s)
  STEP: checking the PVC @ 03/18/26 22:27:57.971
  STEP: validating provisioned PV @ 03/18/26 22:27:58.233
  STEP: checking the PV @ 03/18/26 22:27:58.487
  Mar 18 22:27:58.487: INFO: deleting PVC "smb-5098"/"pvc-k57wz"
  Mar 18 22:27:58.487: INFO: Deleting PersistentVolumeClaim "pvc-k57wz"
  Mar 18 22:27:58.778: INFO: Waiting up to 5m0s for PersistentVolumeClaim smb-5098 to be removed
  Mar 18 22:27:59.039: INFO: Claim "smb-5098" in namespace "pvc-k57wz" doesn't exist in the system
  Mar 18 22:27:59.039: INFO: Waiting up to 10m0s for PersistentVolume pvc-e9fb177d-523b-4450-aa39-049bda6f427b to have phase Released
  Mar 18 22:27:59.322: INFO: PersistentVolume pvc-e9fb177d-523b-4450-aa39-049bda6f427b found and phase=Released (282.926917ms)
  STEP: deleting PV "pvc-e9fb177d-523b-4450-aa39-049bda6f427b" @ 03/18/26 22:27:59.323
  Mar 18 22:27:59.323: INFO: Deleting PersistentVolume "pvc-e9fb177d-523b-4450-aa39-049bda6f427b"
  STEP: waiting for claim's PV "pvc-e9fb177d-523b-4450-aa39-049bda6f427b" to be deleted @ 03/18/26 22:27:59.596
  Mar 18 22:27:59.596: INFO: Waiting up to 10m0s for PersistentVolume pvc-e9fb177d-523b-4450-aa39-049bda6f427b to get deleted
  Mar 18 22:27:59.857: INFO: PersistentVolume pvc-e9fb177d-523b-4450-aa39-049bda6f427b was removed
  STEP: deleting smb volume "samba-server.samba-server.svc.cluster.local/share#pvc-e9fb177d-523b-4450-aa39-049bda6f427b##" @ 03/18/26 22:27:59.857
  Mar 18 22:28:00.120: INFO: Cleanup storageclass smb-5098-smb.csi.k8s.io-dynamic-sc-9zzdz, err: <nil>
  STEP: Destroying namespace "smb-5098" for this suite. @ 03/18/26 22:28:00.12
• [11.045 seconds]
------------------------------
SSSSSS
------------------------------
[AfterSuite] 
/Users/wangpenghao/Upstream/csi-driver-smb/test/e2e/suite_test.go:192
2026/03/18 22:28:00 ===================smb log===================
print out all nodes status ...
NAME                                        STATUS   ROLES                  AGE   VERSION            INTERNAL-IP   EXTERNAL-IP   OS-IMAGE                                                KERNEL-VERSION                  CONTAINER-RUNTIME
ip-10-0-1-5.us-east-2.compute.internal      Ready    worker                 50m   v1.29.14+41c4e9b   10.0.1.5      <none>        Red Hat Enterprise Linux CoreOS 416.94.202603130158-0   5.14.0-427.115.1.el9_4.x86_64   cri-o://1.29.13-11.rhaos4.16.git979a5e6.el9
ip-10-0-46-188.us-east-2.compute.internal   Ready    control-plane,master   55m   v1.29.14+41c4e9b   10.0.46.188   <none>        Red Hat Enterprise Linux CoreOS 416.94.202603130158-0   5.14.0-427.115.1.el9_4.x86_64   cri-o://1.29.13-11.rhaos4.16.git979a5e6.el9
ip-10-0-57-199.us-east-2.compute.internal   Ready    worker                 50m   v1.29.14+41c4e9b   10.0.57.199   <none>        Red Hat Enterprise Linux CoreOS 416.94.202603130158-0   5.14.0-427.115.1.el9_4.x86_64   cri-o://1.29.13-11.rhaos4.16.git979a5e6.el9
ip-10-0-8-142.us-east-2.compute.internal    Ready    control-plane,master   56m   v1.29.14+41c4e9b   10.0.8.142    <none>        Red Hat Enterprise Linux CoreOS 416.94.202603130158-0   5.14.0-427.115.1.el9_4.x86_64   cri-o://1.29.13-11.rhaos4.16.git979a5e6.el9
ip-10-0-83-137.us-east-2.compute.internal   Ready    worker                 46m   v1.29.14+41c4e9b   10.0.83.137   <none>        Red Hat Enterprise Linux CoreOS 416.94.202603130158-0   5.14.0-427.115.1.el9_4.x86_64   cri-o://1.29.13-11.rhaos4.16.git979a5e6.el9
ip-10-0-88-252.us-east-2.compute.internal   Ready    control-plane,master   55m   v1.29.14+41c4e9b   10.0.88.252   <none>        Red Hat Enterprise Linux CoreOS 416.94.202603130158-0   5.14.0-427.115.1.el9_4.x86_64   cri-o://1.29.13-11.rhaos4.16.git979a5e6.el9
======================================================================================
print out all default namespace pods status ...
No resources found in default namespace.
======================================================================================
print out all kube-system namespace pods status ...
No resources found in kube-system namespace.
======================================================================================
print out csi-smb-controller pods ...
======================================================================================
No resources found in kube-system namespace.
print out csi-smb-node logs ...
======================================================================================
No resources found in kube-system namespace.
print out csi-smb-node-win events ...
======================================================================================
No resources found in kube-system namespace.
print out csi-smb-node-win logs ...
======================================================================================
No resources found in kube-system namespace.
print out service logs ...
======================================================================================
NAMESPACE                                          NAME                                               TYPE           CLUSTER-IP       EXTERNAL-IP                                                              PORT(S)                                        AGE
default                                            kubernetes                                         ClusterIP      172.30.0.1       <none>                                                                   443/TCP                                        57m
default                                            openshift                                          ExternalName   <none>           kubernetes.default.svc.cluster.local                                     <none>                                         53m
kube-system                                        kubelet                                            ClusterIP      None             <none>                                                                   10250/TCP,10255/TCP,4194/TCP                   49m
openshift-apiserver-operator                       metrics                                            ClusterIP      172.30.222.229   <none>                                                                   443/TCP                                        56m
openshift-apiserver                                api                                                ClusterIP      172.30.49.134    <none>                                                                   443/TCP                                        53m
openshift-apiserver                                check-endpoints                                    ClusterIP      172.30.132.46    <none>                                                                   17698/TCP                                      53m
openshift-authentication-operator                  metrics                                            ClusterIP      172.30.20.117    <none>                                                                   443/TCP                                        56m
openshift-authentication                           oauth-openshift                                    ClusterIP      172.30.180.41    <none>                                                                   443/TCP                                        53m
openshift-cloud-controller-manager-operator        cloud-controller-manager-operator                  ClusterIP      None             <none>                                                                   9258/TCP                                       55m
openshift-cloud-controller-manager                 aws-cloud-controller-manager                       ClusterIP      172.30.170.151   <none>                                                                   10258/TCP,10260/TCP                            55m
openshift-cloud-credential-operator                cco-metrics                                        ClusterIP      172.30.249.150   <none>                                                                   8443/TCP                                       55m
openshift-cloud-credential-operator                pod-identity-webhook                               ClusterIP      172.30.243.106   <none>                                                                   443/TCP                                        42m
openshift-cluster-csi-drivers                      aws-ebs-csi-driver-controller-metrics              ClusterIP      172.30.150.180   <none>                                                                   9202/TCP,9203/TCP,9204/TCP,9205/TCP,9201/TCP   53m
openshift-cluster-csi-drivers                      smb-csi-driver-controller-metrics                  ClusterIP      172.30.117.34    <none>                                                                   9222/TCP,9221/TCP                              3m3s
openshift-cluster-machine-approver                 machine-approver                                   ClusterIP      None             <none>                                                                   9192/TCP                                       55m
openshift-cluster-node-tuning-operator             node-tuning-operator                               ClusterIP      None             <none>                                                                   60000/TCP                                      56m
openshift-cluster-node-tuning-operator             performance-addon-operator-service                 ClusterIP      172.30.98.116    <none>                                                                   443/TCP                                        56m
openshift-cluster-samples-operator                 metrics                                            ClusterIP      None             <none>                                                                   60000/TCP                                      51m
openshift-cluster-storage-operator                 cluster-storage-operator-metrics                   ClusterIP      172.30.71.61     <none>                                                                   443/TCP                                        56m
openshift-cluster-storage-operator                 csi-snapshot-controller-operator-metrics           ClusterIP      172.30.148.13    <none>                                                                   443/TCP                                        56m
openshift-cluster-storage-operator                 csi-snapshot-webhook                               ClusterIP      172.30.176.57    <none>                                                                   443/TCP                                        54m
openshift-cluster-version                          cluster-version-operator                           ClusterIP      172.30.137.182   <none>                                                                   9099/TCP                                       56m
openshift-config-operator                          metrics                                            ClusterIP      172.30.191.236   <none>                                                                   443/TCP                                        56m
openshift-console-operator                         metrics                                            ClusterIP      172.30.149.239   <none>                                                                   443/TCP                                        44m
openshift-console-operator                         webhook                                            ClusterIP      172.30.62.66     <none>                                                                   9443/TCP                                       44m
openshift-console                                  console                                            ClusterIP      172.30.139.242   <none>                                                                   443/TCP                                        42m
openshift-console                                  downloads                                          ClusterIP      172.30.220.147   <none>                                                                   80/TCP                                         42m
openshift-controller-manager-operator              metrics                                            ClusterIP      172.30.86.195    <none>                                                                   443/TCP                                        56m
openshift-controller-manager                       controller-manager                                 ClusterIP      172.30.165.241   <none>                                                                   443/TCP                                        53m
openshift-dns-operator                             metrics                                            ClusterIP      172.30.23.203    <none>                                                                   9393/TCP                                       56m
openshift-dns                                      dns-default                                        ClusterIP      172.30.0.10      <none>                                                                   53/UDP,53/TCP,9154/TCP                         53m
openshift-etcd-operator                            metrics                                            ClusterIP      172.30.55.54     <none>                                                                   443/TCP                                        56m
openshift-etcd                                     etcd                                               ClusterIP      172.30.83.230    <none>                                                                   2379/TCP,2380/TCP,9978/TCP,9979/TCP,9980/TCP   57m
openshift-image-registry                           image-registry                                     ClusterIP      172.30.20.129    <none>                                                                   5000/TCP                                       44m
openshift-image-registry                           image-registry-operator                            ClusterIP      None             <none>                                                                   60000/TCP                                      56m
openshift-ingress-canary                           ingress-canary                                     ClusterIP      172.30.164.102   <none>                                                                   8080/TCP,8888/TCP                              51m
openshift-ingress-operator                         metrics                                            ClusterIP      172.30.154.239   <none>                                                                   9393/TCP                                       56m
openshift-ingress                                  router-default                                     LoadBalancer   172.30.236.98    abad770cc87e742c9975c92f73289d61-472306242.us-east-2.elb.amazonaws.com   80:30928/TCP,443:31373/TCP                     53m
openshift-ingress                                  router-internal-default                            ClusterIP      172.30.180.168   <none>                                                                   80/TCP,443/TCP,1936/TCP                        53m
openshift-insights                                 metrics                                            ClusterIP      172.30.11.169    <none>                                                                   443/TCP                                        56m
openshift-kube-apiserver-operator                  metrics                                            ClusterIP      172.30.68.119    <none>                                                                   443/TCP                                        56m
openshift-kube-apiserver                           apiserver                                          ClusterIP      172.30.188.188   <none>                                                                   443/TCP,6080/TCP,17697/TCP                     53m
openshift-kube-controller-manager-operator         metrics                                            ClusterIP      172.30.62.51     <none>                                                                   443/TCP                                        56m
openshift-kube-controller-manager                  kube-controller-manager                            ClusterIP      172.30.48.60     <none>                                                                   443/TCP                                        54m
openshift-kube-scheduler-operator                  metrics                                            ClusterIP      172.30.219.4     <none>                                                                   443/TCP                                        56m
openshift-kube-scheduler                           scheduler                                          ClusterIP      172.30.208.104   <none>                                                                   443/TCP                                        53m
openshift-kube-storage-version-migrator-operator   metrics                                            ClusterIP      172.30.63.139    <none>                                                                   443/TCP                                        56m
openshift-logging                                  cluster-logging-operator-metrics                   ClusterIP      172.30.88.203    <none>                                                                   8686/TCP                                       17m
openshift-machine-api                              cluster-autoscaler-operator                        ClusterIP      172.30.197.80    <none>                                                                   443/TCP,9192/TCP                               55m
openshift-machine-api                              cluster-baremetal-operator-service                 ClusterIP      172.30.181.36    <none>                                                                   8443/TCP                                       56m
openshift-machine-api                              cluster-baremetal-webhook-service                  ClusterIP      172.30.62.238    <none>                                                                   443/TCP                                        56m
openshift-machine-api                              control-plane-machine-set-operator                 ClusterIP      172.30.72.180    <none>                                                                   9443/TCP                                       55m
openshift-machine-api                              machine-api-controllers                            ClusterIP      172.30.219.145   <none>                                                                   8441/TCP,8442/TCP,8444/TCP                     56m
openshift-machine-api                              machine-api-operator                               ClusterIP      172.30.218.142   <none>                                                                   8443/TCP                                       56m
openshift-machine-api                              machine-api-operator-machine-webhook               ClusterIP      172.30.39.127    <none>                                                                   443/TCP                                        56m
openshift-machine-api                              machine-api-operator-webhook                       ClusterIP      172.30.145.178   <none>                                                                   443/TCP                                        56m
openshift-machine-config-operator                  machine-config-controller                          ClusterIP      172.30.119.45    <none>                                                                   9001/TCP                                       56m
openshift-machine-config-operator                  machine-config-daemon                              ClusterIP      172.30.24.89     <none>                                                                   9001/TCP,8798/TCP                              56m
openshift-machine-config-operator                  machine-config-operator                            ClusterIP      172.30.126.109   <none>                                                                   9001/TCP                                       56m
openshift-marketplace                              certified-operators                                ClusterIP      172.30.87.61     <none>                                                                   50051/TCP                                      53m
openshift-marketplace                              community-operators                                ClusterIP      172.30.26.85     <none>                                                                   50051/TCP                                      53m
openshift-marketplace                              marketplace-operator-metrics                       ClusterIP      172.30.247.18    <none>                                                                   8383/TCP,8081/TCP                              56m
openshift-marketplace                              qe-app-registry                                    ClusterIP      172.30.33.90     <none>                                                                   50051/TCP                                      25m
openshift-marketplace                              redhat-marketplace                                 ClusterIP      172.30.108.199   <none>                                                                   50051/TCP                                      53m
openshift-marketplace                              redhat-operators                                   ClusterIP      172.30.129.122   <none>                                                                   50051/TCP                                      53m
openshift-marketplace                              smb-preview                                        ClusterIP      172.30.79.206    <none>                                                                   50051/TCP                                      4m23s
openshift-monitoring                               alertmanager-main                                  ClusterIP      172.30.23.145    <none>                                                                   9094/TCP,9092/TCP,9097/TCP                     42m
openshift-monitoring                               alertmanager-operated                              ClusterIP      None             <none>                                                                   9093/TCP,9094/TCP,9094/UDP                     41m
openshift-monitoring                               cluster-monitoring-operator                        ClusterIP      None             <none>                                                                   8443/TCP                                       56m
openshift-monitoring                               kube-state-metrics                                 ClusterIP      None             <none>                                                                   8443/TCP,9443/TCP                              49m
openshift-monitoring                               metrics-server                                     ClusterIP      172.30.249.42    <none>                                                                   443/TCP                                        49m
openshift-monitoring                               monitoring-plugin                                  ClusterIP      172.30.150.202   <none>                                                                   9443/TCP                                       44m
openshift-monitoring                               node-exporter                                      ClusterIP      None             <none>                                                                   9100/TCP                                       49m
openshift-monitoring                               openshift-state-metrics                            ClusterIP      None             <none>                                                                   8443/TCP,9443/TCP                              49m
openshift-monitoring                               prometheus-k8s                                     ClusterIP      172.30.35.181    <none>                                                                   9091/TCP,9092/TCP                              41m
openshift-monitoring                               prometheus-k8s-thanos-sidecar                      ClusterIP      None             <none>                                                                   10902/TCP                                      41m
openshift-monitoring                               prometheus-operated                                ClusterIP      None             <none>                                                                   9090/TCP,10901/TCP                             41m
openshift-monitoring                               prometheus-operator                                ClusterIP      None             <none>                                                                   8443/TCP                                       49m
openshift-monitoring                               prometheus-operator-admission-webhook              ClusterIP      172.30.202.124   <none>                                                                   8443/TCP                                       53m
openshift-monitoring                               telemeter-client                                   ClusterIP      None             <none>                                                                   8443/TCP                                       44m
openshift-monitoring                               thanos-querier                                     ClusterIP      172.30.110.108   <none>                                                                   9091/TCP,9092/TCP,9093/TCP,9094/TCP            49m
openshift-multus                                   multus-admission-controller                        ClusterIP      172.30.66.80     <none>                                                                   443/TCP,8443/TCP                               54m
openshift-multus                                   network-metrics-service                            ClusterIP      None             <none>                                                                   8443/TCP                                       54m
openshift-network-diagnostics                      network-check-source                               ClusterIP      None             <none>                                                                   17698/TCP                                      54m
openshift-network-diagnostics                      network-check-target                               ClusterIP      172.30.11.234    <none>                                                                   80/TCP                                         54m
openshift-network-operator                         metrics                                            ClusterIP      None             <none>                                                                   9104/TCP                                       56m
openshift-oauth-apiserver                          api                                                ClusterIP      172.30.94.3      <none>                                                                   443/TCP                                        53m
openshift-operator-lifecycle-manager               catalog-operator-metrics                           ClusterIP      172.30.186.171   <none>                                                                   8443/TCP                                       56m
openshift-operator-lifecycle-manager               olm-operator-metrics                               ClusterIP      172.30.125.243   <none>                                                                   8443/TCP                                       56m
openshift-operator-lifecycle-manager               package-server-manager-metrics                     ClusterIP      172.30.110.27    <none>                                                                   8443/TCP                                       56m
openshift-operator-lifecycle-manager               packageserver-service                              ClusterIP      172.30.122.142   <none>                                                                   5443/TCP                                       53m
openshift-operators-redhat                         elasticsearch-operator-metrics                     ClusterIP      172.30.63.127    <none>                                                                   8443/TCP                                       17m
openshift-operators-redhat                         loki-operator-controller-manager-metrics-service   ClusterIP      172.30.228.63    <none>                                                                   8443/TCP                                       17m
openshift-operators-redhat                         loki-operator-controller-manager-service           ClusterIP      172.30.123.14    <none>                                                                   443/TCP                                        17m
openshift-operators-redhat                         loki-operator-webhook-service                      ClusterIP      172.30.214.1     <none>                                                                   443/TCP                                        17m
openshift-ovn-kubernetes                           ovn-kubernetes-control-plane                       ClusterIP      None             <none>                                                                   9108/TCP                                       54m
openshift-ovn-kubernetes                           ovn-kubernetes-node                                ClusterIP      None             <none>                                                                   9103/TCP,9105/TCP                              54m
openshift-route-controller-manager                 route-controller-manager                           ClusterIP      172.30.208.163   <none>                                                                   443/TCP                                        53m
openshift-service-ca-operator                      metrics                                            ClusterIP      172.30.65.135    <none>                                                                   443/TCP                                        56m
samba-server                                       samba-server                                       ClusterIP      172.30.9.169     <none>                                                                   445/TCP                                        107s
print out metrics ...
======================================================================================
Error from server (NotFound): services "csi-smb-controller" not found
curl: (3) URL rejected: No host part in the URL
hit unexpected error during log print, exit 0
2026/03/18 22:28:09 ===================================================
[AfterSuite] PASSED [9.399 seconds]
------------------------------

Ran 1 of 13 Specs in 20.444 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 12 Skipped
You're using deprecated Ginkgo functionality:
=============================================
  Support for custom reporters has been removed in V2.  Please read the documentation linked to below for Ginkgo's new behavior and for a migration path:
  Learn more at: https://onsi.github.io/ginkgo/MIGRATING_TO_V2#removed-custom-reporters

To silence deprecations that can be silenced set the following environment variable:
  ACK_GINKGO_DEPRECATIONS=2.17.1

--- PASS: TestE2E (20.44s)
PASS
ok      github.com/kubernetes-csi/csi-driver-smb/test/e2e       21.578s

@Phaow
Copy link
Contributor

Phaow commented Mar 18, 2026

/verified by @Phaow

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 18, 2026
@openshift-ci-robot
Copy link
Contributor

@Phaow: This PR has been marked as verified by @Phaow.

Details

In response to this:

/verified by @Phaow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Phaow
Copy link
Contributor

Phaow commented Mar 18, 2026

/label backport-risk-assessed

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 18, 2026

@Phaow: The label(s) backport-risk-assessed cannot be applied or removed, because you are not in one of the allowed teams and are not an allowed user. Must be a member of one of these teams: openshift-patch-managers, openshift-release-oversight, openshift-staff-engineers, openshift-sustaining-engineers

Details

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Phaow
Copy link
Contributor

Phaow commented Mar 18, 2026

@gnufied @tsmetana We also need a backport-risk-assessed magic label ^^.

@Phaow
Copy link
Contributor

Phaow commented Mar 19, 2026

/retest-required

@Phaow
Copy link
Contributor

Phaow commented Mar 19, 2026

/unassign @duanwei33 @chao007 @radeore

@gnufied
Copy link
Member

gnufied commented Mar 19, 2026

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 19, 2026
@Phaow
Copy link
Contributor

Phaow commented Mar 19, 2026

/test e2e-azure-csi

@Phaow
Copy link
Contributor

Phaow commented Mar 19, 2026

/test hypershift-aws-e2e-external

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 19, 2026

@tsmetana: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 93a92be into openshift:release-4.16 Mar 19, 2026
13 checks passed
@openshift-ci-robot
Copy link
Contributor

@tsmetana: Jira Issue Verification Checks: Jira Issue OCPBUGS-78769
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-78769 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

We want to rebase the SMB CSI operator in 4.16 to the 4.18 version. For that to work correctly (be able to remove the finalizer) we also need to backport #482 to 4.16.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants