Skip to content

Upgrade Console SDK to 4.22 and fix review issues from PR #8#10

Open
jhadvig wants to merge 2 commits into
openshift:mainfrom
jhadvig:4.22-update-v2
Open

Upgrade Console SDK to 4.22 and fix review issues from PR #8#10
jhadvig wants to merge 2 commits into
openshift:mainfrom
jhadvig:4.22-update-v2

Conversation

@jhadvig
Copy link
Copy Markdown
Member

@jhadvig jhadvig commented Jun 3, 2026

Summary

Follow-up to #8. Addresses the blocking and non-blocking issues identified during review.

Blocking fixes (runtime crash on OCP 5.0)

  • SDK 4.22 upgrade — React 17→18, react-router v5→v7, react-i18next v11→v16, PatternFly 6.2→6.4, i18next 23→25
  • useHistoryuseNavigate — fixes react_router_dom.useHistory is not a function crash
  • react-router-domreact-router — deprecated module replaced in all imports
  • getRiskColor case-insensitive — CRD serves Low/Medium/High/Critical, switch was matching lowercase only

Non-blocking fixes

  • Remove exact from console-extensions.json (react-router v7 default)
  • Add trailing newline to locale JSON
  • Update consolePlugin.dependencies to >=4.22.0-0

Docs

  • Replace template README with plugin-specific content
  • Add mock-analysis-result.yaml for cluster testing without Lightspeed operator
  • Add ONBOARDING-FINDINGS.md documenting API mismatches and dev environment setup

Supersedes #9 (rebased on top of #8).

Test plan

  • yarn test — 56 tests pass
  • yarn build — production webpack build succeeds with SDK 4.22
  • Tested on OCP 5.0 cluster with mock AnalysisResult data

🤖 Generated with Claude Code

- SDK 4.22: React 17→18, react-router v5→v7, react-i18next v11→v16,
  PatternFly 6.2→6.4, i18next 23→25
- Fix useHistory→useNavigate (runtime crash on OCP 5.0)
- Fix react-router-dom→react-router imports
- Fix getRiskColor case-insensitive matching (CRD serves capitalized)
- Remove exact from console-extensions.json (react-router v7 default)
- Add trailing newline to locale JSON
- Update consolePlugin dependency to >=4.22.0-0

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-ci openshift-ci Bot requested review from fao89 and hongkailiu June 3, 2026 14:20
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 3, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jhadvig
Once this PR has been reviewed and has the lgtm label, please assign fao89 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

- Replace template README with plugin-specific content
- Add mock-analysis-result.yaml for cluster testing without Lightspeed
- Add ONBOARDING-FINDINGS.md documenting API mismatches and dev setup
- Updated Helm Charts
- Update locales
- Update getAnalysisDataFromResult to support arrays
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 4, 2026

@jhadvig: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/frontend 731dad8 link true /test frontend

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant