Upgrade Console SDK to 4.22 and fix review issues from PR #8#10
Upgrade Console SDK to 4.22 and fix review issues from PR #8#10jhadvig wants to merge 2 commits into
Conversation
- SDK 4.22: React 17→18, react-router v5→v7, react-i18next v11→v16, PatternFly 6.2→6.4, i18next 23→25 - Fix useHistory→useNavigate (runtime crash on OCP 5.0) - Fix react-router-dom→react-router imports - Fix getRiskColor case-insensitive matching (CRD serves capitalized) - Remove exact from console-extensions.json (react-router v7 default) - Add trailing newline to locale JSON - Update consolePlugin dependency to >=4.22.0-0 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jhadvig The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
- Replace template README with plugin-specific content - Add mock-analysis-result.yaml for cluster testing without Lightspeed - Add ONBOARDING-FINDINGS.md documenting API mismatches and dev setup - Updated Helm Charts - Update locales - Update getAnalysisDataFromResult to support arrays
|
@jhadvig: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
Follow-up to #8. Addresses the blocking and non-blocking issues identified during review.
Blocking fixes (runtime crash on OCP 5.0)
useHistory→useNavigate— fixesreact_router_dom.useHistory is not a functioncrashreact-router-dom→react-router— deprecated module replaced in all importsgetRiskColorcase-insensitive — CRD servesLow/Medium/High/Critical, switch was matching lowercase onlyNon-blocking fixes
exactfromconsole-extensions.json(react-router v7 default)consolePlugin.dependenciesto>=4.22.0-0Docs
mock-analysis-result.yamlfor cluster testing without Lightspeed operatorONBOARDING-FINDINGS.mddocumenting API mismatches and dev environment setupSupersedes #9 (rebased on top of #8).
Test plan
yarn test— 56 tests passyarn build— production webpack build succeeds with SDK 4.22🤖 Generated with Claude Code