NO-JRA: Add lint target to Makefile#1341
Conversation
|
/hold for discussion |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdds a vendored golangci-lint-based lint target to the Makefile, sets PROJECT_DIR and GOLANGCI_LINT variables, and upgrades module tooling and dependencies including Go 1.25 and numerous direct/indirect version bumps with a replace of github.com/onsi/ginkgo/v2 to an OpenShift fork. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
go.mod (1)
281-281: Replace directive pins ginkgo to an older OpenShift fork.The replace directive pins
ginkgo/v2togithub.com/openshift/onsi-ginkgo/v2 v2.6.1-0.20241205171354-8006f302fd12, which is based on a December 2024 commit. This is intentional for OpenShift's CI environment compatibility, but note:
- The pseudo-version date (2024-12-05) is over a year old relative to the current date
- This may miss upstream ginkgo fixes and features
Consider periodically syncing the fork if upstream ginkgo changes are needed.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@go.mod` at line 281, The go.mod replace directive pins github.com/onsi/ginkgo/v2 to an older OpenShift fork (github.com/openshift/onsi-ginkgo/v2 v2.6.1-0.20241205171354-8006f302fd12); update the replace entry to a newer pseudo-version or remove the replace to use upstream github.com/onsi/ginkgo/v2 if CI no longer requires the fork, then run go mod tidy and run the test suite to verify compatibility; if keeping the fork is required, periodically bump the pseudo-version to a more recent commit from github.com/openshift/onsi-ginkgo/v2 and document the reason for the pin.Makefile (1)
57-62: Usego tool golangci-lintto leverage the existing tool directive.The project already declares
tool github.com/golangci/golangci-lint/v2/cmd/golangci-lintin go.mod (Go 1.25 fully supports this). Simplify the Makefile to:GOLANGCI_LINT = go tool golangci-lintThis approach:
- Uses Go's native tool directive mechanism already declared in go.mod
- Eliminates the need for manual vendor path specification
- Works with Go 1.24+ tool caching and management
- Cleaner and more maintainable than
go run -mod=vendor🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Makefile` around lines 57 - 62, Replace the current GOLANGCI_LINT invocation that uses "go run -mod=vendor ${PROJECT_DIR}/vendor/..." with Go's tool mechanism: update the GOLANGCI_LINT variable definition so the Makefile uses "go tool golangci-lint" (affecting the GOLANGCI_LINT variable and the lint target that calls ${GOLANGCI_LINT} run) so the project leverages the go.mod tool directive instead of a vendor path.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@go.mod`:
- Line 281: The go.mod replace directive pins github.com/onsi/ginkgo/v2 to an
older OpenShift fork (github.com/openshift/onsi-ginkgo/v2
v2.6.1-0.20241205171354-8006f302fd12); update the replace entry to a newer
pseudo-version or remove the replace to use upstream github.com/onsi/ginkgo/v2
if CI no longer requires the fork, then run go mod tidy and run the test suite
to verify compatibility; if keeping the fork is required, periodically bump the
pseudo-version to a more recent commit from github.com/openshift/onsi-ginkgo/v2
and document the reason for the pin.
In `@Makefile`:
- Around line 57-62: Replace the current GOLANGCI_LINT invocation that uses "go
run -mod=vendor ${PROJECT_DIR}/vendor/..." with Go's tool mechanism: update the
GOLANGCI_LINT variable definition so the Makefile uses "go tool golangci-lint"
(affecting the GOLANGCI_LINT variable and the lint target that calls
${GOLANGCI_LINT} run) so the project leverages the go.mod tool directive instead
of a vendor path.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 60b42846-6ad0-4a7c-8173-050842dad36a
⛔ Files ignored due to path filters (298)
go.sumis excluded by!**/*.sumvendor/4d63.com/gocheckcompilerdirectives/LICENSEis excluded by!**/vendor/**,!vendor/**vendor/4d63.com/gocheckcompilerdirectives/checkcompilerdirectives/checkcompilerdirectives.gois excluded by!**/vendor/**,!vendor/**vendor/4d63.com/gochecknoglobals/LICENSEis excluded by!**/vendor/**,!vendor/**vendor/4d63.com/gochecknoglobals/checknoglobals/check_no_globals.gois excluded by!**/vendor/**,!vendor/**vendor/codeberg.org/chavacava/garif/.gitignoreis excluded by!**/vendor/**,!vendor/**vendor/codeberg.org/chavacava/garif/LICENSEis excluded by!**/vendor/**,!vendor/**vendor/codeberg.org/chavacava/garif/README.mdis excluded by!**/vendor/**,!vendor/**vendor/codeberg.org/chavacava/garif/constructors.gois excluded by!**/vendor/**,!vendor/**vendor/codeberg.org/chavacava/garif/decorators.gois excluded by!**/vendor/**,!vendor/**vendor/codeberg.org/chavacava/garif/doc.gois excluded by!**/vendor/**,!vendor/**vendor/codeberg.org/chavacava/garif/enums.gois excluded by!**/vendor/**,!vendor/**vendor/codeberg.org/chavacava/garif/io.gois excluded by!**/vendor/**,!vendor/**vendor/codeberg.org/chavacava/garif/models.gois excluded by!**/vendor/**,!vendor/**vendor/codeberg.org/polyfloyd/go-errorlint/LICENSEis excluded by!**/vendor/**,!vendor/**vendor/codeberg.org/polyfloyd/go-errorlint/errorlint/allowed.gois excluded by!**/vendor/**,!vendor/**vendor/codeberg.org/polyfloyd/go-errorlint/errorlint/analysis.gois excluded by!**/vendor/**,!vendor/**vendor/codeberg.org/polyfloyd/go-errorlint/errorlint/lint.gois excluded by!**/vendor/**,!vendor/**vendor/codeberg.org/polyfloyd/go-errorlint/errorlint/options.gois excluded by!**/vendor/**,!vendor/**vendor/codeberg.org/polyfloyd/go-errorlint/errorlint/printf.gois excluded by!**/vendor/**,!vendor/**vendor/dev.gaijin.team/go/exhaustruct/v4/LICENSEis excluded by!**/vendor/**,!vendor/**vendor/dev.gaijin.team/go/exhaustruct/v4/analyzer/analyzer.gois excluded by!**/vendor/**,!vendor/**vendor/dev.gaijin.team/go/exhaustruct/v4/analyzer/config.gois excluded by!**/vendor/**,!vendor/**vendor/dev.gaijin.team/go/exhaustruct/v4/internal/comment/cache.gois excluded by!**/vendor/**,!vendor/**vendor/dev.gaijin.team/go/exhaustruct/v4/internal/comment/directive.gois excluded by!**/vendor/**,!vendor/**vendor/dev.gaijin.team/go/exhaustruct/v4/internal/pattern/list.gois excluded by!**/vendor/**,!vendor/**vendor/dev.gaijin.team/go/exhaustruct/v4/internal/structure/fields-cache.gois excluded by!**/vendor/**,!vendor/**vendor/dev.gaijin.team/go/exhaustruct/v4/internal/structure/fields.gois excluded by!**/vendor/**,!vendor/**vendor/dev.gaijin.team/go/golib/LICENSEis excluded by!**/vendor/**,!vendor/**vendor/dev.gaijin.team/go/golib/e/doc.gois excluded by!**/vendor/**,!vendor/**vendor/dev.gaijin.team/go/golib/e/err.gois excluded by!**/vendor/**,!vendor/**vendor/dev.gaijin.team/go/golib/e/log.gois excluded by!**/vendor/**,!vendor/**vendor/dev.gaijin.team/go/golib/fields/dict.gois excluded by!**/vendor/**,!vendor/**vendor/dev.gaijin.team/go/golib/fields/doc.gois excluded by!**/vendor/**,!vendor/**vendor/dev.gaijin.team/go/golib/fields/field.gois excluded by!**/vendor/**,!vendor/**vendor/dev.gaijin.team/go/golib/fields/list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/4meepo/tagalign/.gitignoreis excluded by!**/vendor/**,!vendor/**vendor/github.com/4meepo/tagalign/.golangci.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/4meepo/tagalign/.goreleaser.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/4meepo/tagalign/LICENSEis excluded by!**/vendor/**,!vendor/**vendor/github.com/4meepo/tagalign/Makefileis excluded by!**/vendor/**,!vendor/**vendor/github.com/4meepo/tagalign/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/4meepo/tagalign/options.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/4meepo/tagalign/tagalign.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Abirdcfly/dupword/.gitignoreis excluded by!**/vendor/**,!vendor/**vendor/github.com/Abirdcfly/dupword/.goreleaser.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/Abirdcfly/dupword/LICENSEis excluded by!**/vendor/**,!vendor/**vendor/github.com/Abirdcfly/dupword/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/Abirdcfly/dupword/dupword.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Abirdcfly/dupword/version.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/AdminBenni/iota-mixing/LICENSEis excluded by!**/vendor/**,!vendor/**vendor/github.com/AdminBenni/iota-mixing/pkg/analyzer/analyzer.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/AdminBenni/iota-mixing/pkg/analyzer/flags/flags.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/AlwxSin/noinlineerr/.gitignoreis excluded by!**/vendor/**,!vendor/**vendor/github.com/AlwxSin/noinlineerr/.golangci.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/AlwxSin/noinlineerr/.goreleaser.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/AlwxSin/noinlineerr/LICENSEis excluded by!**/vendor/**,!vendor/**vendor/github.com/AlwxSin/noinlineerr/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/AlwxSin/noinlineerr/noinlineerr.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/errname/LICENSEis excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/errname/pkg/analyzer/analyzer.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/errname/pkg/analyzer/facts.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/nilnil/LICENSEis excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/nilnil/pkg/analyzer/analyzer.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/nilnil/pkg/analyzer/config.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/nilnil/pkg/analyzer/func_type_stack.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/LICENSEis excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/analyzer/analyzer.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/analyzer/checkers_factory.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/analysisutil/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/analysisutil/encoded.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/analysisutil/file.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/analysisutil/format.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/analysisutil/object.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/analysisutil/pkg.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/blank_import.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/bool_compare.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/call_meta.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/checker.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/checkers_registry.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/compares.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/contains.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/empty.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/encoded_compare.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/equal_values.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/error_is_as.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/error_nil.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/expected_actual.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/float_compare.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/formatter.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/go_require.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/helpers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_basic_type.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_bool.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_comparison.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_context.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_diagnostic.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_encoded.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_error.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_format.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_http.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_interface.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_len.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_naming.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_nil.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_pkg_func.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_suite.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_testing.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/len.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/negative_positive.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/nil_compare.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/printf/LICENSEis excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/printf/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/printf/printf.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/regexp.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/require_error.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/suite_broken_parallel.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/suite_dont_use_pkg.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/suite_extra_assert_call.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/suite_method_signature.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/suite_subtest_run.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/suite_thelper.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/checkers/useless_assert.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/config/config.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/config/flag_value_types.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Antonboom/testifylint/internal/testify/const.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/BurntSushi/toml/.gitignoreis excluded by!**/vendor/**,!vendor/**vendor/github.com/BurntSushi/toml/COPYINGis excluded by!**/vendor/**,!vendor/**vendor/github.com/BurntSushi/toml/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/BurntSushi/toml/decode.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/BurntSushi/toml/deprecated.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/BurntSushi/toml/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/BurntSushi/toml/encode.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/BurntSushi/toml/error.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/BurntSushi/toml/internal/tz.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/BurntSushi/toml/lex.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/BurntSushi/toml/meta.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/BurntSushi/toml/parse.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/BurntSushi/toml/type_fields.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/BurntSushi/toml/type_toml.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Djarvur/go-err113/.gitignoreis excluded by!**/vendor/**,!vendor/**vendor/github.com/Djarvur/go-err113/.golangci.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/Djarvur/go-err113/.travis.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/Djarvur/go-err113/LICENSEis excluded by!**/vendor/**,!vendor/**vendor/github.com/Djarvur/go-err113/README.adocis excluded by!**/vendor/**,!vendor/**vendor/github.com/Djarvur/go-err113/comparison.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Djarvur/go-err113/definition.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Djarvur/go-err113/err113.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/.gitignoreis excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/.golangci.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/LICENSE.txtis excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/Makefileis excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/SECURITY.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/collection.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/constraints.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/version.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/MirrexOne/unqueryvet/.gitignoreis excluded by!**/vendor/**,!vendor/**vendor/github.com/MirrexOne/unqueryvet/.golangci.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/MirrexOne/unqueryvet/.unqueryvet.example.yamlis excluded by!**/vendor/**,!vendor/**vendor/github.com/MirrexOne/unqueryvet/CONTRIBUTING.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/MirrexOne/unqueryvet/Dockerfileis excluded by!**/vendor/**,!vendor/**vendor/github.com/MirrexOne/unqueryvet/LICENSEis excluded by!**/vendor/**,!vendor/**vendor/github.com/MirrexOne/unqueryvet/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/MirrexOne/unqueryvet/RELEASE.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/MirrexOne/unqueryvet/Taskfile.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/MirrexOne/unqueryvet/action.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/MirrexOne/unqueryvet/analyzer.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/MirrexOne/unqueryvet/config.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/analyzer.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/concat.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/filter.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/fixes.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/format.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/n1detector.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/bun.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/ent.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/goqu.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/gorm.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/interface.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/jet.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/pgx.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/reform.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/rel.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/sqlboiler.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/sqlc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/sqlx.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/squirrel.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqli_scanner.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/tx_leak_detector.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/MirrexOne/unqueryvet/pkg/config/config.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/MirrexOne/unqueryvet/schema.jsonis excluded by!**/vendor/**,!vendor/**vendor/github.com/OpenPeeDeeP/depguard/v2/.gitignoreis excluded by!**/vendor/**,!vendor/**vendor/github.com/OpenPeeDeeP/depguard/v2/LICENSEis excluded by!**/vendor/**,!vendor/**vendor/github.com/OpenPeeDeeP/depguard/v2/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/OpenPeeDeeP/depguard/v2/depguard.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/OpenPeeDeeP/depguard/v2/internal/utils/errors.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/OpenPeeDeeP/depguard/v2/internal/utils/variables.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/OpenPeeDeeP/depguard/v2/settings.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/.editorconfigis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/.gitignoreis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/.golangci.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/.goreleaser.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/AGENTS.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/Bitfileis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/COPYINGis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/Dockerfileis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/Justfileis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/biome.jsonis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/chroma.jpgis excluded by!**/*.jpg,!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/coalesce.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/colour.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/delegate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/emitters.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/formatter.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/formatters/api.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/formatters/html/html.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/formatters/json.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/formatters/svg/font_liberation_mono.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/formatters/svg/svg.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/formatters/tokens.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/formatters/tty_indexed.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/formatters/tty_truecolour.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/iterator.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexer.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/caddyfile.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/cl.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/dns.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/emacs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/abap.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/abnf.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/actionscript.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/actionscript_3.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/ada.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/agda.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/al.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/alloy.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/angular2.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/antlr.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/apacheconf.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/apl.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/applescript.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/arangodb_aql.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/arduino.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/armasm.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/atl.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/autohotkey.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/autoit.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/awk.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/ballerina.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/bash.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/bash_session.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/batchfile.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/beef.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/bibtex.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/bicep.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/blitzbasic.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/bnf.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/bqn.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/brainfuck.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/c#.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/c++.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/c.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/c3.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cap_n_proto.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cassandra_cql.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/ceylon.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cfengine3.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cfstatement.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/chaiscript.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/chapel.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cheetah.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/clojure.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cmake.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cobol.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/coffeescript.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/common_lisp.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/coq.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/core.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/crystal.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/css.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/csv.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cue.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cython.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/d.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/dart.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/dax.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/desktop_entry.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/devicetree.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/diff.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/django_jinja.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/dns.xmlis excluded by!**/vendor/**,!vendor/**vendor/github.com/alecthomas/chroma/v2/lexers/embedded/docker.xmlis excluded by!**/vendor/**,!vendor/**
📒 Files selected for processing (2)
Makefilego.mod
198dc47 to
bf514d5
Compare
|
@JoelSpeed: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This re-adds a
make linttarget to the makefile.This version leverages a vendored
golangci-lintcodebase, meaning that the anyone running locally, or CI, will always use a consistent version, which is tracked in thego.modfile and updated periodically by someone runninggo get -tool github.com/golangci/golangci-lint/v2/cmd/golangci-lint@latestThe drawbacks of this approach are that it adds a bunch of stuff to the go.mod as indirects. You could create a separate
toolsgo module if you don't want this to impact your main module go.mod in this waySummary by CodeRabbit