Skip to content

wip: Configmap tls injection before squashing#1359

Open
ingvagabund wants to merge 10 commits intoopenshift:mainfrom
ingvagabund:configmap-tls-injection-before-squashing
Open

wip: Configmap tls injection before squashing#1359
ingvagabund wants to merge 10 commits intoopenshift:mainfrom
ingvagabund:configmap-tls-injection-before-squashing

Conversation

@ingvagabund
Copy link
Member

@ingvagabund ingvagabund commented Mar 25, 2026

/hold

Only to make all the commits from #1322 available before the final squashing for the final review.

ingvagabund and others added 10 commits March 24, 2026 12:09
@ingvagabund
deps: update dependencies for TLS configuration injection
3f9e385
@ingvagabund
feat(resource builder): allow to inject tls configuration into annota…
2656525 
…ted config maps
@ingvagabund
Address review comments (to be squashed before merging)
b3d82f4
@ingvagabund
fix: new unit test for custom and empty tls configuration
77d985b
@ingvagabund
refactor: use cmp.Diff for comparision
a4254f2
@DavidHurta @ingvagabund
lib/resourcebuilder/core.go: Error out on any error during TLS injection
a0a0fab 
And some minor modifications here and there. Preferably to be squashed
before merging.
@DavidHurta @claude @ingvagabund
lib/resourcebuilder/core: Add tests for updateRNodeWithTLSSettings
3e06bb6 
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@ingvagabund
feat(lib/resourcebuilder.modifyConfigMap): accept config.openshift.io…
05e80c1 
…/v1.GenericControllerConfig as well
@ingvagabund
test(TestModifyConfigMap): no-op for invalid yaml file or an unsuppor…
83faa35 
…ted apiversion
@ingvagabund
fix: return an error when APIServer CR is not found to avoid falling …
ea702a6 
…back to defaults

Falling back to the library-go's ObserveTLSSecurityProfile defaults
can cause a temporary flip to different TLS configuration that does not
adhere the centralized TLS configuration. To avoid any unexpected
changes error right away and wait until the CR is available again.
Meantime, do not update the corresponding CM.
@coderabbitai
Copy link

coderabbitai bot commented Mar 25, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cb189422-fd77-4b5b-aa2b-ca28ecc8acbe

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 25, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 25, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ingvagabund
Once this PR has been reviewed and has the lgtm label, please assign pratikmahajan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ingvagabund ingvagabund mentioned this pull request Mar 25, 2026
Open
@ingvagabund
Copy link
Member Author

ingvagabund commented Mar 25, 2026

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 25, 2026

@ingvagabund: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-techpreview ea702a6 link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-agnostic-ovn-upgrade-into-change ea702a6 link true /test e2e-agnostic-ovn-upgrade-into-change
ci/prow/images ea702a6 link true /test images
ci/prow/e2e-agnostic-ovn-techpreview-serial-3of3 ea702a6 link true /test e2e-agnostic-ovn-techpreview-serial-3of3

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ingvagabund @DavidHurta