Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 2, 2024

Bumps github.com/openshift/osd-network-verifier from 0.4.11 to 1.0.0.

Release notes

Sourced from github.com/openshift/osd-network-verifier's releases.

v1.0.0

What's Changed

New Contributors

Full Changelog: openshift/osd-network-verifier@v0.4.11...v1.0.0

v1.0.0-rc.1

What's Changed

... (truncated)

Commits
  • 87b6710 Tune polling intervals for an overall faster ValidateEgress() (#260)
  • 8024971 Add fallback if we fail to convert github list to a curl string (#257)
  • 0069dfe Add a flag to provide a custom location for the egress URL list (#255)
  • c0a8ef8 add '.yaml' to end of github path (#256)
  • df40c76 [OSD-24208](https://issues.redhat.com//browse/OSD-24208) (Part 2): Add official ARM support to the curl probe (#251)
  • d8d8d37 Fetch url list from github first before falling back to local (#254)
  • d035876 Synchronize results output for cleangoldenami script (#253)
  • ee0b6e0 Update existing GCP network verifier framework (#249)
  • 239f69d Standardize how we set defaults and clarify egressURL output (#252)
  • e7a7c7b [OSD-24207] Updated logic to delete oldest image of each type per region (#244)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/openshift/osd-network-verifier](https://github.com/openshift/osd-network-verifier) from 0.4.11 to 1.0.0.
- [Release notes](https://github.com/openshift/osd-network-verifier/releases)
- [Changelog](https://github.com/openshift/osd-network-verifier/blob/main/RELEASE.md)
- [Commits](openshift/osd-network-verifier@v0.4.11...v1.0.0)

---
updated-dependencies:
- dependency-name: github.com/openshift/osd-network-verifier
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Aug 2, 2024
@openshift-ci openshift-ci bot requested review from bng0y and sam-nguyen7 August 2, 2024 00:33
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 2, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2024

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@typeid typeid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm
/approve

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 15, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dependabot[bot], typeid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.51%. Comparing base (324519f) to head (5605aa0).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #303   +/-   ##
=======================================
  Coverage   38.51%   38.51%           
=======================================
  Files          20       20           
  Lines        1594     1594           
=======================================
  Hits          614      614           
  Misses        940      940           
  Partials       40       40           

@typeid
Copy link
Member

typeid commented Aug 15, 2024

This is not great. I'll take a look at how we can make sure that bumping the main go.mod doesn't require tidying the consuming go.mod of interceptor.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 324519f and 2 for PR HEAD 5605aa0 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d4dc5f1 and 1 for PR HEAD 5605aa0 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d708d37 and 0 for PR HEAD 5605aa0 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 21, 2024

@dependabot[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/lint 5605aa0 link true /test lint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/hold

Revision 5605aa0 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2024
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 29, 2024

Superseded by #306.

@dependabot dependabot bot closed this Aug 29, 2024
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/openshift/osd-network-verifier-1.0.0 branch August 29, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dependencies Pull requests that update a dependency file do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. go Pull requests that update Go code lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants