[release-4.22] OCPBUGS-86118: Add unit and e2e test coverage for cert rotation redeployment

[jhadvig]

Summary

• Cherry-pick of 0a408ad adding unit and e2e test coverage for cert rotation redeployment
• Follow-up to OCPBUGS-63502 fix which was merged without test coverage
• Adds TestServingCertAnnotationChangesOnRotation, TestServingCertAnnotationInResourceAnnotations (unit) and TestCertRotationTriggersRollout (e2e)

Test plan

• Unit tests pass: go test ./pkg/console/subresource/deployment/ -run TestServingCert
• E2E test passes on a cluster: TestCertRotationTriggersRollout

Jira: https://issues.redhat.com/browse/OCPBUGS-86118

[openshift-ci-robot]

@jhadvig: This pull request references Jira Issue OCPBUGS-86118, which is invalid:

• expected the bug to target the "4.22.0" version, but no target version was set
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected dependent Jira Issue OCPBUGS-86117 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is New instead
• expected dependent Jira Issue OCPBUGS-86117 to target a version in 5.0.0, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

• Cherry-pick of 0a408ad adding unit and e2e test coverage for cert rotation redeployment
• Follow-up to OCPBUGS-63502 fix which was merged without test coverage
• Adds TestServingCertAnnotationChangesOnRotation, TestServingCertAnnotationInResourceAnnotations (unit) and TestCertRotationTriggersRollout (e2e)

Test plan

• Unit tests pass: go test ./pkg/console/subresource/deployment/ -run TestServingCert
• E2E test passes on a cluster: TestCertRotationTriggersRollout

Jira: https://issues.redhat.com/browse/OCPBUGS-86118

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 28d758e3-ee48-4b53-b236-5db4b59e029e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jhadvig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jhadvig: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-console	4cf73e5	link	true	/test e2e-aws-console

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.