Skip to content

NO-JIRA: Update README to add warning not to fork this repo#75

Merged
openshift-merge-bot[bot] merged 4 commits intoopenshift:mainfrom
logonoff:main
Mar 14, 2025
Merged

NO-JIRA: Update README to add warning not to fork this repo#75
openshift-merge-bot[bot] merged 4 commits intoopenshift:mainfrom
logonoff:main

Conversation

@logonoff
Copy link
Copy Markdown
Member

@logonoff logonoff commented Feb 11, 2025

after:

image

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 11, 2025
@openshift-ci-robot
Copy link
Copy Markdown

@logonoff: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff
Copy link
Copy Markdown
Member Author

/cc @jhadvig @vojtechszocs

@openshift-ci openshift-ci Bot requested a review from jhadvig February 11, 2025 16:18
Copy link
Copy Markdown
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also mention that forking this repo will cause the forked repo to appear and behave as a github template repo, rather than a standard one?

Comment thread README.md Outdated
Co-authored-by: Jon Jackson <jonjacks@redhat.com>
Comment thread README.md Outdated
Copy link
Copy Markdown
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 11, 2025
@logonoff
Copy link
Copy Markdown
Member Author

/retest

/label px-approved qe-approved

docs approval
/cc @opayne1

@openshift-ci openshift-ci Bot requested a review from opayne1 February 12, 2025 00:53
@logonoff
Copy link
Copy Markdown
Member Author

/retest

/label px-approved
/label qe-approved

@openshift-ci openshift-ci Bot added px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Feb 14, 2025
Copy link
Copy Markdown

@opayne1 opayne1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small comments. Thanks!

Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2025
@spadgett
Copy link
Copy Markdown
Member

/retest

@logonoff
Copy link
Copy Markdown
Member Author

logonoff commented Mar 6, 2025

hey @TheRealJon and @opayne1, could you take another look?

Copy link
Copy Markdown

@opayne1 opayne1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

/label docs-approved

@openshift-ci openshift-ci Bot added the docs-approved Signifies that Docs has signed off on this PR label Mar 6, 2025
@vojtechszocs
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2025
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, TheRealJon, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [TheRealJon,vojtechszocs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@logonoff
Copy link
Copy Markdown
Member Author

/retest

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 14, 2025

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit addca71 into openshift:main Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants