Skip to content

NO-JIRA: add imagepullsecret support to chart#87

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
pfeifferj:gh-86-add-imagepullsecret-to-chart
May 29, 2025
Merged

NO-JIRA: add imagepullsecret support to chart#87
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
pfeifferj:gh-86-add-imagepullsecret-to-chart

Conversation

@pfeifferj
Copy link
Member

@pfeifferj pfeifferj commented Apr 26, 2025

this PR adds:

  • a new imagePullSecrets array field to the plugin section in values.yaml (defaulting to empty array)
  • a conditional section in the deployment.yaml template that includes the pull secrets configuration when provided

closes #86

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 26, 2025
@openshift-ci-robot
Copy link

@pfeifferj: This pull request explicitly references no jira issue.

Details

In response to this:

this PR adds:

  • a new imagePullSecrets array field to the plugin section in values.yaml (defaulting to empty array)
  • a conditional section in the deployment.yaml template that includes the pull secrets configuration when provided

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from rhamilto and vojtechszocs April 26, 2025 14:47
@openshift-ci
Copy link

openshift-ci bot commented Apr 26, 2025

@pfeifferj: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2025
@openshift-ci
Copy link

openshift-ci bot commented May 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, pfeifferj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2025
@jhadvig jhadvig added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 29, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit bc6a745 into openshift:main May 29, 2025
4 checks passed
@pfeifferj pfeifferj deleted the gh-86-add-imagepullsecret-to-chart branch May 29, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add imagePullSecrets support to the helm chart

3 participants