Remove incorrect OpenShift version from cluster overview page#1065
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Jan 12, 2019
Merged
Conversation
We can later add version from the ClusterVersion resource.
openshift-ci-robot
added
size/M
Member
Author
|
jenkins rebuild |
8 similar comments
Member
Author
|
jenkins rebuild |
Member
Author
|
jenkins rebuild |
Member
Author
|
jenkins rebuild |
Member
Author
|
jenkins rebuild |
Member
Author
|
jenkins rebuild |
Member
Author
|
jenkins rebuild |
Member
Author
|
jenkins rebuild |
Member
Author
|
jenkins rebuild |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenShift version endpoint no longer returns a version. The version is available on the cluster settings page where we get the ClusterVersion resource. Remove OpenShift version from the cluster overview page for now to avoid showing an incorrect value. We might want to add the correct version and cluster id to this page later.
When #1030 merges, we can connect to redux to get the cluster id (and possibly add version to redux as well).
/assign @rhamilto