Bug 2043572: Deleting namespace store in UI secrets remains #11777
Conversation
Remove secret which was created automatically during namespace creation and Keep the secret if its created manually and assigned to namespace. Signed-off-by: Timothy Asir Jeyasingh <tjeyasin@redhat.com>
|
@bipuladh , @GowthamShanmugam , Please review |
1 similar comment
|
@bipuladh , @GowthamShanmugam , Please review |
openshift-ci
bot
added
bugzilla/severity-low
|
@TimothyAsirJeyasing: This pull request references Bugzilla bug 2043572, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @TimothyAsirJeyasing. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: TimothyAsirJeyasing The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| props.handlePromise(k8sKill(kind, resource, {}, {}, json), () => { | ||
| props.close(); | ||
|
|
||
| if (resource.kind === 'NamespaceStore') { |
There was a problem hiding this comment.
I think it needs to be deleted using owner ref
There was a problem hiding this comment.
i think this is migrated to odf-console.
cc: @rexagod
There was a problem hiding this comment.
Here it deletes the secret only if the secret is created automatically
|
/close |
|
@SanjalKatiyar: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@TimothyAsirJeyasing: This pull request references Bugzilla bug 2043572. The bug has been updated to no longer refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3 participants
Remove secret which was created automatically during
namespace creation and Keep the secret if its created
manually and assigned to namespace.
Signed-off-by: Timothy Asir Jeyasingh tjeyasin@redhat.com