Skip to content

OCPBUGS-52589: update @types/react to v17, use new JSX transform#14847

Closed
logonoff wants to merge 4 commits intoopenshift:mainfrom
logonoff:OCPBUGS-52589-react-types
Closed

OCPBUGS-52589: update @types/react to v17, use new JSX transform#14847
logonoff wants to merge 4 commits intoopenshift:mainfrom
logonoff:OCPBUGS-52589-react-types

Conversation

@logonoff
Copy link
Copy Markdown
Member

@logonoff logonoff commented Mar 7, 2025 •
edited
Loading

  • update @types/react to be in sync with react version
  • use new JSX transform

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 7, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 7, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Mar 7, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 7, 2025

@logonoff: This pull request references Jira Issue OCPBUGS-52589, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from yapei March 7, 2025 15:50
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: logonoff
Once this PR has been reviewed and has the lgtm label, please assign vojtechszocs for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/helm Related to helm-plugin component/knative Related to knative-plugin component/metal3 Related to metal3-plugin component/monitoring Related to monitoring component/olm Related to OLM component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology kind/cypress Related to Cypress e2e integration testing labels Mar 7, 2025
@logonoff logonoff force-pushed the OCPBUGS-52589-react-types branch from 5533920 to f50d389 Compare March 7, 2025 16:13
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 7, 2025

@logonoff: This pull request references Jira Issue OCPBUGS-52589, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

  • update @types/react to be in sync with react version
  • use new JSX transform

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff logonoff marked this pull request as ready for review March 7, 2025 16:41
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 7, 2025
@logonoff
Copy link
Copy Markdown
Member Author

logonoff commented Mar 7, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2025
@logonoff logonoff changed the title OCPBUGS-52589: update @types/react to v17 OCPBUGS-52589: update @types/react to v17, use new JSX transform Mar 7, 2025
@logonoff logonoff force-pushed the OCPBUGS-52589-react-types branch 4 times, most recently from 790eb1c to a58e4f1 Compare March 11, 2025 04:02
@logonoff
Copy link
Copy Markdown
Member Author

logonoff commented Mar 11, 2025

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2025
@logonoff
Copy link
Copy Markdown
Member Author

logonoff commented Mar 11, 2025

/retest-required

@logonoff
Copy link
Copy Markdown
Member Author

logonoff commented Mar 11, 2025

/retest

@logonoff logonoff closed this Mar 12, 2025
@logonoff logonoff force-pushed the OCPBUGS-52589-react-types branch from a58e4f1 to 01c6e0b Compare March 12, 2025 15:01
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 12, 2025

@logonoff: This pull request references Jira Issue OCPBUGS-52589. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

  • update @types/react to be in sync with react version
  • use new JSX transform

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff
Copy link
Copy Markdown
Member Author

logonoff commented Mar 12, 2025

superseded by #14864

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 12, 2025

@logonoff: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 01c6e0b link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-gcp-console 01c6e0b link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yapei yapei Awaiting requested review from yapei

@christoph-jerolimov christoph-jerolimov Awaiting requested review from christoph-jerolimov

@jhadvig jhadvig Awaiting requested review from jhadvig

Assignees

No one assigned

Labels

component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/helm Related to helm-plugin component/knative Related to knative-plugin component/metal3 Related to metal3-plugin component/monitoring Related to monitoring component/olm Related to OLM component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/cypress Related to Cypress e2e integration testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@logonoff @openshift-ci-robot