[release-4.18] NO-JIRA: Bump builder image to v29

[logonoff]

See https://issues.redhat.com/browse/CONSOLE-5071

This PR (and its "backports" all the way to 4.12) aim to add compatibility with node.js 22/24 when building console.

This is because yarn berry requires at least node 18, and we will probably want to consistently use our tectonic-console-builder:v29 image across these versions.

For 4.19+, we are already using webpack 5 due to #14378, so there is already node.js 18+ support. The package.json script changes can instead be merged later when we update yarn to v4.

Changes:

Note: the list of changes are descriptive for all backport PRs. Some of these changes may not apply to every backport.

4.18 to 4.12

• Format the dependencies field of applicable package.json files to align with yarn berry's auto formatting
• Remove the for loop in yarn compile in the dynamic plugin sdk. This syntax no longer works in yarn berry, and having separate scripts is also more readable
• Bump image build root to tectonic-console-builder:v29 to get node 22 (which is needed for yarn v4)
• Bump webpack and terser-webpack-plugin to get their md4 polyfill, which is used just for file names. This is required for node 18+ support

4.16 to 4.12

• Removed reviewer responsibility from people who have left the project (by request of former dev-console team members)

4.14 to 4.12

• Install Chrome for Testing to get Protractor working. tectonic-console-builder:v29 does not include the required Chrome v114 required to run the tests

4.13 to 4.12

• Bump ts-json-schema-generator to at least 0.93.0 (and typescript to 4.47.0), which removes usage of deprecated node utils, which is removed in node 23
  • In the doc parser script, backport changes to getCommentText from CONSOLE-2501: Upgrade TypeScript version to 4.5 #12821 that made the function work in TypeScript 4.47.0

Backports:

• [release-4.17] NO-JIRA: Bump builder image to v29 #15994 4.17
• [release-4.16] NO-JIRA: Bump builder image to v29 #15993 4.16
• [release-4.15] NO-JIRA: Bump builder image to v29 #15992 4.15
• [release-4.14] NO-JIRA: Bump builder image to v29 #15991 4.14
• [release-4.13] NO-JIRA: Bump builder image to v29 #15989 4.13
• [release-4.12] NO-JIRA: Bump builder image to v29 #15988 4.12

[openshift-ci-robot]

@logonoff: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

• do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

• 🔍 Trigger a full review

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[vojtechszocs]

/lgtm

[logonoff]

these are dev dependency changes that do not affect the build
/verified by CI

[logonoff]

/label backport-risk-assessed

[openshift-ci-robot]

@logonoff: This PR has been marked as verified by CI.

Details

In response to this:

these are dev dependency changes that do not affect the build
/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@logonoff: This pull request explicitly references no jira issue.

Details

In response to this:

This PR (and its "backports" all the way to 4.12) aim to add compatibility with node.js 22 when building console.

This is because yarn berry requires at least node 18, and we will probably want to consistently use our tectonic-console-builder:v29 image across these versions.

For 4.19+, we are already using webpack 5 due to #14378, so there is already node.js 18+ support. The package.json script changes can instead be merged later when we update yarn to v4.

Changes:

• Where applicable, removed reviewer responsibility from people who have left the project
• Bump webpack and terser-webpack-plugin to get their md4 polyfill, which is used just for file names. This is required for node 18+ support
• Bump ts-json-schema-generator to at least 0.93.0 (and typescript to 4.47.0), which removes usage of deprecated node utils, which is removed in node 23
• In the doc parser script, backport getCommentText
• Rename yarn eslint script to lint-files because yarn berry no longer supports shadowing of this kind
• Format the dependencies field of applicable package.json files to align with yarn berry's auto formatting
• Remove the for loop in yarn compile in the dynamic plugin sdk. This syntax no longer works in yarn berry, and having separate scripts is also more readable

Backports:

• [release-4.17] NO-JIRA: Bump builder image to v29 #15994 4.17
• [release-4.16] NO-JIRA: Bump builder image to v29 #15993 4.16
• [release-4.15] NO-JIRA: Bump builder image to v29 #15992 4.15
• [release-4.14] NO-JIRA: Bump builder image to v29 #15991 4.14
• [release-4.13] NO-JIRA: Bump builder image to v29 #15989 4.13
• [release-4.12] NO-JIRA: Bump builder image to v29 #15988 4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[logonoff]

/retitle [release-4.18] NO-JIRA: Bump builder image to v29

[logonoff]

changes only affect devdependencies and node version

/verified by CI

[openshift-ci-robot]

@logonoff: This PR has been marked as verified by CI.

Details

In response to this:

changes only affect devdependencies and node version

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@logonoff: This pull request explicitly references no jira issue.

Details

In response to this:

See https://issues.redhat.com/browse/CONSOLE-5071

This PR (and its "backports" all the way to 4.12) aim to add compatibility with node.js 22/24 when building console.

This is because yarn berry requires at least node 18, and we will probably want to consistently use our tectonic-console-builder:v29 image across these versions.

For 4.19+, we are already using webpack 5 due to #14378, so there is already node.js 18+ support. The package.json script changes can instead be merged later when we update yarn to v4.

Changes:

• Where applicable, removed reviewer responsibility from people who have left the project
• Bump webpack and terser-webpack-plugin to get their md4 polyfill, which is used just for file names. This is required for node 18+ support
• Bump ts-json-schema-generator to at least 0.93.0 (and typescript to 4.47.0), which removes usage of deprecated node utils, which is removed in node 23
• In the doc parser script, backport changes to getCommentText that made the function work in TypeScript 4.47.0
• Format the dependencies field of applicable package.json files to align with yarn berry's auto formatting
• Remove the for loop in yarn compile in the dynamic plugin sdk. This syntax no longer works in yarn berry, and having separate scripts is also more readable
• Bump image build root to tectonic-console-builder:v29 for node 22
• Where applicable, install Chrome for Testing to get Protractor working. tectonic-console-builder:v29 does not include the required Chrome v114 required to run the tests

Backports:

• [release-4.17] NO-JIRA: Bump builder image to v29 #15994 4.17
• [release-4.16] NO-JIRA: Bump builder image to v29 #15993 4.16
• [release-4.15] NO-JIRA: Bump builder image to v29 #15992 4.15
• [release-4.14] NO-JIRA: Bump builder image to v29 #15991 4.14
• [release-4.13] NO-JIRA: Bump builder image to v29 #15989 4.13
• [release-4.12] NO-JIRA: Bump builder image to v29 #15988 4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[TheRealJon]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, TheRealJon, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [TheRealJon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment