Skip to content

[release-4.21] OCPBUGS-79533: enable keyboard shortcut for DataViewTextFilter#16195

Open
rhamilto wants to merge 1 commit intoopenshift:release-4.21from
rhamilto:OCPBUGS-79533
Open

[release-4.21] OCPBUGS-79533: enable keyboard shortcut for DataViewTextFilter#16195
rhamilto wants to merge 1 commit intoopenshift:release-4.21from
rhamilto:OCPBUGS-79533

Conversation

@rhamilto
Copy link
Member

Summary

This PR cherry-picks a fix to enable keyboard shortcuts for the DataViewTextFilter component. The change creates a custom DataViewTextFilter component to replace PatternFly's built-in version, enabling better keyboard shortcut support.

Key changes:

  • Created new DataViewTextFilter.tsx component
  • Updated imports in ConsoleDataView.tsx to use local component
  • Removed responsive width constraints from autocomplete and filter toolbar styles
  • Updated integration test selectors to match new aria-label

Test plan

  • Verify name filter works correctly in DataView-based lists
  • Verify keyboard shortcuts work as expected
  • Test responsive layout on mobile/tablet breakpoints
  • Run integration tests for helm and list pages

🤖 Generated with Claude Code

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 25, 2026
@openshift-ci-robot
Copy link
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-63391, which is invalid:

  • expected the bug to target either version "4.21." or "openshift-4.21.", but it targets "4.22.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
  • expected Jira Issue OCPBUGS-63391 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

This PR cherry-picks a fix to enable keyboard shortcuts for the DataViewTextFilter component. The change creates a custom DataViewTextFilter component to replace PatternFly's built-in version, enabling better keyboard shortcut support.

Key changes:

  • Created new DataViewTextFilter.tsx component
  • Updated imports in ConsoleDataView.tsx to use local component
  • Removed responsive width constraints from autocomplete and filter toolbar styles
  • Updated integration test selectors to match new aria-label

Test plan

  • Verify name filter works correctly in DataView-based lists
  • Verify keyboard shortcuts work as expected
  • Test responsive layout on mobile/tablet breakpoints
  • Run integration tests for helm and list pages

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto rhamilto changed the title OCPBUGS-63391: enable keyboard shortcut for DataViewTextFilter [release-4.21] OCPBUGS-63391: enable keyboard shortcut for DataViewTextFilter Mar 25, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 25, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d667eabf-7b54-43f8-8339-14e6344c654c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from jhadvig and sanketpathak March 25, 2026 12:39
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/helm Related to helm-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cypress Related to Cypress e2e integration testing labels Mar 25, 2026
@rhamilto rhamilto changed the title [release-4.21] OCPBUGS-63391: enable keyboard shortcut for DataViewTextFilter [release-4.21] OCPBUGS-79533: enable keyboard shortcut for DataViewTextFilter Mar 25, 2026
@openshift-ci-robot
Copy link
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-79533, which is invalid:

  • expected Jira Issue OCPBUGS-79533 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

This PR cherry-picks a fix to enable keyboard shortcuts for the DataViewTextFilter component. The change creates a custom DataViewTextFilter component to replace PatternFly's built-in version, enabling better keyboard shortcut support.

Key changes:

  • Created new DataViewTextFilter.tsx component
  • Updated imports in ConsoleDataView.tsx to use local component
  • Removed responsive width constraints from autocomplete and filter toolbar styles
  • Updated integration test selectors to match new aria-label

Test plan

  • Verify name filter works correctly in DataView-based lists
  • Verify keyboard shortcuts work as expected
  • Test responsive layout on mobile/tablet breakpoints
  • Run integration tests for helm and list pages

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-79533, which is invalid:

  • expected dependent Jira Issue OCPBUGS-63391 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto
Copy link
Member Author

/test backend

Copy link
Member

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2026
@rhamilto
Copy link
Member Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 26, 2026

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rhamilto
Copy link
Member Author

/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 26, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 26, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. component/core Related to console core functionality component/helm Related to helm-plugin jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/cypress Related to Cypress e2e integration testing lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants