NO-ISSUE: frontend/packages/console-dynamic-plugin-sdk/README: 4.22 doesn't support PatternFly 5#16206
Conversation
…port PatternFly 6 Tidying up the data landed in b38b0cd (CONSOLE-4439: Update release note docs, 2026-03-09, openshift#14957), because 4.22 doesn't support PF 6 alone and also support PF 5 and 6.
openshift-ci-robot
added
the
jira/valid-reference
|
@wking: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
📝 WalkthroughWalkthroughThe PatternFly compatibility guidance table in the console-dynamic-plugin-sdk README was updated to refine the Console version range for new dynamic plugins targeting PatternFly 6.x. The supported range narrowed from ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@frontend/packages/console-dynamic-plugin-sdk/README.md`:
- Line 116: The PatternFly compatibility table is inconsistent for 4.22.x;
update the table so 4.22.x is shown as supporting both PF5 and PF6 (the
mixed-support row that currently reads "4.19.x - 4.21.x | 6.x + 5.x" should
include 4.22.x) and remove 4.22.x from the PF6-only row (the row that currently
lists "4.22.x | 6.x"). Ensure the table text and the accompanying note ("New
dynamic plugins should use PF 6.x") are consistent with the PR objective that
4.22 supports both PF5 and PF6.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: bd2185bf-f4b8-48ca-ba3f-a5a0d923683c
📒 Files selected for processing (1)
frontend/packages/console-dynamic-plugin-sdk/README.md
📜 Review details
🧰 Additional context used
📓 Path-based instructions (1)
**
⚙️ CodeRabbit configuration file
-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.
Files:
frontend/packages/console-dynamic-plugin-sdk/README.md
openshift-ci
bot
added
lgtm
spadgett
changed the title
logonoff
left a comment
logonoff
left a comment
There was a problem hiding this comment.
/verified bypass
/label px-approved
/label docs-approved
/lgtm
openshift-ci
bot
added
px-approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logonoff, spadgett, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified bypass |
openshift-ci-robot
added
the
verified
|
@logonoff: The DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@wking: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
Tidying up the data landed in b38b0cd (#14957), because 4.22 doesn't support PF 6 alone and also support PF 5 and 6.
Summary by CodeRabbit