OCPBUGS-81331: Storage > VolumeSnapshots and VAC throws error

[cajieh]

Bug Description

VolumeSnapshots and VAC details pages crash with "Something wrong happened" error when accessed via Storage > VolumeAttributesClasses and VolumeSnapshots.

Root Cause

RegressionL The Firehose → useK8sWatchResource migration changes

Solution

Add defensive guard in headings.tsx:

• {_.isFunction(customActionMenu)
• ? customActionMenu(kindObj, data, extraResources)
• : customActionMenu}

• {hasData &&
• (_.isFunction(customActionMenu)

• ? customActionMenu(kindObj, data, extraResources)
  

• : customActionMenu)}
  

Ensures action menu only renders after data loads.

Impact

Fixes:

• VolumeSnapshots details page
• VolumeAttributesClasses(VAC) details page
• All other pages using customActionMenu prop

Low - adds safety guard without changing logic

Screenshots:

Before:

After:

[openshift-ci-robot]

@cajieh: This pull request references Jira Issue OCPBUGS-81331, which is invalid:

• expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cajieh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [cajieh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 2ae044de-699b-435f-9d95-7427857bd74b

📥 Commits

Reviewing files that changed from the base of the PR and between 46a9c16 and e947ec1.

📒 Files selected for processing (1)

• frontend/public/components/utils/headings.tsx

📜 Recent review details

🧰 Additional context used

📓 Path-based instructions (1)

**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

• frontend/public/components/utils/headings.tsx

🔇 Additional comments (1)

frontend/public/components/utils/headings.tsx (1)

150-153: Good fix: customActionMenu is now safely gated by hasData.

This prevents premature evaluation of function-form menus while obj.data is still empty and aligns behavior with other action render paths.

---

📝 Walkthrough

Walkthrough

The ConnectedPageHeading component in frontend/public/components/utils/headings.tsx has been modified to conditionally render the customActionMenu prop only when hasData evaluates to true. Previously, this menu was rendered regardless of whether obj.data was present or populated. The change wraps both conditional branches (function and non-function variants) of customActionMenu behind the hasData check, bringing consistency with other action elements in the component that already enforce this requirement. The modification spans 7 lines of code changes.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cajieh]

/jira refresh

[openshift-ci-robot]

@cajieh: This pull request references Jira Issue OCPBUGS-81331, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@cajieh: This pull request references Jira Issue OCPBUGS-81331, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

Bug Description

VolumeSnapshots and VAC details pages crash with "Something wrong happened" error when accessed via Storage > VolumeAttributesClasses and VolumeSnapshots.

Root Cause

RegressionL The Firehose → useK8sWatchResource migration changes

Solution

Add defensive guard in headings.tsx:

• {_.isFunction(customActionMenu)
• ? customActionMenu(kindObj, data, extraResources)
• : customActionMenu}

• {hasData &&
• (_.isFunction(customActionMenu)

• ? customActionMenu(kindObj, data, extraResources)
  

• : customActionMenu)}
  

Ensures action menu only renders after data loads.

Impact

Fixes:

• VolumeSnapshots details page
• VolumeAttributesClasses(VAC) details page
• All other pages using customActionMenu prop

Low - adds safety guard without changing logic

Screenshots:

Before:

After:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[cajieh]

/test e2e-gcp-console

[openshift-ci]

@cajieh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.