[release-4.20] OCPBUGS-77037: Fix QueryBrowser import to use SDK path to avoid circular dependency by Leo6Leo · Pull Request #16222 · openshift/console

Leo6Leo · 2026-03-30T18:24:24Z

Summary

Custom fix for release-4.20 replacing the failed cherry-pick in [release-4.20] OCPBUGS-77037: Fixed Metrics page React error #306 by exporting QueryBrowser component #16040
Imports QueryBrowser from @console/dynamic-plugin-sdk/src/lib-core instead of @console/shared/src/components/query-browser to break the circular import that causes React error Add Alert Manager proxy #306 on the Metrics page
Updates the test file to import from the same SDK path so Enzyme's find(QueryBrowser) matches by reference, fixing the 3 test failures in MonitoringDashboardGraph.spec.tsx

Context

The automated cherry-pick PR #16040 (from #16016) changed the component import but not the test import, causing a reference mismatch where Enzyme could not find the QueryBrowser component in the shallow-rendered tree.

Test plan

CI ci/prow/frontend tests pass (the 3 previously failing MonitoringDashboardGraph tests)
Navigate to Observe → Metrics page — no React error Add Alert Manager proxy #306

🤖 Generated with Claude Code

…lar dependency Import QueryBrowser from @console/dynamic-plugin-sdk/src/lib-core instead of @console/shared/src/components/query-browser to break circular imports that cause React error openshift#306 on the Metrics page. Also update the test to import from the same path so Enzyme's find() matches by reference. Co-Authored-By: Claude <noreply@anthropic.com>

openshift-ci-robot · 2026-03-30T18:24:34Z

@Leo6Leo: This pull request references Jira Issue OCPBUGS-77037, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected dependent Jira Issue OCPBUGS-74557 to target a version in 4.21.0, 4.21.z, but it targets "4.22.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Custom fix for release-4.20 replacing the failed cherry-pick in [release-4.20] OCPBUGS-77037: Fixed Metrics page React error #306 by exporting QueryBrowser component #16040

Imports QueryBrowser from @console/dynamic-plugin-sdk/src/lib-core instead of @console/shared/src/components/query-browser to break the circular import that causes React error Add Alert Manager proxy #306 on the Metrics page

Updates the test file to import from the same SDK path so Enzyme's find(QueryBrowser) matches by reference, fixing the 3 test failures in MonitoringDashboardGraph.spec.tsx

Context

The automated cherry-pick PR #16040 (from #16016) changed the component import but not the test import, causing a reference mismatch where Enzyme could not find the QueryBrowser component in the shallow-rendered tree.

Test plan

CI ci/prow/frontend tests pass (the 3 previously failing MonitoringDashboardGraph tests)

Navigate to Observe → Metrics page — no React error Add Alert Manager proxy #306

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-03-30T18:25:18Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0192b4ea-1eb0-4a42-a481-2121003a4ad8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci · 2026-03-30T18:25:59Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Leo6Leo
Once this PR has been reviewed and has the lgtm label, please assign divyanshigupta for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

frontend/packages/dev-console/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Leo6Leo · 2026-03-30T18:32:19Z

/jira refresh

openshift-ci-robot · 2026-03-30T18:32:25Z

@Leo6Leo: This pull request references Jira Issue OCPBUGS-77037, which is invalid:

expected dependent Jira Issue OCPBUGS-74557 to target a version in 4.21.0, 4.21.z, but it targets "4.21" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Leo6Leo · 2026-03-30T18:33:10Z

/jira refresh

openshift-ci-robot · 2026-03-30T18:33:16Z

@Leo6Leo: This pull request references Jira Issue OCPBUGS-77037, which is invalid:

expected dependent Jira Issue OCPBUGS-74557 to target a version in 4.21.0, 4.21.z, but it targets "4.22.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Leo6Leo · 2026-03-30T18:34:14Z

/jira refresh

openshift-ci-robot · 2026-03-30T18:34:24Z

@Leo6Leo: This pull request references Jira Issue OCPBUGS-77037, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.20.z) matches configured target version for branch (4.20.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-74557 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-74557 targets the "4.21.z" version, which is one of the valid target versions: 4.21.0, 4.21.z
bug has dependents

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Leo6Leo · 2026-03-30T21:01:36Z

/retest-required

Leo6Leo · 2026-03-31T13:56:35Z

/retest-required

openshift-ci · 2026-03-31T19:18:05Z

@Leo6Leo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci bot requested review from rhamilto and sg00dwin March 30, 2026 18:25

openshift-ci bot added the component/dev-console Related to dev-console label Mar 30, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 30, 2026

openshift-ci bot requested a review from yapei March 30, 2026 18:34

Conversation

Leo6Leo commented Mar 30, 2026

Summary

Context

Test plan

Uh oh!

openshift-ci-robot commented Mar 30, 2026

Summary

Context

Test plan

Uh oh!

coderabbitai bot commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

openshift-ci bot commented Mar 30, 2026

Uh oh!

Leo6Leo commented Mar 30, 2026

Uh oh!

openshift-ci-robot commented Mar 30, 2026

Uh oh!

Leo6Leo commented Mar 30, 2026

Uh oh!

openshift-ci-robot commented Mar 30, 2026

Uh oh!

Leo6Leo commented Mar 30, 2026

Uh oh!

openshift-ci-robot commented Mar 30, 2026

Uh oh!

Leo6Leo commented Mar 30, 2026

Uh oh!

Leo6Leo commented Mar 31, 2026

Uh oh!

openshift-ci bot commented Mar 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai bot commented Mar 30, 2026 •

edited

Loading