[WIP] OCPBUGS-42343: Remove master selector for olm installs on hcp?#16332
[WIP] OCPBUGS-42343: Remove master selector for olm installs on hcp?#16332jkyros wants to merge 1 commit intoopenshift:mainfrom
Conversation
So right now if we're installing an OLM operator via the console, and that operator's default nodeSelector happens to target masters, the install will fail on a hosted control plane because there are no masters available for scheduling, nor will there be. This adjusts the OLM install for the console to check whether we're in a hosted environment where we have no masters, and if so, remove that part of the selector so the pods can float to the workers and run, which is a better user experience than the install just breaking. Signed-off-by: John Kyros <jkyros@redhat.com>
|
Skipping CI for Draft Pull Request. |
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
jira/valid-reference
|
@jkyros: This pull request references Jira Issue OCPBUGS-42343, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jkyros The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
2 participants
Please ignore this for now.
OLM installs on HCP selecting masters currently fail, I'm just testing to see if we can remove the master selector from the subscription and have it work.
Analysis / Root cause:
Solution description:
Screenshots / screen recording:
Test setup:
Test cases:
Browser conformance:
Additional info:
Reviewers and assignees: