[release-4.19] OCPBUGS-84271: Fix VolumeSnapshot and VolumeSnapshotContent table sorting

[stefanonardo]

Summary

Cherry-pick of #16261.

• Fixed Status, Size, and Source column sorting in VolumeSnapshot table
• Fixed Status and Size column sorting in VolumeSnapshotContent table
• Corrected TypeScript types to distinguish string vs number restoreSize values
• Refactored volumeSnapshotStatus to shared location and renamed to snapshotStatus

Problem

The Status, Size, and Source columns in the VolumeSnapshot table and Status and Size columns in VolumeSnapshotContent table were not sorting correctly. The columns referenced non-existent sort field names (like 'volumeSnapshotSize') instead of using function wrappers with the sorts registry.

Additionally, TypeScript types incorrectly defined restoreSize as a number for both VolumeSnapshot and VolumeSnapshotContent, when in reality VolumeSnapshot uses Kubernetes quantity strings (e.g., "1Gi") and VolumeSnapshotContent uses integer bytes.

Changes

Sorting fix:

• Updated sort columns to use inline wrapper functions: (data, direction) => data.sort(sortResourceByValue(direction, sorts.functionName))
• Added volumeSnapshotStatus, volumeSnapshotSize, volumeSnapshotContentSize, and volumeSnapshotSource to the sorts registry in table.tsx
• Fixed TypeScript types to correctly represent VolumeSnapshot.status.restoreSize as string and VolumeSnapshotContent.status.restoreSize as number
• Added snapshotContentSize() utility function to handle VolumeSnapshotContent size sorting
• Removed dead code from useConsoleDataViewData.tsx (redundant string sort check that was never reached)

Refactoring:

• Moved volumeSnapshotStatus from @console/app/src/status to @console/shared/src/sorts/snapshot
• Renamed to snapshotStatus for consistency with other snapshot utilities (snapshotSize, snapshotSource, snapshotContentSize)
• Updated all imports across 9 files to use the new shared location
• Maintained backwards compatibility by re-exporting from old location

Test plan

• Navigate to Storage → VolumeSnapshots in the OpenShift console
• Create test snapshots with different sizes and statuses
• Click Status column header and verify snapshots sort alphabetically by status
• Click Size column header and verify snapshots sort numerically by size (ascending/descending)
• Click Source column header and verify snapshots sort alphabetically by source PVC name
• Navigate to VolumeSnapshotContents tab and verify Status and Size sorting works

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d3a2028a-0176-4a6d-9984-9af062c9278c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[stefanonardo]

/jira refresh

[openshift-ci-robot]

@stefanonardo: This pull request references Jira Issue OCPBUGS-84271, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.z) matches configured target version for branch (4.19.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-82012 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-82012 targets the "4.20.z" version, which is one of the valid target versions: 4.20.0, 4.20.z
• bug has dependents

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Cherry-pick of #16261.

• Fixed Status, Size, and Source column sorting in VolumeSnapshot table
• Fixed Status and Size column sorting in VolumeSnapshotContent table
• Corrected TypeScript types to distinguish string vs number restoreSize values
• Refactored volumeSnapshotStatus to shared location and renamed to snapshotStatus

Problem

The Status, Size, and Source columns in the VolumeSnapshot table and Status and Size columns in VolumeSnapshotContent table were not sorting correctly. The columns referenced non-existent sort field names (like 'volumeSnapshotSize') instead of using function wrappers with the sorts registry.

Additionally, TypeScript types incorrectly defined restoreSize as a number for both VolumeSnapshot and VolumeSnapshotContent, when in reality VolumeSnapshot uses Kubernetes quantity strings (e.g., "1Gi") and VolumeSnapshotContent uses integer bytes.

Changes

Sorting fix:

• Updated sort columns to use inline wrapper functions: (data, direction) => data.sort(sortResourceByValue(direction, sorts.functionName))
• Added volumeSnapshotStatus, volumeSnapshotSize, volumeSnapshotContentSize, and volumeSnapshotSource to the sorts registry in table.tsx
• Fixed TypeScript types to correctly represent VolumeSnapshot.status.restoreSize as string and VolumeSnapshotContent.status.restoreSize as number
• Added snapshotContentSize() utility function to handle VolumeSnapshotContent size sorting
• Removed dead code from useConsoleDataViewData.tsx (redundant string sort check that was never reached)

Refactoring:

• Moved volumeSnapshotStatus from @console/app/src/status to @console/shared/src/sorts/snapshot
• Renamed to snapshotStatus for consistency with other snapshot utilities (snapshotSize, snapshotSource, snapshotContentSize)
• Updated all imports across 9 files to use the new shared location
• Maintained backwards compatibility by re-exporting from old location

Test plan

• Navigate to Storage → VolumeSnapshots in the OpenShift console
• Create test snapshots with different sizes and statuses
• Click Status column header and verify snapshots sort alphabetically by status
• Click Size column header and verify snapshots sort numerically by size (ascending/descending)
• Click Source column header and verify snapshots sort alphabetically by source PVC name
• Navigate to VolumeSnapshotContents tab and verify Status and Size sorting works

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@stefanonardo: This pull request references Jira Issue OCPBUGS-84271, which is valid.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.z) matches configured target version for branch (4.19.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-82012 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-82012 targets the "4.20.z" version, which is one of the valid target versions: 4.20.0, 4.20.z
• bug has dependents

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[stefanonardo]

/retest

[openshift-ci]

@stefanonardo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[cajieh]

/verified by @cajieh
/lgtm
/label backport-risk-assessed

[openshift-ci-robot]

@cajieh: This PR has been marked as verified by @cajieh.

Details

In response to this:

/verified by @cajieh
/lgtm
/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cajieh, stefanonardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [cajieh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@stefanonardo: Jira Issue Verification Checks: Jira Issue OCPBUGS-84271
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-84271 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Summary

Cherry-pick of #16261.

• Fixed Status, Size, and Source column sorting in VolumeSnapshot table
• Fixed Status and Size column sorting in VolumeSnapshotContent table
• Corrected TypeScript types to distinguish string vs number restoreSize values
• Refactored volumeSnapshotStatus to shared location and renamed to snapshotStatus

Problem

The Status, Size, and Source columns in the VolumeSnapshot table and Status and Size columns in VolumeSnapshotContent table were not sorting correctly. The columns referenced non-existent sort field names (like 'volumeSnapshotSize') instead of using function wrappers with the sorts registry.

Additionally, TypeScript types incorrectly defined restoreSize as a number for both VolumeSnapshot and VolumeSnapshotContent, when in reality VolumeSnapshot uses Kubernetes quantity strings (e.g., "1Gi") and VolumeSnapshotContent uses integer bytes.

Changes

Sorting fix:

• Updated sort columns to use inline wrapper functions: (data, direction) => data.sort(sortResourceByValue(direction, sorts.functionName))
• Added volumeSnapshotStatus, volumeSnapshotSize, volumeSnapshotContentSize, and volumeSnapshotSource to the sorts registry in table.tsx
• Fixed TypeScript types to correctly represent VolumeSnapshot.status.restoreSize as string and VolumeSnapshotContent.status.restoreSize as number
• Added snapshotContentSize() utility function to handle VolumeSnapshotContent size sorting
• Removed dead code from useConsoleDataViewData.tsx (redundant string sort check that was never reached)

Refactoring:

• Moved volumeSnapshotStatus from @console/app/src/status to @console/shared/src/sorts/snapshot
• Renamed to snapshotStatus for consistency with other snapshot utilities (snapshotSize, snapshotSource, snapshotContentSize)
• Updated all imports across 9 files to use the new shared location
• Maintained backwards compatibility by re-exporting from old location

Test plan

• Navigate to Storage → VolumeSnapshots in the OpenShift console
• Create test snapshots with different sizes and statuses
• Click Status column header and verify snapshots sort alphabetically by status
• Click Size column header and verify snapshots sort numerically by size (ascending/descending)
• Click Source column header and verify snapshots sort alphabetically by source PVC name
• Navigate to VolumeSnapshotContents tab and verify Status and Size sorting works

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.