OCPBUGS-84320: Use popover token in QS modal

[logonoff]

Analysis / Root cause:

Wrong token was used in quick search modal

Solution description:

Use the right token

Screenshots / screen recording:

Test setup:

Test cases:

Browser conformance:

• Chrome
• Firefox
• Safari (or Epiphany on Linux)

Additional info:

Reviewers and assignees:

Summary by CodeRabbit

• Style
  • Updated Quick Search modal background styling for improved visual consistency.

[openshift-ci-robot]

@logonoff: This pull request references Jira Issue OCPBUGS-84320, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Analysis / Root cause:

Wrong token was used in quick search modal

Solution description:

Use the right token

Screenshots / screen recording:

Test setup:

Test cases:

Browser conformance:

• Chrome
• Firefox
• Safari (or Epiphany on Linux)

Additional info:

Reviewers and assignees:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[logonoff]

/verified by @logonoff

[openshift-ci-robot]

@logonoff: This PR has been marked as verified by @logonoff.

Details

In response to this:

/verified by @logonoff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@logonoff: This pull request references Jira Issue OCPBUGS-84320, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

Analysis / Root cause:

Wrong token was used in quick search modal

Solution description:

Use the right token

Screenshots / screen recording:

Test setup:

Test cases:

Browser conformance:

• Chrome
• Firefox
• Safari (or Epiphany on Linux)

Additional info:

Reviewers and assignees:

Summary by CodeRabbit

• Style
• Updated Quick Search modal background styling for improved visual consistency.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: dee08fc8-668d-4691-9acf-78e4099aa7ea

📥 Commits

Reviewing files that changed from the base of the PR and between 2489c9a and fc21c7e.

📒 Files selected for processing (1)

• frontend/packages/console-shared/src/components/quick-search/QuickSearchModal.scss

📜 Recent review details

🔇 Additional comments (1)

frontend/packages/console-shared/src/components/quick-search/QuickSearchModal.scss (1)

2-2: Correct token for floating/popover surface.

This token switch is aligned with existing floating UI usage and cleanly fixes the QS modal background mismatch while preserving current specificity behavior (!important).

---

📝 Walkthrough

Walkthrough

The Quick Search modal styling is updated by changing the CSS variable used for the background color from the primary default theme token to the floating default theme token in the SCSS file. The !important override and CSS selector remain unchanged. This represents a single-line modification with no alterations to exported entities or public APIs.

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The description addresses root cause and solution but lacks critical details: no visual before/after screenshots provided for styling changes, no detailed test cases, and browser testing only partially completed (only Firefox marked).	Add before/after screenshots showing the modal styling change, specify which token was wrong and why the popover token is correct, and complete browser conformance testing for Chrome and Safari.

✅ Passed checks (11 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly references the Jira issue (OCPBUGS-84320) and accurately describes the main change: updating the Quick Search modal to use the popover token instead of an incorrect token.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	No Go test files or Ginkgo test suites present in this CSS-only change; check is inapplicable.
Test Structure And Quality	✅ Passed	PR modifies only CSS file (QuickSearchModal.scss) for theme token change. Check targets Ginkgo test code quality; no test code present, so check not applicable.
Microshift Test Compatibility	✅ Passed	This PR modifies only a single SCSS file to update CSS theme variables; it contains no Ginkgo e2e test additions, making the custom check not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR modifies only frontend SCSS styling in the Quick Search modal; no new Ginkgo e2e tests are present, making the SNO test compatibility check inapplicable.
Topology-Aware Scheduling Compatibility	✅ Passed	This pull request modifies only a SCSS stylesheet file containing a single CSS rule for the Quick Search modal's background color, updating a PatternFly theme token variable. The topology-aware scheduling compatibility check applies specifically to deployment manifests, operator code, or controllers that introduce scheduling constraints. This change is purely cosmetic UI styling in the OpenShift Console frontend with no impact on Kubernetes scheduling, topology requirements, affinity rules, replica counts, or infrastructure configuration—therefore the check is not applicable and presents no topology-compatibility concerns.
Ote Binary Stdout Contract	✅ Passed	The OTE Binary Stdout Contract check is not applicable to this PR as it contains only a CSS/SCSS styling file modification with no Go process-level code.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The custom check for IPv6 and disconnected network test compatibility is not applicable to this PR. This PR modifies only QuickSearchModal.scss, a CSS styling file for the OpenShift Console frontend component. It contains no Ginkgo e2e tests, no Go code, and no networking or connectivity logic whatsoever.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[vikram-raj]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [logonoff,vikram-raj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 0a66c88 and 2 for PR HEAD fc21c7e in total

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 924065f and 1 for PR HEAD fc21c7e in total

[openshift-ci]

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@logonoff: Jira Issue Verification Checks: Jira Issue OCPBUGS-84320
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-84320 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Analysis / Root cause:

Wrong token was used in quick search modal

Solution description:

Use the right token

Screenshots / screen recording:

Test setup:

Test cases:

Browser conformance:

• Chrome
• Firefox
• Safari (or Epiphany on Linux)

Additional info:

Reviewers and assignees:

Summary by CodeRabbit

• Style
• Updated Quick Search modal background styling for improved visual consistency.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.