Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/packages/console-app/console-extensions.json
Original file line number Diff line number Diff line change
Expand Up @@ -1153,7 +1153,7 @@
"perspective": "admin",
"section": "workloads",
"id": "statefulsets",
"insertAfter": "deploymentconfigs",
"insertAfter": ["deploymentconfigs", "deployments"],
"name": "%console-app~StatefulSets%",
"model": {
"group": "apps",
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
import type { NavExtension } from '@console/dynamic-plugin-sdk';
import type { LoadedExtension } from '@console/dynamic-plugin-sdk/src/types';
import { getSortedNavExtensions } from '../utils';

const createNavItem = (
id: string,
insertAfter?: string | string[],
insertBefore?: string | string[],
): LoadedExtension<NavExtension> =>
({
properties: {
id,
...(insertAfter !== undefined && { insertAfter }),
...(insertBefore !== undefined && { insertBefore }),
},
} as LoadedExtension<NavExtension>);

const getIds = (items: LoadedExtension<NavExtension>[]): string[] =>
items.map((i) => i.properties.id);

describe('getSortedNavExtensions', () => {
it('should maintain order when all insertAfter targets exist', () => {
const items = [
createNavItem('topology'),
createNavItem('pods', 'topology'),
createNavItem('deployments', 'pods'),
createNavItem('deploymentconfigs', 'deployments'),
createNavItem('statefulsets', ['deploymentconfigs', 'deployments']),
createNavItem('secrets', 'statefulsets'),
];

expect(getIds(getSortedNavExtensions(items))).toEqual([
'topology',
'pods',
'deployments',
'deploymentconfigs',
'statefulsets',
'secrets',
]);
});

it('should use fallback insertAfter target when primary target is missing', () => {
const items = [
createNavItem('topology'),
createNavItem('pods', 'topology'),
createNavItem('deployments', 'pods'),
// deploymentconfigs is absent (capability disabled)
createNavItem('statefulsets', ['deploymentconfigs', 'deployments']),
createNavItem('secrets', 'statefulsets'),
];

expect(getIds(getSortedNavExtensions(items))).toEqual([
'topology',
'pods',
'deployments',
'statefulsets',
'secrets',
]);
});

it('should push item to end when insertAfter target does not exist and no fallback', () => {
const items = [
createNavItem('topology'),
createNavItem('pods', 'topology'),
createNavItem('deployments', 'pods'),
// deploymentconfigs is absent, statefulsets has no fallback
createNavItem('statefulsets', 'deploymentconfigs'),
createNavItem('secrets', 'statefulsets'),
];

const sorted = getIds(getSortedNavExtensions(items));
expect(sorted[0]).toBe('topology');
expect(sorted[1]).toBe('pods');
expect(sorted[2]).toBe('deployments');
// statefulsets and secrets end up after deployments but order may vary
expect(sorted).toContain('statefulsets');
expect(sorted).toContain('secrets');
});
});