Skip to content

[release-4.23] OCPBUGS-84557: re-enable helm-release.feature#16359

Open
openshift-cherrypick-robot wants to merge 1 commit intoopenshift:release-4.23from
openshift-cherrypick-robot:cherry-pick-16274-to-release-4.23
Open

[release-4.23] OCPBUGS-84557: re-enable helm-release.feature#16359
openshift-cherrypick-robot wants to merge 1 commit intoopenshift:release-4.23from
openshift-cherrypick-robot:cherry-pick-16274-to-release-4.23

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot openshift-cherrypick-robot commented Apr 28, 2026

This is an automated cherry-pick of #16274

/assign rhamilto

@rhamilto @claude
OCPBUGS-82511: re-enable helm-release.feature
3210eba 
Changes to fix flaky Helm release Cypress tests and re-enable the test suite:

Navigation and test structure improvements:
- Add navigation constants (navPaths) to DRY up cy.clickNavLink calls
- Replace navigateTo() with cy.clickNavLink() for Helm and Topology navigation
- Remove duplicate cy.clickNavLink() command definition in dev-console
- Move cy.clickNavLink() to shared integration-tests package
- Add app.waitForLoad() calls to ensure pages fully load before interactions
- Update helm-release.feature precondition to use admin perspective setup

Timing and race condition fixes:
- Wait for chart version dropdowns to be enabled before clicking
- Wait for button loading states to complete before proceeding
- Wait for catalog cards to be filtered and displayed after type selection
- Increase numTestsKeptInMemory from 5 to 50 to prevent memory cleanup mid-test
- Add verifyPageTitle() check after selecting catalog type
- Change detailsPage titleShouldContain to use 'exist' instead of 'be.visible'

Topology sidebar improvements:
- Fix topology sidebar flake by searching for helm group before clicking
- Update verifyActions to check exact action list length and order
- Fix malformed CSS selector in topology-po.ts (missing closing quote)

Test cleanup:
- Remove duplicate step definitions for "user will be redirected to Topology page"
- Remove duplicate step definition for "user is on the topology sidebar"
- Simplify hooks.ts to use cy.login() without explicit credentials
- Remove beforeEach hook that was causing state pollution
- Reorder test scenarios to match dependency flow

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 28, 2026
Merged
@openshift-ci openshift-ci Bot added component/dev-console Related to dev-console component/helm Related to helm-plugin component/topology Related to topology kind/cypress Related to Cypress e2e integration testing labels Apr 28, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 28, 2026

@openshift-cherrypick-robot: Jira Issue OCPBUGS-82511 has been cloned as Jira Issue OCPBUGS-84557. Will retitle bug to link to clone.
/retitle [release-4.23] OCPBUGS-84557: re-enable helm-release.feature

Details

In response to this:

This is an automated cherry-pick of #16274

/assign rhamilto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title [release-4.23] OCPBUGS-82511: re-enable helm-release.feature [release-4.23] OCPBUGS-84557: re-enable helm-release.feature Apr 28, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 28, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 28, 2026

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-84557, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #16274

/assign rhamilto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 28, 2026

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rhamilto
Copy link
Copy Markdown
Member

rhamilto commented Apr 28, 2026

/jira refresh
/approve
/lgtm
/label backport-risk-assessed
/verified by CI

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 28, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 28, 2026

@rhamilto: This pull request references Jira Issue OCPBUGS-84557, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.23.0) matches configured target version for branch (4.23.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-82511 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-82511 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
  • bug has dependents
Details

In response to this:

/jira refresh
/approve
/lgtm
/label backport-risk-assessed
/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 28, 2026
@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 28, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 28, 2026

@rhamilto: This PR has been marked as verified by CI.

Details

In response to this:

/jira refresh
/approve
/lgtm
/label backport-risk-assessed
/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 28, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sanketpathak sanketpathak Awaiting requested review from sanketpathak

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@rhamilto rhamilto

@sanketpathak sanketpathak

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. component/dev-console Related to dev-console component/helm Related to helm-plugin component/topology Related to topology jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/cypress Related to Cypress e2e integration testing lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@openshift-cherrypick-robot @openshift-ci-robot @rhamilto @sanketpathak