Skip to content

OCPBUGS-84710: Fix ConsoleDataView filter order: Name and Label should appear first#16375

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
rhamilto:OCPBUGS-84710
Apr 30, 2026
Merged

OCPBUGS-84710: Fix ConsoleDataView filter order: Name and Label should appear first#16375
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
rhamilto:OCPBUGS-84710

Conversation

@rhamilto
Copy link
Copy Markdown
Member

@rhamilto rhamilto commented Apr 29, 2026

Fixes the ConsoleDataView filter toolbar ordering so that Name and Label filters appear first, before additional filters like Status, Roles, and Architecture.

What this PR does / why we need it

The ConsoleDataView component was displaying filter controls in an inconsistent order. When additionalFilterNodes were provided, they appeared before the standard Name and Label filters. This created a poor user experience as the most commonly used filters should always be first.

Which Jira issue(s) this PR fixes

Fixes: https://issues.redhat.com/browse/OCPBUGS-84710

Before

Filter toolbar displays: Status | Roles | Architecture | Machine set | MachineConfigPool | Name | Label

After

Filter toolbar displays: Name | Label | Status | Roles | Architecture | Machine set | MachineConfigPool

Screenshot 2026-04-29 at 2 31 32 PM

How to test this PR

  1. Navigate to the Nodes list page (Compute > Nodes)
  2. Observe the filter toolbar above the data table
  3. Verify Name and Label filters appear first from left to right

Screenshots/recordings

See Jira: https://drive.google.com/file/d/1JDWL68H6iqL8qpxijNLIQyHqI1O7gwLA/view?usp=sharing

Summary by CodeRabbit

  • Style
    • Adjusted the ordering of base filter elements in the data view for improved usability.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Apr 29, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-84710, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Fixes the ConsoleDataView filter toolbar ordering so that Name and Label filters appear first, before additional filters like Status, Roles, and Architecture.

What this PR does / why we need it

The ConsoleDataView component was displaying filter controls in an inconsistent order. When additionalFilterNodes were provided, they appeared before the standard Name and Label filters. This created a poor user experience as the most commonly used filters should always be first.

Which Jira issue(s) this PR fixes

Fixes: https://issues.redhat.com/browse/OCPBUGS-84710

Before

Filter toolbar displays: Status | Roles | Architecture | Machine set | MachineConfigPool | Name | Label

After

Filter toolbar displays: Name | Label | Status | Roles | Architecture | Machine set | MachineConfigPool

How to test this PR

  1. Navigate to the Nodes list page (Compute > Nodes)
  2. Observe the filter toolbar above the data table
  3. Verify Name and Label filters appear first from left to right

Screenshots/recordings

See Jira: https://drive.google.com/file/d/1JDWL68H6iqL8qpxijNLIQyHqI1O7gwLA/view?usp=sharing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from Leo6Leo and TheRealJon April 29, 2026 18:30
@openshift-ci openshift-ci Bot added component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 29, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-84710, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

Fixes the ConsoleDataView filter toolbar ordering so that Name and Label filters appear first, before additional filters like Status, Roles, and Architecture.

What this PR does / why we need it

The ConsoleDataView component was displaying filter controls in an inconsistent order. When additionalFilterNodes were provided, they appeared before the standard Name and Label filters. This created a poor user experience as the most commonly used filters should always be first.

Which Jira issue(s) this PR fixes

Fixes: https://issues.redhat.com/browse/OCPBUGS-84710

Before

Filter toolbar displays: Status | Roles | Architecture | Machine set | MachineConfigPool | Name | Label

After

Filter toolbar displays: Name | Label | Status | Roles | Architecture | Machine set | MachineConfigPool

Screenshot 2026-04-29 at 2 31 32 PM

How to test this PR

  1. Navigate to the Nodes list page (Compute > Nodes)
  2. Observe the filter toolbar above the data table
  3. Verify Name and Label filters appear first from left to right

Screenshots/recordings

See Jira: https://drive.google.com/file/d/1JDWL68H6iqL8qpxijNLIQyHqI1O7gwLA/view?usp=sharing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 29, 2026

📝 Walkthrough

Walkthrough

The filter node composition in a data view component was reordered so that base "Name/Label" filters render before additional filter nodes, rather than after them. No functional or control flow changes.

Changes

Cohort / File(s) Summary
Filter Node Composition
frontend/packages/console-app/src/components/data-view/ConsoleDataView.tsx
Reordered filter node rendering to display base "Name/Label" filters before additionalFilterNodes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: fixing the filter order so Name and Label appear first in ConsoleDataView.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies React component for filter reordering; no Ginkgo test files are modified with dynamic test names.
Test Structure And Quality ✅ Passed The custom check for Ginkgo test code quality is not applicable to this PR, which only modifies a TypeScript/React component without adding or modifying any Go test files.
Microshift Test Compatibility ✅ Passed PR modifies only a frontend React/TypeScript component file and does not add any Ginkgo e2e tests.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR modifies only ConsoleDataView.tsx, a TypeScript/React component, with no new Ginkgo e2e tests added, so the SNO test compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Frontend React component reordering filter elements with no impact on Kubernetes topology-aware scheduling.
Ote Binary Stdout Contract ✅ Passed This PR modifies a frontend React/TypeScript component (ConsoleDataView.tsx) that handles UI filter ordering. It does not involve any Go test binaries, test infrastructure, or stdout operations covered by the OTE Binary Stdout Contract check.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR modifies only React/TypeScript UI components with no Ginkgo e2e tests added, making the check inapplicable.
Description check ✅ Passed The PR description is well-structured and covers all essential sections including analysis, solution, before/after comparison, test instructions, and a Jira reference with proper formatting.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2026
Copy link
Copy Markdown
Member

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@logonoff
Copy link
Copy Markdown
Member

/verified by screenshot

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 29, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@logonoff: This PR has been marked as verified by screenshot.

Details

In response to this:

/verified by screenshot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 335d6bd and 2 for PR HEAD 91e2b4f in total

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD d21ae19 and 1 for PR HEAD 91e2b4f in total

@openshift-ci-robot openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Apr 30, 2026
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2026
@rhamilto
Copy link
Copy Markdown
Member Author

@logonoff, I had to push integration test fixes. PTAL.

@openshift-ci openshift-ci Bot added the kind/cypress Related to Cypress e2e integration testing label Apr 30, 2026
Copy link
Copy Markdown
Member

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@logonoff
Copy link
Copy Markdown
Member

/verified by screenshot,ci

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 30, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@logonoff: This PR has been marked as verified by screenshot,ci.

Details

In response to this:

/verified by screenshot,ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 30, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, rhamilto, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 30, 2026

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit f712a14 into openshift:main Apr 30, 2026
8 checks passed
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@rhamilto: Jira Issue Verification Checks: Jira Issue OCPBUGS-84710
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-84710 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Fixes the ConsoleDataView filter toolbar ordering so that Name and Label filters appear first, before additional filters like Status, Roles, and Architecture.

What this PR does / why we need it

The ConsoleDataView component was displaying filter controls in an inconsistent order. When additionalFilterNodes were provided, they appeared before the standard Name and Label filters. This created a poor user experience as the most commonly used filters should always be first.

Which Jira issue(s) this PR fixes

Fixes: https://issues.redhat.com/browse/OCPBUGS-84710

Before

Filter toolbar displays: Status | Roles | Architecture | Machine set | MachineConfigPool | Name | Label

After

Filter toolbar displays: Name | Label | Status | Roles | Architecture | Machine set | MachineConfigPool

Screenshot 2026-04-29 at 2 31 32 PM

How to test this PR

  1. Navigate to the Nodes list page (Compute > Nodes)
  2. Observe the filter toolbar above the data table
  3. Verify Name and Label filters appear first from left to right

Screenshots/recordings

See Jira: https://drive.google.com/file/d/1JDWL68H6iqL8qpxijNLIQyHqI1O7gwLA/view?usp=sharing

Summary by CodeRabbit

  • Style
  • Adjusted the ordering of base filter elements in the data view for improved usability.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto
Copy link
Copy Markdown
Member Author

/cherry-pick release-4.22 release-4.21

@openshift-cherrypick-robot
Copy link
Copy Markdown

@rhamilto: new pull request created: #16383

Details

In response to this:

/cherry-pick release-4.22 release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

Fix included in release 5.0.0-0.nightly-2026-05-01-010944

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/cypress Related to Cypress e2e integration testing lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants