OCPBUGS-84710: Fix ConsoleDataView filter order: Name and Label should appear first#16375
Conversation
|
@rhamilto: This pull request references Jira Issue OCPBUGS-84710, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@rhamilto: This pull request references Jira Issue OCPBUGS-84710, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
📝 WalkthroughWalkthroughThe filter node composition in a data view component was reordered so that base "Name/Label" filters render before additional filter nodes, rather than after them. No functional or control flow changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/verified by screenshot |
|
@logonoff: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@logonoff, I had to push integration test fixes. PTAL. |
|
/verified by screenshot,ci |
|
@logonoff: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logonoff, rhamilto, TheRealJon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@rhamilto: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@rhamilto: Jira Issue Verification Checks: Jira Issue OCPBUGS-84710 Jira Issue OCPBUGS-84710 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.22 release-4.21 |
|
@rhamilto: new pull request created: #16383 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Fix included in release 5.0.0-0.nightly-2026-05-01-010944 |

Fixes the ConsoleDataView filter toolbar ordering so that Name and Label filters appear first, before additional filters like Status, Roles, and Architecture.
What this PR does / why we need it
The ConsoleDataView component was displaying filter controls in an inconsistent order. When additionalFilterNodes were provided, they appeared before the standard Name and Label filters. This created a poor user experience as the most commonly used filters should always be first.
Which Jira issue(s) this PR fixes
Fixes: https://issues.redhat.com/browse/OCPBUGS-84710
Before
Filter toolbar displays: Status | Roles | Architecture | Machine set | MachineConfigPool | Name | Label
After
Filter toolbar displays: Name | Label | Status | Roles | Architecture | Machine set | MachineConfigPool
How to test this PR
Screenshots/recordings
See Jira: https://drive.google.com/file/d/1JDWL68H6iqL8qpxijNLIQyHqI1O7gwLA/view?usp=sharing
Summary by CodeRabbit