OCPBUGS-85043: Remove @console imports from SDK dist

[logonoff]

Analysis / Root cause:

@console monorepo imports do not work in the dist package and so should not be included

Solution description:

• Define and export UserKind in extensions/console-types, remove the duplicate definition from public k8s types, and update affected files to import UserKind/UserInfo from the extensions path.
• Replace PaneBody with PatternFly PageSection in ListPageBody.
• Change k8s resource fetch import to use consoleFetchJSON (aliased as coFetchJSON) from lib-core.
• Add a test (sdk-dist-imports.spec.ts) that scans the SDK dist output to ensure no ES import/export statements reference monorepo packages, preventing accidental bundling of internal module specifiers.

Test cases:

• Run CI

Summary by CodeRabbit

• Tests

  • Added validation test for SDK distribution imports to detect forbidden module specifiers.

• Refactor

  • Updated ListPageBody component to use PatternFly's PageSection instead of PaneBody.
  • Reorganized type imports across SDK modules.

• Updates

  • Extended UserInfo type with optional metadata field.

[openshift-ci-robot]

@logonoff: This pull request references Jira Issue OCPBUGS-85043, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Analysis / Root cause:

@console monorepo imports do not work in the dist package and so should not be included

Solution description:

• Define and export UserKind in extensions/console-types, remove the duplicate definition from public k8s types, and update affected files to import UserKind/UserInfo from the extensions path.
• Replace PaneBody with PatternFly PageSection in ListPageBody.
• Change k8s resource fetch import to use consoleFetchJSON (aliased as coFetchJSON) from lib-core.
• Add a test (sdk-dist-imports.spec.ts) that scans the SDK dist output to ensure no ES import/export statements reference monorepo packages, preventing accidental bundling of internal module specifiers.

Test cases:

• Run CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[logonoff]

/verified by test

[openshift-ci-robot]

@logonoff: This PR has been marked as verified by test.

Details

In response to this:

/verified by test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [logonoff]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@logonoff: This pull request references Jira Issue OCPBUGS-85043, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

Analysis / Root cause:

@console monorepo imports do not work in the dist package and so should not be included

Solution description:

• Define and export UserKind in extensions/console-types, remove the duplicate definition from public k8s types, and update affected files to import UserKind/UserInfo from the extensions path.
• Replace PaneBody with PatternFly PageSection in ListPageBody.
• Change k8s resource fetch import to use consoleFetchJSON (aliased as coFetchJSON) from lib-core.
• Add a test (sdk-dist-imports.spec.ts) that scans the SDK dist output to ensure no ES import/export statements reference monorepo packages, preventing accidental bundling of internal module specifiers.

Test cases:

• Run CI

Summary by CodeRabbit

• Tests

• Added validation test for SDK distribution imports to detect forbidden module specifiers.

• Refactor

• Updated ListPageBody component to use PatternFly's PageSection instead of PaneBody.

• Reorganized type imports across SDK modules.

• Updates

• Extended UserInfo type with optional metadata field.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request consolidates type definitions and enforces distribution integrity across the OpenShift Console SDK. The UserKind type is migrated from internal @console/internal/module/k8s/types to the public SDK extensions module, with corresponding import path updates throughout the codebase. The UserInfo type in the main types module gains an optional extra field. A new Jest test (sdk-dist-imports.spec.ts) scans the built SDK distribution directory to prevent forbidden @console/* module specifiers in compiled output. Additionally, ListPageBody is refactored to use PatternFly's PageSection component with hasBodyWrapper={false}, and import sources for coFetchJSON are centralized.

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Test Structure And Quality	⚠️ Warning	Assertions lack meaningful messages. Lines 35 and 58 violate criterion 4 by missing diagnostic context. Jest supports optional message parameter.	Add messages to assertions: expect(distFiles.length).toBeGreaterThan(0, 'dist directory should be populated') and expect(...).toEqual([], 'SDK dist must not contain @console imports')

✅ Passed checks (11 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically identifies the main objective: removing @console monorepo imports from the SDK distribution to fix the OCPBUGS-85043 issue.
Description check	✅ Passed	The PR description covers analysis, solution details, and test cases, though it omits several template sections (setup, browser conformance, screenshots, reviewers).
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Custom check not applicable: PR contains only frontend TypeScript/Jest code with no Ginkgo tests. Check targets Go-based BDD testing; this PR is frontend-focused with properly-named Jest tests.
Microshift Test Compatibility	✅ Passed	The custom check applies only to new Ginkgo e2e tests. This PR adds only Jest tests and frontend SDK changes—no Ginkgo Go e2e tests. Check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No Ginkgo e2e tests present. PR contains only frontend TypeScript/TSX files (React components, types, Jest unit test). SNO check not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR contains only frontend code (TypeScript/TSX): SDK test, UI refactoring, imports, types. No deployment manifests, operator code, controllers, or scheduling constraints. Check not applicable.
Ote Binary Stdout Contract	✅ Passed	OTE Stdout Contract check not applicable. PR modifies only TypeScript/JavaScript frontend code (8 files), no Go code, no process-level initialization or stdout writes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Custom check targets Ginkgo (Go) e2e tests. PR adds only a Jest (TypeScript) unit test for SDK dist validation. No IPv4 assumptions or external connectivity. Check not applicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@frontend/__tests__/sdk-dist-imports.spec.ts`:
- Around line 25-58: The test currently splits files into lines and uses
importFromConsoleRe which requires a "from" clause, so it misses side-effect
imports and multiline imports; update the test to run regex matching against the
entire file content (not line-by-line) and change importFromConsoleRe to also
match side-effect imports by making the from-clause optional (capture the
`@console` specifier whether it's in a from '...' form or a bare import '...');
when collecting violations use the full-content regex matches (extract the
specifier from the appropriate capture group) and keep pushing { file:
relative(DIST_DIR, filePath), line: (derive line number from
content.indexOf(match) or compute line by counting newlines up to match.index),
specifier } so multiline and side-effect imports are detected (update references
to importFromConsoleRe, the loop that uses lines[], and the violations push
logic).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: f2ced5a9-cd3e-4c15-b556-0c7626ce43e9

📥 Commits

Reviewing files that changed from the base of the PR and between 2e316b9 and 8371c06.

📒 Files selected for processing (8)

• frontend/__tests__/sdk-dist-imports.spec.ts
• frontend/packages/console-dynamic-plugin-sdk/src/app/components/factory/ListPage/ListPageBody.tsx
• frontend/packages/console-dynamic-plugin-sdk/src/app/core/actions/core.ts
• frontend/packages/console-dynamic-plugin-sdk/src/app/core/reducers/coreSelectors.ts
• frontend/packages/console-dynamic-plugin-sdk/src/app/redux-types.ts
• frontend/packages/console-dynamic-plugin-sdk/src/extensions/console-types.ts
• frontend/packages/console-dynamic-plugin-sdk/src/utils/k8s/k8s-resource.ts
• frontend/public/module/k8s/types.ts

💤 Files with no reviewable changes (1)

• frontend/public/module/k8s/types.ts

📜 Review details

🧰 Additional context used

🪛 OpenGrep (1.20.0)

frontend/__tests__/sdk-dist-imports.spec.ts

[ERROR] 45-45: Dynamic command passed to child_process.exec/execSync. Use child_process.execFile or spawn with an argument array instead.

(coderabbit.command-injection.exec-js)

---

[ERROR] 47-47: Dynamic command passed to child_process.exec/execSync. Use child_process.execFile or spawn with an argument array instead.

(coderabbit.command-injection.exec-js)

🔇 Additional comments (7)

frontend/packages/console-dynamic-plugin-sdk/src/app/components/factory/ListPage/ListPageBody.tsx (2)

2-2: Good dependency boundary change for SDK dist.

Switching to PageSection from @patternfly/react-core removes reliance on internal console component imports and aligns with the dist-packaging objective.

---

8-12: ListPageBody refactor preserves behavior cleanly.

Using PageSection with className="co-m-pane__body" and hasBodyWrapper={false} keeps the wrapper semantics/layout intent while avoiding extra nested body markup.

frontend/packages/console-dynamic-plugin-sdk/src/extensions/console-types.ts (1)

1187-1191: Good consolidation of UserKind into SDK console types.

This keeps the user resource type in the public SDK surface and supports the dist-import cleanup goal.

frontend/packages/console-dynamic-plugin-sdk/src/app/redux-types.ts (1)

4-4: Import path update looks correct.

Using the SDK-local type source here is consistent with the monorepo import removal effort.

frontend/packages/console-dynamic-plugin-sdk/src/app/core/actions/core.ts (1)

3-3: Type import consolidation is solid.

Line 3 correctly points action payload typing at the SDK extensions export surface.

frontend/packages/console-dynamic-plugin-sdk/src/app/core/reducers/coreSelectors.ts (1)

2-2: Selector type import switch is correct.

This keeps selector contracts stable while decoupling from monorepo-internal type paths.

frontend/packages/console-dynamic-plugin-sdk/src/utils/k8s/k8s-resource.ts (1)

5-5: coFetchJSON source change is aligned and safe.

Line 5 removes the monorepo-shared import path while preserving existing call patterns in this module.

[vojtechszocs]

Should we re-export UserKind from console-types.ts ?

[logonoff]

IIRC it already is

https://github.com/logonoff/openshift-console/blob/852e13f76e585cf59e0b13d24381606dea016917/frontend/public/module/k8s/types.ts#L19

[openshift-ci]

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.