NO-JIRA: Update plugin SDK core package CHANGELOG#16496
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@vojtechszocs: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
component/sdk
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughUpdated Console 4.23 documentation: added ChangesChangelog & Release Notes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/packages/console-dynamic-plugin-sdk/CHANGELOG-core.md`:
- Line 13: The CHANGLEOG header currently duplicates "4.23.0-prerelease.1 - TBD"
which conflicts with the released entry; update the unreleased header string to
the next prerelease version (e.g. change "4.23.0-prerelease.1 - TBD" to
"4.23.0-prerelease.2 - TBD") so version mapping is unique; ensure you only
modify that header line (the exact version token "4.23.0-prerelease.1") in the
file.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: b878c75d-e277-454e-b981-dfb9263fedc5
📒 Files selected for processing (1)
frontend/packages/console-dynamic-plugin-sdk/CHANGELOG-core.md
vojtechszocs
force-pushed
the
update-shared-module-versions
branch
from
54eeb50 to
ea1364b
Compare
| For older 1.x plugin SDK packages, refer to "OpenShift Console Versions vs SDK Versions" compatibility | ||
| table in [Console dynamic plugins README](./README.md). | ||
|
|
||
| ## 4.23.0-prerelease.1 - 2026-05-27 |
There was a problem hiding this comment.
| ## 4.23.0-prerelease.1 - 2026-05-27 | |
| ## 4.23.0-prerelease.2 - 2026-05-27 |
|
@coderabbitai /microcopy-review changes in this PR |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/packages/console-dynamic-plugin-sdk/release-notes/4.23.md`:
- Around line 3-4: Change the phrase "runtime breaking changes" to the
hyphenated form "runtime-breaking changes" in the release note text (the
sentence starting "This release contains no runtime breaking changes...") so the
compound adjective before the noun is correctly hyphenated.
- Around line 6-7: Update the release note text in
frontend/packages/console-dynamic-plugin-sdk/release-notes/4.23.md by changing
the phrase "Console provided shared modules" to the hyphenated form
"Console-provided shared modules" so the compound adjective preceding the noun
is correct; locate the sentence that starts "Console dynamic plugin SDK package
`@openshift-console/dynamic-plugin-sdk` releases may contain changes in
`peerDependencies` to reflect current versions of Console provided shared
modules." and replace "Console provided" with "Console-provided".
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: f578cb1f-c0e6-4c5e-8ac9-a1cb03c5023e
📒 Files selected for processing (2)
frontend/packages/console-dynamic-plugin-sdk/CHANGELOG-core.mdfrontend/packages/console-dynamic-plugin-sdk/release-notes/4.23.md
✅ Files skipped from review due to trivial changes (1)
- frontend/packages/console-dynamic-plugin-sdk/CHANGELOG-core.md
| Console dynamic plugin SDK package `@openshift-console/dynamic-plugin-sdk` releases may contain changes | ||
| in `peerDependencies` to reflect current versions of Console provided shared modules. |
There was a problem hiding this comment.
Hyphenate compound adjective "Console-provided".
The phrase "Console provided shared modules" should use a hyphen: "Console-provided shared modules". Compound adjectives that precede nouns should be hyphenated for clarity and correctness.
📝 Proposed fix
-Console dynamic plugin SDK package `@openshift-console/dynamic-plugin-sdk` releases may contain changes
-in `peerDependencies` to reflect current versions of Console provided shared modules.
+Console dynamic plugin SDK package `@openshift-console/dynamic-plugin-sdk` releases may contain changes
+in `peerDependencies` to reflect current versions of Console-provided shared modules.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| Console dynamic plugin SDK package `@openshift-console/dynamic-plugin-sdk` releases may contain changes | |
| in `peerDependencies` to reflect current versions of Console provided shared modules. | |
| Console dynamic plugin SDK package `@openshift-console/dynamic-plugin-sdk` releases may contain changes | |
| in `peerDependencies` to reflect current versions of Console-provided shared modules. |
🧰 Tools
🪛 LanguageTool
[grammar] ~7-~7: Use a hyphen to join words.
Context: ...` to reflect current versions of Console provided shared modules. ## Changes to ...
(QB_NEW_EN_HYPHEN)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@frontend/packages/console-dynamic-plugin-sdk/release-notes/4.23.md` around
lines 6 - 7, Update the release note text in
frontend/packages/console-dynamic-plugin-sdk/release-notes/4.23.md by changing
the phrase "Console provided shared modules" to the hyphenated form
"Console-provided shared modules" so the compound adjective preceding the noun
is correct; locate the sentence that starts "Console dynamic plugin SDK package
`@openshift-console/dynamic-plugin-sdk` releases may contain changes in
`peerDependencies` to reflect current versions of Console provided shared
modules." and replace "Console provided" with "Console-provided".
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Fetch the PR diff
gh pr diff 16496 --repo openshift/console
echo "---FILE CONTENT---"
cat frontend/packages/console-dynamic-plugin-sdk/CHANGELOG-core.md | head -80Length of output: 8827
|
| File | Severity | Issue |
|---|---|---|
CHANGELOG-core.md |
🔴 Major | Duplicate version 4.23.0-prerelease.1 — newer entry should be 4.23.0-prerelease.2 |
release-notes/4.23.md |
🟡 Minor | "Console provided" → "Console-provided" (missing hyphen in compound adjective) |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Get the diff for the PR
gh pr diff 16496 --repo openshift/console
# Also get the full file for context
cat frontend/packages/console-dynamic-plugin-sdk/CHANGELOG-core.md | head -80Length of output: 8825
|
vojtechszocs
force-pushed
the
update-shared-module-versions
branch
2 times, most recently
from
b0dede7 to
fe7159a
Compare
|
/label px-approved |
openshift-ci
Bot
added
the
px-approved
openshift-ci-robot
added
the
verified
|
@logonoff: The DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@vojtechszocs: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
vojtechszocs
force-pushed
the
update-shared-module-versions
branch
from
fe7159a to
09f93e3
Compare
openshift-ci-robot
removed
the
verified
|
/lgtm |
|
/verified bypass |
openshift-ci-robot
added
the
verified
|
@logonoff: The DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
♻️ Duplicate comments (1)
frontend/packages/console-dynamic-plugin-sdk/release-notes/4.23.md (1)
3-3:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winHyphenate “runtime-breaking” in the compatibility sentence.
Please change “runtime breaking changes” to “runtime-breaking changes” at Line 3.
Proposed fix
-This release contains no runtime breaking changes. Existing plugins built for Console 4.22 remain fully +This release contains no runtime-breaking changes. Existing plugins built for Console 4.22 remain fully🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@frontend/packages/console-dynamic-plugin-sdk/release-notes/4.23.md` at line 3, Update the sentence in release-notes/4.23.md to hyphenate “runtime-breaking” by replacing “runtime breaking changes” with “runtime-breaking changes” in the compatibility line (the sentence that currently reads: "This release contains no runtime breaking changes. Existing plugins built for Console 4.22 remain fully").
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@frontend/packages/console-dynamic-plugin-sdk/release-notes/4.23.md`:
- Line 3: Update the sentence in release-notes/4.23.md to hyphenate
“runtime-breaking” by replacing “runtime breaking changes” with
“runtime-breaking changes” in the compatibility line (the sentence that
currently reads: "This release contains no runtime breaking changes. Existing
plugins built for Console 4.22 remain fully").
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 536675f2-81a8-4f2e-82e5-287310123867
📒 Files selected for processing (2)
frontend/packages/console-dynamic-plugin-sdk/CHANGELOG-core.mdfrontend/packages/console-dynamic-plugin-sdk/release-notes/4.23.md
✅ Files skipped from review due to trivial changes (1)
- frontend/packages/console-dynamic-plugin-sdk/CHANGELOG-core.md
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logonoff, vojtechszocs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@vojtechszocs: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/label plugin-api-approved |
openshift-ci
Bot
added
the
plugin-api-approved
|
@coderabbitai run the |
|
Custom finishing touch recipe not found: |
1 similar comment
|
Custom finishing touch recipe not found: |
|
@coderabbitai execute the |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Fetch the PR diff to see current state
gh pr diff 16496 --repo openshift/console
echo "---CHANGELOG HEAD---"
cat frontend/packages/console-dynamic-plugin-sdk/CHANGELOG-core.md | head -80
echo "---RELEASE NOTES---"
cat frontend/packages/console-dynamic-plugin-sdk/release-notes/4.23.mdLength of output: 374 🏁 Script executed: #!/bin/bash
# Fetch the PR diff via GitHub CLI without needing repo clone
gh pr diff 16496 --repo openshift/console
echo "---FILE: CHANGELOG-core.md---"
gh api repos/openshift/console/contents/frontend/packages/console-dynamic-plugin-sdk/CHANGELOG-core.md \
--jq '.content' | base64 -d | head -80
echo "---FILE: release-notes/4.23.md---"
gh api repos/openshift/console/contents/frontend/packages/console-dynamic-plugin-sdk/release-notes/4.23.md \
--jq '.content' | base64 -dLength of output: 9645
|
openshift-ci
Bot
added
the
docs-approved
3 participants
Analysis / Root cause
Ensure that Console plugin SDK CHANGELOG is up to date.
Test cases
No testing needed, these changes have no impact on Console build or its functionality.
Reviewers and assignees
/assign @logonoff
Summary by CodeRabbit