CONSOLE-5308: Centralize ResizeObserver polyfill in Jest setup for unit tests#16506
CONSOLE-5308: Centralize ResizeObserver polyfill in Jest setup for unit tests#16506cajieh wants to merge 1 commit into
Conversation
|
@cajieh: This pull request references CONSOLE-5308 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (8)
💤 Files with no reviewable changes (6)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughThis PR centralizes the ResizeObserver mock by adding a global mock file and registering it in Jest setupFiles, and removes duplicate test-local ResizeObserver stubs from several frontend test files. ChangesConsolidate ResizeObserver mocking
🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
9f956b8 to
aeacc1d
Compare
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cajieh, logonoff The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@logonoff: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@logonoff Thank you. |
|
/test e2e-gcp-console |
|
@cajieh: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
CONSOLE-5308: Centralize ResizeObserver polyfill in Jest setup for unit tests
Analysis / Root cause:
Unit test clean up
Solution description:
Centralize ResizeObserver polyfill in Jest setup for unit tests and removed from affected specs
Screenshots / screen recording:
N/A
Test setup:
Test cases:
N/A
Browser conformance:
N/A
Additional info:
N/A
Reviewers and assignees:
Summary by CodeRabbit