Skip to content

OCPBUGS-82508, OCPBUGS-82509: Fix and re-enable operator e2e tests disabled for createRoot#16517

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
TheRealJon:OCPBUGS-82508
May 29, 2026
Merged

OCPBUGS-82508, OCPBUGS-82509: Fix and re-enable operator e2e tests disabled for createRoot#16517
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
TheRealJon:OCPBUGS-82508

Conversation

@TheRealJon
Copy link
Copy Markdown
Member

@TheRealJon TheRealJon commented May 28, 2026

Analysis / Root cause:

The operator-install-single-namespace.cy.ts e2e test was disabled during the React 18 createRoot migration (CONSOLE-4512) due to concurrent rendering timing issues:

  1. Radio button timeout: Under React 18 concurrent rendering, the namespace scope radio button group (A specific namespace on the cluster-radio-input) mounts asynchronously and was not found within the default 40-second Cypress timeout
  2. Install CTA navigation failure: The Install button's href attribute is set asynchronously via the useCtaLink hook, and clicking before the href is ready causes navigation to fail
  3. Cypress chain break: .should('have.attr', 'href') yields the attribute string value instead of the DOM element, causing .click() to fail with "requires a DOM element" error

Solution description:

Three fixes applied to re-enable the test:

  1. Add explicit 30s timeout to radio selectors (operator.view.ts:48, 63):

    • cy.byTestID('A specific namespace on the cluster-radio-input', { timeout: 30000 })
    • cy.byTestID('All namespaces on the cluster-radio-input', { timeout: 30000 })
    • Gives Cypress time to wait for async mount completion
  2. Split Install CTA interaction into separate commands (operator.view.ts:28-30):

    cy.byTestID('catalog-details-modal-cta').should('be.visible');
    cy.byTestID('catalog-details-modal-cta').should('have.attr', 'href').and('not.be.empty');
    cy.byTestID('catalog-details-modal-cta').click();
    • First verify element visible
    • Assert href exists and not empty (yields href, discarded)
    • Re-query fresh element and click (avoids chain break)
  3. Re-enable test (operator-install-single-namespace.cy.ts:43):

    • Changed xdescribedescribe
    • Removed disable comment

Matches pattern from other createRoot e2e fixes: OCPBUGS-82512 (knative), OCPBUGS-82504 (cluster-settings).

Screenshots / screen recording:
N/A - e2e test fix, no UI changes

Test setup:
Requires OpenShift cluster with OperatorHub configured and Data Grid operator available in catalog.

Test cases:

  1. Run yarn test-cypress-olm-headless with spec filter for operator-install-single-namespace.cy.ts
  2. Verify test passes:
    • Navigates to OperatorHub catalog
    • Searches for Data Grid operator
    • Clicks operator card and Install CTA
    • Selects "A specific namespace" radio button
    • Completes installation to test namespace
    • Creates Backup operand instance
    • Deletes operand and uninstalls operator
  3. Verify no CSP violations or console errors

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

Additional info:

Reviewers and assigners:

Summary by CodeRabbit

  • Tests
    • Re-enabled previously disabled operator installation and uninstallation test suites
    • Improved test determinism by adding visibility assertions and wait conditions for interactive elements

…t rendering

React 18 concurrent rendering causes multiple timing issues in operator
install test:

1. Radio button group mounts async, causing selectors to timeout
2. Install CTA link href loads async via useCtaLink hook
3. Cypress chain breaks when .should('have.attr') yields string value

Fixed by:
- Add explicit 30s timeout to namespace scope radio button selectors
  ('A specific namespace on the cluster-radio-input', 'All namespaces...')
- Split Install CTA click into separate commands to avoid chain break:
  verify visible, verify href non-empty, then click fresh element
- Re-enable test (xdescribe → describe)

Matches pattern from other createRoot e2e fixes (OCPBUGS-82512 knative,
OCPBUGS-82504 cluster-settings) which add timeouts to async-mounted elements.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 28, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 28, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 28, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 28, 2026

@TheRealJon: This pull request references Jira Issue OCPBUGS-82508, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Analysis / Root cause:

The operator-install-single-namespace.cy.ts e2e test was disabled during the React 18 createRoot migration (CONSOLE-4512) due to concurrent rendering timing issues:

  1. Radio button timeout: Under React 18 concurrent rendering, the namespace scope radio button group (A specific namespace on the cluster-radio-input) mounts asynchronously and was not found within the default 40-second Cypress timeout
  2. Install CTA navigation failure: The Install button's href attribute is set asynchronously via the useCtaLink hook, and clicking before the href is ready causes navigation to fail
  3. Cypress chain break: .should('have.attr', 'href') yields the attribute string value instead of the DOM element, causing .click() to fail with "requires a DOM element" error

Solution description:

Three fixes applied to re-enable the test:

  1. Add explicit 30s timeout to radio selectors (operator.view.ts:48, 63):
  • cy.byTestID('A specific namespace on the cluster-radio-input', { timeout: 30000 })
  • cy.byTestID('All namespaces on the cluster-radio-input', { timeout: 30000 })
  • Gives Cypress time to wait for async mount completion
  1. Split Install CTA interaction into separate commands (operator.view.ts:28-30):
cy.byTestID('catalog-details-modal-cta').should('be.visible');
cy.byTestID('catalog-details-modal-cta').should('have.attr', 'href').and('not.be.empty');
cy.byTestID('catalog-details-modal-cta').click();
  • First verify element visible
  • Assert href exists and not empty (yields href, discarded)
  • Re-query fresh element and click (avoids chain break)
  1. Re-enable test (operator-install-single-namespace.cy.ts:43):
  • Changed xdescribedescribe
  • Removed disable comment

Matches pattern from other createRoot e2e fixes: OCPBUGS-82512 (knative), OCPBUGS-82504 (cluster-settings).

Screenshots / screen recording:
N/A - e2e test fix, no UI changes

Test setup:
Requires OpenShift cluster with OperatorHub configured and Data Grid operator available in catalog.

Test cases:

  1. Run yarn test-cypress-olm-headless with spec filter for operator-install-single-namespace.cy.ts
  2. Verify test passes:
  • Navigates to OperatorHub catalog
  • Searches for Data Grid operator
  • Clicks operator card and Install CTA
  • Selects "A specific namespace" radio button
  • Completes installation to test namespace
  • Creates Backup operand instance
  • Deletes operand and uninstalls operator
  1. Verify no CSP violations or console errors

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

Additional info:

Reviewers and assigners:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@TheRealJon: This pull request references Jira Issue OCPBUGS-82508, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

Analysis / Root cause:

The operator-install-single-namespace.cy.ts e2e test was disabled during the React 18 createRoot migration (CONSOLE-4512) due to concurrent rendering timing issues:

  1. Radio button timeout: Under React 18 concurrent rendering, the namespace scope radio button group (A specific namespace on the cluster-radio-input) mounts asynchronously and was not found within the default 40-second Cypress timeout
  2. Install CTA navigation failure: The Install button's href attribute is set asynchronously via the useCtaLink hook, and clicking before the href is ready causes navigation to fail
  3. Cypress chain break: .should('have.attr', 'href') yields the attribute string value instead of the DOM element, causing .click() to fail with "requires a DOM element" error

Solution description:

Three fixes applied to re-enable the test:

  1. Add explicit 30s timeout to radio selectors (operator.view.ts:48, 63):
  • cy.byTestID('A specific namespace on the cluster-radio-input', { timeout: 30000 })
  • cy.byTestID('All namespaces on the cluster-radio-input', { timeout: 30000 })
  • Gives Cypress time to wait for async mount completion
  1. Split Install CTA interaction into separate commands (operator.view.ts:28-30):
cy.byTestID('catalog-details-modal-cta').should('be.visible');
cy.byTestID('catalog-details-modal-cta').should('have.attr', 'href').and('not.be.empty');
cy.byTestID('catalog-details-modal-cta').click();
  • First verify element visible
  • Assert href exists and not empty (yields href, discarded)
  • Re-query fresh element and click (avoids chain break)
  1. Re-enable test (operator-install-single-namespace.cy.ts:43):
  • Changed xdescribedescribe
  • Removed disable comment

Matches pattern from other createRoot e2e fixes: OCPBUGS-82512 (knative), OCPBUGS-82504 (cluster-settings).

Screenshots / screen recording:
N/A - e2e test fix, no UI changes

Test setup:
Requires OpenShift cluster with OperatorHub configured and Data Grid operator available in catalog.

Test cases:

  1. Run yarn test-cypress-olm-headless with spec filter for operator-install-single-namespace.cy.ts
  2. Verify test passes:
  • Navigates to OperatorHub catalog
  • Searches for Data Grid operator
  • Clicks operator card and Install CTA
  • Selects "A specific namespace" radio button
  • Completes installation to test namespace
  • Creates Backup operand instance
  • Deletes operand and uninstalls operator
  1. Verify no CSP violations or console errors

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

Additional info:

Reviewers and assigners:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

Walkthrough

Re-enable previously skipped OLM install/uninstall Cypress suites and make the operator.install view more deterministic by asserting CTA visibility/href and adding 30s timeouts plus separated checks for namespace radio inputs.

Changes

Operator Lifecycle Manager integration tests

Layer / File(s) Summary
Test suite re-activation
frontend/packages/operator-lifecycle-manager/integration-tests/tests/operator-install-single-namespace.cy.ts, frontend/packages/operator-lifecycle-manager/integration-tests/tests/operator-uninstall.cy.ts
Top-level test wrappers changed from xdescribe to describe, enabling the install and uninstall test suites to run.
Deterministic operator install flow
frontend/packages/operator-lifecycle-manager/integration-tests/views/operator.view.ts
operator.install now asserts the catalog Install CTA is visible and has a non-empty href before clicking; adds 30s timeouts and separates visibility/checked assertions for the single-namespace and all-namespaces radio inputs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

kind/cypress, verified

Suggested reviewers

  • sanketpathak
  • sg00dwin
  • logonoff
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description check ✅ Passed The description covers all required sections including analysis/root cause, solution, test setup, test cases, and browser conformance, providing comprehensive detail about the fixes applied.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed All test names use static strings (Data Grid, Backup, etc.). testOperator.name and testOperand.name are constants, not dynamic values. No UUIDs, timestamps, or generated identifiers in test titles.
Test Structure And Quality ✅ Passed Custom check for Ginkgo test quality is not applicable—PR contains Cypress integration tests (TypeScript), not Ginkgo tests (Go).
Microshift Test Compatibility ✅ Passed The PR modifies Cypress frontend integration tests, not Ginkgo e2e tests. The check applies only to new Ginkgo tests using APIs unavailable on MicroShift; these Cypress tests are not within its scope.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR modifies Cypress integration tests (TypeScript/JavaScript UI automation), not Ginkgo e2e tests (Go infrastructure tests). SNO compatibility check applies only to Ginkgo e2e tests.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only Cypress integration test files, not deployment manifests, operator code, or controllers. No scheduling constraints introduced; check is not applicable.
Ote Binary Stdout Contract ✅ Passed PR modifies Cypress tests (.cy.ts), not OTE binaries. Check applies to Go test binaries with Ginkgo; not TypeScript Cypress tests.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR modifies Cypress frontend UI tests, not Ginkgo e2e tests. The custom check applies only to Ginkgo e2e tests added to Kubernetes/OpenShift test suites, not to frontend integration tests.
No-Weak-Crypto ✅ Passed Pull request contains only Cypress E2E test code for operator UI; no cryptographic operations, weak crypto patterns, or insecure comparisons present.
Container-Privileges ✅ Passed PR contains only Cypress integration test files (.cy.ts and .view.ts TypeScript), no Kubernetes manifests or container configuration files to audit for privileged container settings.
No-Sensitive-Data-In-Logs ✅ Passed All logging in modified test files contains only non-sensitive data: test actions, public product names, standard namespaces, and example resources. No credentials, tokens, PII, or secrets are logged.
Title check ✅ Passed The title clearly references the bug IDs (OCPBUGS-82508, OCPBUGS-82509) and accurately summarizes the main change: fixing and re-enabling operator e2e tests that were disabled due to createRoot concurrent rendering issues.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@TheRealJon TheRealJon marked this pull request as ready for review May 28, 2026 21:04
@openshift-ci openshift-ci Bot added component/olm Related to OLM approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 28, 2026
@openshift-ci openshift-ci Bot requested review from fsgreco and jhadvig May 28, 2026 21:05
Test was disabled during createRoot migration due to namespace scope radio
button timeout in before hook. Fix already applied to shared operator.view.ts
helper in OCPBUGS-82508 (30s timeout on radio selectors).

Re-enable test by changing xdescribe → describe and removing disable comment.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@TheRealJon TheRealJon changed the title OCPBUGS-82508: Fix operator install e2e test for createRoot concurrent rendering OCPBUGS-82508, OCPBUGS-82509: Fix and re-enable operator e2e tests disabled for createRoot May 28, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@TheRealJon: This pull request references Jira Issue OCPBUGS-82508, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-82509, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Analysis / Root cause:

The operator-install-single-namespace.cy.ts e2e test was disabled during the React 18 createRoot migration (CONSOLE-4512) due to concurrent rendering timing issues:

  1. Radio button timeout: Under React 18 concurrent rendering, the namespace scope radio button group (A specific namespace on the cluster-radio-input) mounts asynchronously and was not found within the default 40-second Cypress timeout
  2. Install CTA navigation failure: The Install button's href attribute is set asynchronously via the useCtaLink hook, and clicking before the href is ready causes navigation to fail
  3. Cypress chain break: .should('have.attr', 'href') yields the attribute string value instead of the DOM element, causing .click() to fail with "requires a DOM element" error

Solution description:

Three fixes applied to re-enable the test:

  1. Add explicit 30s timeout to radio selectors (operator.view.ts:48, 63):
  • cy.byTestID('A specific namespace on the cluster-radio-input', { timeout: 30000 })
  • cy.byTestID('All namespaces on the cluster-radio-input', { timeout: 30000 })
  • Gives Cypress time to wait for async mount completion
  1. Split Install CTA interaction into separate commands (operator.view.ts:28-30):
cy.byTestID('catalog-details-modal-cta').should('be.visible');
cy.byTestID('catalog-details-modal-cta').should('have.attr', 'href').and('not.be.empty');
cy.byTestID('catalog-details-modal-cta').click();
  • First verify element visible
  • Assert href exists and not empty (yields href, discarded)
  • Re-query fresh element and click (avoids chain break)
  1. Re-enable test (operator-install-single-namespace.cy.ts:43):
  • Changed xdescribedescribe
  • Removed disable comment

Matches pattern from other createRoot e2e fixes: OCPBUGS-82512 (knative), OCPBUGS-82504 (cluster-settings).

Screenshots / screen recording:
N/A - e2e test fix, no UI changes

Test setup:
Requires OpenShift cluster with OperatorHub configured and Data Grid operator available in catalog.

Test cases:

  1. Run yarn test-cypress-olm-headless with spec filter for operator-install-single-namespace.cy.ts
  2. Verify test passes:
  • Navigates to OperatorHub catalog
  • Searches for Data Grid operator
  • Clicks operator card and Install CTA
  • Selects "A specific namespace" radio button
  • Completes installation to test namespace
  • Creates Backup operand instance
  • Deletes operand and uninstalls operator
  1. Verify no CSP violations or console errors

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

Additional info:

Reviewers and assigners:

Summary by CodeRabbit

  • Tests
  • Re-enabled Data Grid operator installation test suite
  • Improved test reliability with enhanced visibility checks and wait conditions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

Actionable comments posted: 0

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@TheRealJon: This pull request references Jira Issue OCPBUGS-82508, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

This pull request references Jira Issue OCPBUGS-82509, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

Analysis / Root cause:

The operator-install-single-namespace.cy.ts e2e test was disabled during the React 18 createRoot migration (CONSOLE-4512) due to concurrent rendering timing issues:

  1. Radio button timeout: Under React 18 concurrent rendering, the namespace scope radio button group (A specific namespace on the cluster-radio-input) mounts asynchronously and was not found within the default 40-second Cypress timeout
  2. Install CTA navigation failure: The Install button's href attribute is set asynchronously via the useCtaLink hook, and clicking before the href is ready causes navigation to fail
  3. Cypress chain break: .should('have.attr', 'href') yields the attribute string value instead of the DOM element, causing .click() to fail with "requires a DOM element" error

Solution description:

Three fixes applied to re-enable the test:

  1. Add explicit 30s timeout to radio selectors (operator.view.ts:48, 63):
  • cy.byTestID('A specific namespace on the cluster-radio-input', { timeout: 30000 })
  • cy.byTestID('All namespaces on the cluster-radio-input', { timeout: 30000 })
  • Gives Cypress time to wait for async mount completion
  1. Split Install CTA interaction into separate commands (operator.view.ts:28-30):
cy.byTestID('catalog-details-modal-cta').should('be.visible');
cy.byTestID('catalog-details-modal-cta').should('have.attr', 'href').and('not.be.empty');
cy.byTestID('catalog-details-modal-cta').click();
  • First verify element visible
  • Assert href exists and not empty (yields href, discarded)
  • Re-query fresh element and click (avoids chain break)
  1. Re-enable test (operator-install-single-namespace.cy.ts:43):
  • Changed xdescribedescribe
  • Removed disable comment

Matches pattern from other createRoot e2e fixes: OCPBUGS-82512 (knative), OCPBUGS-82504 (cluster-settings).

Screenshots / screen recording:
N/A - e2e test fix, no UI changes

Test setup:
Requires OpenShift cluster with OperatorHub configured and Data Grid operator available in catalog.

Test cases:

  1. Run yarn test-cypress-olm-headless with spec filter for operator-install-single-namespace.cy.ts
  2. Verify test passes:
  • Navigates to OperatorHub catalog
  • Searches for Data Grid operator
  • Clicks operator card and Install CTA
  • Selects "A specific namespace" radio button
  • Completes installation to test namespace
  • Creates Backup operand instance
  • Deletes operand and uninstalls operator
  1. Verify no CSP violations or console errors

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

Additional info:

Reviewers and assigners:

Summary by CodeRabbit

  • Tests
  • Re-enabled previously disabled operator installation and uninstallation test suites
  • Improved test determinism by adding visibility assertions and wait conditions for interactive elements

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

Actionable comments posted: 0

Copy link
Copy Markdown
Member

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 29, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@logonoff
Copy link
Copy Markdown
Member

/verified by ci
/cherry-pick release-4.22

@openshift-cherrypick-robot
Copy link
Copy Markdown

@logonoff: once the present PR merges, I will cherry-pick it on top of release-4.22 in a new PR and assign it to you.

Details

In response to this:

/verified by ci
/cherry-pick release-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label May 29, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@logonoff: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci
/cherry-pick release-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 29, 2026

@TheRealJon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 666c9e3 into openshift:main May 29, 2026
9 checks passed
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@TheRealJon: Jira Issue Verification Checks: Jira Issue OCPBUGS-82508
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-82508 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Jira Issue Verification Checks: Jira Issue OCPBUGS-82509
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-82509 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Analysis / Root cause:

The operator-install-single-namespace.cy.ts e2e test was disabled during the React 18 createRoot migration (CONSOLE-4512) due to concurrent rendering timing issues:

  1. Radio button timeout: Under React 18 concurrent rendering, the namespace scope radio button group (A specific namespace on the cluster-radio-input) mounts asynchronously and was not found within the default 40-second Cypress timeout
  2. Install CTA navigation failure: The Install button's href attribute is set asynchronously via the useCtaLink hook, and clicking before the href is ready causes navigation to fail
  3. Cypress chain break: .should('have.attr', 'href') yields the attribute string value instead of the DOM element, causing .click() to fail with "requires a DOM element" error

Solution description:

Three fixes applied to re-enable the test:

  1. Add explicit 30s timeout to radio selectors (operator.view.ts:48, 63):
  • cy.byTestID('A specific namespace on the cluster-radio-input', { timeout: 30000 })
  • cy.byTestID('All namespaces on the cluster-radio-input', { timeout: 30000 })
  • Gives Cypress time to wait for async mount completion
  1. Split Install CTA interaction into separate commands (operator.view.ts:28-30):
cy.byTestID('catalog-details-modal-cta').should('be.visible');
cy.byTestID('catalog-details-modal-cta').should('have.attr', 'href').and('not.be.empty');
cy.byTestID('catalog-details-modal-cta').click();
  • First verify element visible
  • Assert href exists and not empty (yields href, discarded)
  • Re-query fresh element and click (avoids chain break)
  1. Re-enable test (operator-install-single-namespace.cy.ts:43):
  • Changed xdescribedescribe
  • Removed disable comment

Matches pattern from other createRoot e2e fixes: OCPBUGS-82512 (knative), OCPBUGS-82504 (cluster-settings).

Screenshots / screen recording:
N/A - e2e test fix, no UI changes

Test setup:
Requires OpenShift cluster with OperatorHub configured and Data Grid operator available in catalog.

Test cases:

  1. Run yarn test-cypress-olm-headless with spec filter for operator-install-single-namespace.cy.ts
  2. Verify test passes:
  • Navigates to OperatorHub catalog
  • Searches for Data Grid operator
  • Clicks operator card and Install CTA
  • Selects "A specific namespace" radio button
  • Completes installation to test namespace
  • Creates Backup operand instance
  • Deletes operand and uninstalls operator
  1. Verify no CSP violations or console errors

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

Additional info:

Reviewers and assigners:

Summary by CodeRabbit

  • Tests
  • Re-enabled previously disabled operator installation and uninstallation test suites
  • Improved test determinism by adding visibility assertions and wait conditions for interactive elements

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@logonoff: new pull request created: #16518

Details

In response to this:

/verified by ci
/cherry-pick release-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/olm Related to OLM jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants