CONSOLE-5242: Remove shipwright-plugin Cypress integration tests#16553
Merged
Conversation
openshift-ci-robot
added
the
jira/valid-reference
Contributor
|
@rhamilto: This pull request references CONSOLE-5242 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
approved
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (39)
💤 Files with no reviewable changes (37)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughThis PR removes the Shipwright plugin from the Cypress integration test suite by deleting test files and updating configuration. Test scripts, npm package configuration, Playwright project generation, and migration documentation are updated to remove references to Shipwright testing. ChangesShipwright test removal
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Member
Author
|
/retest |
2 similar comments
Member
Author
|
/retest |
Member
Author
|
/retest |
The Cypress integration tests were disabled in CI and never migrated to Playwright. Remove the test files and all references from scripts and config. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
|
tech debt |
openshift-ci
Bot
added
px-approved
Member
Author
|
/verified by CI |
openshift-ci-robot
added
the
verified
Contributor
|
@rhamilto: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fsgreco, rhamilto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
@rhamilto: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analysis / Root cause:
The shipwright-plugin Cypress integration tests were disabled in CI (commented out in
test-cypress.sh) and never executed. The Playwright config referenced ashipwrightproject, but no Playwright test files were ever created. This is dead test infrastructure.CONSOLE-5242
Solution description:
Remove all shipwright integration test artifacts:
frontend/packages/shipwright-plugin/integration-tests/(34 files — Cypress config, feature files, step definitions, page objects, test data YAMLs)test-cypress-shipwright*yarn scripts fromfrontend/package.json--project=shipwrightand--project=shipwright-developerfrom Playwright yarn scripts'shipwright'frompackagesanddevPackagesarrays infrontend/playwright.config.tsfrontend/integration-tests/test-cypress.shThe shipwright plugin source code and unit tests are untouched.
Screenshots / screen recording:
N/A — no visual changes.
Test setup:
None required.
Test cases:
yarn installcompletes without errorsyarn lintpassesyarn testpasses (shipwright unit tests still run)yarn buildsucceedsBrowser conformance:
N/A — no UI changes.
Additional info:
Removes ~2,500 lines of dead code.
Summary by CodeRabbit
Chores
Documentation