Skip to content

Bug 1739407: Enhance host status to beter derive errors from operational status #2315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Aug 13, 2019
Merged

Bug 1739407: Enhance host status to beter derive errors from operational status #2315

openshift-merge-robot merged 1 commit into from
Aug 13, 2019

Conversation

@jtomasek
Copy link

@jtomasek jtomasek commented Aug 9, 2019

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 9, 2019

@jtomasek: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1739407: Enhance host status to beter derive errors from operational status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. component/metal3 Related to metal3-plugin labels Aug 9, 2019
@honza
Copy link
Member

honza commented Aug 13, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2019
knowncitizen
knowncitizen reviewed Aug 13, 2019
View reviewed changes
frontend/packages/metal3-plugin/src/constants.ts
[HOST_STATUS_REGISTRATION_ERROR]: 'Registration Error',
[HOST_STATUS_PROVISIONING_ERROR]: 'Provisioning Error',
[HOST_STATUS_REGISTRATION_ERROR]: 'Registration error',
[HOST_STATUS_PROVISIONING_ERROR]: 'Provisioning error',
Copy link
Contributor

@knowncitizen knowncitizen Aug 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why lower case?

Copy link
Author

@jtomasek jtomasek Aug 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It resembles the wireframes and the convention used across the states

Copy link
Contributor

@knowncitizen knowncitizen Aug 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK :)

@knowncitizen
Copy link
Contributor

knowncitizen commented Aug 13, 2019

/lgtm

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: honza, jtomasek, knowncitizen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 638901f into openshift:master Aug 13, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 13, 2019

@jtomasek: All pull requests linked via external trackers have merged. The Bugzilla bug has been moved to the MODIFIED state.

Details

In response to this:

Bug 1739407: Enhance host status to beter derive errors from operational status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.2 milestone Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@honza honza Awaiting requested review from honza

1 more reviewer

@knowncitizen knowncitizen knowncitizen left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@knowncitizen knowncitizen

@honza honza

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/metal3 Related to metal3-plugin lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v4.2

Development

Successfully merging this pull request may close these issues.

6 participants

@jtomasek @openshift-ci-robot @honza @knowncitizen @spadgett @openshift-merge-robot