Skip to content

Bug 1743566: Don't virtualize access review table #2416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Aug 20, 2019
Merged

Bug 1743566: Don't virtualize access review table #2416

openshift-merge-robot merged 1 commit into from
Aug 20, 2019

Conversation

@spadgett
Copy link
Member

@spadgett spadgett commented Aug 20, 2019

@spadgett spadgett added this to the v4.2 milestone Aug 20, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 20, 2019

@spadgett: This pull request references Bugzilla bug 1743566, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1743566: Don't virtualize access review table

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 20, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2019
rhamilto
rhamilto approved these changes Aug 20, 2019
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 20, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member Author

spadgett commented Aug 20, 2019

/retest

1 similar comment
@spadgett
Copy link
Member Author

spadgett commented Aug 20, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit a2fc087 into openshift:master Aug 20, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 20, 2019

@spadgett: All pull requests linked via external trackers have merged. Bugzilla bug 1743566 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1743566: Don't virtualize access review table

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett deleted the fix-explore-access-review branch August 20, 2019 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhamilto rhamilto rhamilto approved these changes

@benjaminapetersen benjaminapetersen Awaiting requested review from benjaminapetersen

@zherman0 zherman0 Awaiting requested review from zherman0

Assignees

@rhamilto rhamilto

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v4.2

Development

Successfully merging this pull request may close these issues.

4 participants

@spadgett @openshift-ci-robot @rhamilto @openshift-merge-robot