Skip to content

Bug 1741473: Apply correct pf4 button styling and fix disabled functionality.#2448

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
sg00dwin:add-host-button-update
Aug 27, 2019
Merged

Bug 1741473: Apply correct pf4 button styling and fix disabled functionality.#2448
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
sg00dwin:add-host-button-update

Conversation

@sg00dwin
Copy link
Member

@sg00dwin sg00dwin requested a review from flofuchs August 21, 2019 20:07
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. component/metal3 Related to metal3-plugin labels Aug 21, 2019
@sg00dwin
Copy link
Member Author

@jtomasek would you be able to test this on your end?

@spadgett
Copy link
Member

@sg00dwin this failed the linter. the plugins require prettier formatting

@sg00dwin sg00dwin force-pushed the add-host-button-update branch from 2d2963f to b6d1531 Compare August 22, 2019 14:10
@sg00dwin
Copy link
Member Author

updated pr
/retest

@spadgett
Copy link
Member

/assign @jtomasek

@jtomasek
Copy link

This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1741473 please add the reference to the PR title: Bug 1741473

@sg00dwin sg00dwin changed the title Apply correct pf4 button styling and fix disabled functionality. Bug 1741473: Apply correct pf4 button styling and fix disabled functionality. Aug 26, 2019
@openshift-ci-robot
Copy link
Contributor

@sg00dwin: This pull request references Bugzilla bug 1741473, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1741473: Apply correct pf4 button styling and fix disabled functionality.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 26, 2019
Copy link

@jtomasek jtomasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with metal3 plugin, works as expected. Thanks!

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2019
@jtomasek
Copy link

jtomasek commented Aug 27, 2019

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2019
@knowncitizen
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jtomasek, knowncitizen, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 96e9dd3 into openshift:master Aug 27, 2019
@openshift-ci-robot
Copy link
Contributor

@sg00dwin: All pull requests linked via external trackers have merged. Bugzilla bug 1741473 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1741473: Apply correct pf4 button styling and fix disabled functionality.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.2 milestone Aug 29, 2019
@sg00dwin sg00dwin deleted the add-host-button-update branch September 10, 2019 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/metal3 Related to metal3-plugin lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants