Integration Tests: Wait until cog is clickable before deleting row#310
Merged
openshift-merge-robot merged 1 commit intoJul 26, 2018
Merged
Conversation
openshift-ci-robot
added
the
size/XS
Member
Author
|
@alecmerdler This should fix the annotation test flake we've been seeing. (I think there are others, but this is the most frequent.) @jhadvig If you could take a look, this should unblock the queue. |
jhadvig
approved these changes
Jul 26, 2018
Member
jhadvig
left a comment
jhadvig
left a comment
There was a problem hiding this comment.
Thanks for fixing this ! Looks good 👍
/lgtm
Member
Author
|
Unfortunately I'm seeing another related flake with the annotation tests. Looking... |
rawagner
pushed a commit
to rawagner/console
that referenced
this pull request
Apr 16, 2019
3 tasks
openshift-merge-bot Bot
pushed a commit
that referenced
this pull request
May 20, 2026
…310 useShipwrightBreadcrumbsFor is a React hook (6 sub-hooks) that was incorrectly passed as a plain callback via the breadcrumbsFor prop to DetailsPage. ConnectedPageHeading calls breadcrumbsFor conditionally based on data loading state, violating React's Rules of Hooks. On OCP 4.20+, ConnectedPageHeading gained its own hooks, causing React to detect the hook count mismatch between renders and throw error #310: "Rendered more hooks than during the previous render." Assisted by Claude Claude Opus 4.6
openshift-merge-bot Bot
added a commit
that referenced
this pull request
May 20, 2026
…investigation OCPBUGS-84214: Fix Shipwright detail pages crashing with React error #310
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We delete the test resource immediately after closing the annotation dialog when the annotation tests are finished. Due to the closing animation, the modal overlay can prevent the cog from being clicked even though the cog is visible.
Change the check from
until.visibilityOftountil.elementToBeClickableto wait until the cog is really clickable, not just on the screen.