Bug 1620368 - Remove incorrect fields from cron job page#446
Bug 1620368 - Remove incorrect fields from cron job page#446spadgett merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
size/S
There was a problem hiding this comment.
The _.get calls are unnecessary, and this would already fail with a runtime error if spec was undefined at line 46.
There was a problem hiding this comment.
I don't think that you can specify cronjob without spec field
|
/hold I realize we're also showing name and namespace twice |
openshift-ci-robot
added
the
do-not-merge/hold
Job status will not be set in the cron job resource. You have to look at an individual job to see status. Remove these fields from the cron job page.
spadgett
force-pushed
the
cron-job-details
branch
from
6dab1c7 to
4d99652
Compare
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
Opened https://jira.coreos.com/browse/CONSOLE-736 to add some detail about the container being run. |
| <dd>{job.spec.parallelism || '-'}</dd> | ||
| <dt>Deadline</dt> | ||
| <dd>{job.spec.activeDeadlineSeconds ? `${job.spec.activeDeadlineSeconds} seconds` : '-'}</dd> | ||
| <dt>Status</dt> |
There was a problem hiding this comment.
I think that it also would make sense to show restartPolicy, mainly cause this field is always present...
There was a problem hiding this comment.
That is part of the pod template, and we're not showing any info about the containers currently.
There was a problem hiding this comment.
I opened CONSOLE-736 to add container info
There was a problem hiding this comment.
makes sense, just wasnt sure if we want to address this in this PR or in a separate one, but since there is a story for that it does makes sense to add it as part of it 👍
There was a problem hiding this comment.
Yeah it's a great point, and I think generally the workloads pages need more detail. We should be careful how we do it though because pod templates have a lot of fields that can clutter the UI, so I didn't want to do too much in this PR.
Thanks @jhadvig
3 participants
Job status will not be set in the cron job resource. You have to look at
an individual job to see status. Remove these fields from the cron job page.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1620368
/assign @jhadvig