Skip to content

[release-4.21] OCPBUGS-85572: Add init container for Manila node daemonset#554

Open
openshift-cherrypick-robot wants to merge 1 commit into
openshift:release-4.21from
openshift-cherrypick-robot:cherry-pick-552-to-release-4.21
Open

[release-4.21] OCPBUGS-85572: Add init container for Manila node daemonset#554
openshift-cherrypick-robot wants to merge 1 commit into
openshift:release-4.21from
openshift-cherrypick-robot:cherry-pick-552-to-release-4.21

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

This is an automated cherry-pick of #552

/assign openshift-ci-robot

The Manila CSI driver node plugin fatally exits on startup when the NFS
CSI plugin socket (/var/lib/kubelet/plugins/csi-nfsplugin/csi.sock) is
not yet available. After node disruptions, both DaemonSets restart
concurrently and the Manila driver crashes because upstream ProbeForever
only retries on DeadlineExceeded, not on Unavailable (connection
refused). This causes excessive container restarts (>3), failing the CI
invariant test.

Add a wait-for-nfs-plugin init container to the Manila node DaemonSet
that polls for the NFS plugin socket before allowing the csi-driver
container to start. This ensures proper startup ordering between the
two DaemonSets without requiring changes to the upstream driver.
@openshift-ci-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-85457 with correct target version. Will retitle the PR to link to the clone.
/retitle [release-4.21] OCPBUGS-85572: Add init container for Manila node daemonset

Details

In response to this:

This is an automated cherry-pick of #552

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9b905db4-bc1c-4814-911d-421b7cf65cce

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot changed the title [release-4.21] OCPBUGS-85457: Add init container for Manila node daemonset [release-4.21] OCPBUGS-85572: Add init container for Manila node daemonset May 13, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 13, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-85572, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-85532 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #552

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 13, 2026
@openshift-ci openshift-ci Bot requested review from mpatlasov and rhrmo May 13, 2026 18:36
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign gnufied for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 13, 2026

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-file-nfs-csi cd37474 link true /test e2e-azure-file-nfs-csi
ci/prow/hypershift-e2e-openstack-aws-csi-manila cd37474 link true /test hypershift-e2e-openstack-aws-csi-manila
ci/prow/e2e-openstack-manila-csi cd37474 link true /test e2e-openstack-manila-csi
ci/prow/hypershift-e2e-aks cd37474 link true /test hypershift-e2e-aks
ci/prow/e2e-openstack cd37474 link false /test e2e-openstack
ci/prow/hypershift-aws-e2e-external cd37474 link true /test hypershift-aws-e2e-external

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants