Skip to content

Conversation

@andreasgerstmayr
Copy link
Contributor

I cherry-picked all recent changes and adapted them to PatternFly 5, to support OCP 4.15 - OCP 4.18. The diff of release-0.4 with main branch is now fairly small, making future backports easy.

For the PR review it's probably sufficient to look at the last commit (Revert PF6 changes) only, which shows the diff of PF5 (release-0.4 branch) and PF6 (main branch) changes.

PeterYurkovich and others added 15 commits May 14, 2025 15:18
* replace react-router and react-router-dom with react-router-dom-compat-v5
* move routes to console-extensions.json

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
I accidentally broke the no data state when adapting to the latest
Perses changes.

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 14, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 14, 2025

@andreasgerstmayr: This pull request references OU-803 which is a valid jira issue.

In response to this:

I cherry-picked all recent changes and adapted them to PatternFly 5, to support OCP 4.15 - OCP 4.18. The diff of release-0.4 with main branch is now fairly small, making future backports easy.

For the PR review it's probably sufficient to look at the last commit (Revert PF6 changes) only, which shows the diff of PF5 (release-0.4 branch) and PF6 (main branch) changes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jgbernalp and zhuje May 14, 2025 15:06
@jgbernalp
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2025
@openshift-ci
Copy link

openshift-ci bot commented May 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreasgerstmayr, jgbernalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2025
@andreasgerstmayr
Copy link
Contributor Author

/label ux-approved
same ux changes as in main branch
/label qe-approved
qe will be done post merge

@openshift-ci openshift-ci bot added ux-approved Signifies that UX has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels May 16, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 16, 2025

@andreasgerstmayr: This pull request references OU-803 which is a valid jira issue.

In response to this:

I cherry-picked all recent changes and adapted them to PatternFly 5, to support OCP 4.15 - OCP 4.18. The diff of release-0.4 with main branch is now fairly small, making future backports easy.

For the PR review it's probably sufficient to look at the last commit (Revert PF6 changes) only, which shows the diff of PF5 (release-0.4 branch) and PF6 (main branch) changes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@andreasgerstmayr
Copy link
Contributor Author

/test upstream-amd64-aws-e2e

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ba44250 and 2 for PR HEAD 2d378c3 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ba44250 and 2 for PR HEAD 2d378c3 in total

@etmurasaki
Copy link

@IshwarKanse I've tested this using quay.io/rh-ee-emurasak/distributed-tracing-console-plugin:andreaspf5 consuming this PR and didn't find any major issue.
Questions and findings logged in this thread: https://redhat-internal.slack.com/archives/C03EPFR2BAR/p1747336839704279?thread_ts=1747237642.387239&cid=C03EPFR2BAR

Feel free to retest it with all backend knowledge, since I covered only UI side. Thanks!

@IshwarKanse
Copy link
Member

/override ci/prow/upstream-amd64-aws-e2e

@openshift-ci
Copy link

openshift-ci bot commented May 16, 2025

@IshwarKanse: Overrode contexts on behalf of IshwarKanse: ci/prow/upstream-amd64-aws-e2e

In response to this:

/override ci/prow/upstream-amd64-aws-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 262fd05 into openshift:release-0.4 May 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR ux-approved Signifies that UX has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants