-
Notifications
You must be signed in to change notification settings - Fork 8
[release-0.4] OU-803: Backport filter bar to PatternFly 5 #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-0.4] OU-803: Backport filter bar to PatternFly 5 #104
Conversation
* replace react-router and react-router-dom with react-router-dom-compat-v5 * move routes to console-extensions.json Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
I accidentally broke the no data state when adapting to the latest Perses changes. Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
|
@andreasgerstmayr: This pull request references OU-803 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreasgerstmayr, jgbernalp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label ux-approved |
|
@andreasgerstmayr: This pull request references OU-803 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test upstream-amd64-aws-e2e |
|
@IshwarKanse I've tested this using quay.io/rh-ee-emurasak/distributed-tracing-console-plugin:andreaspf5 consuming this PR and didn't find any major issue. Feel free to retest it with all backend knowledge, since I covered only UI side. Thanks! |
|
/override ci/prow/upstream-amd64-aws-e2e |
|
@IshwarKanse: Overrode contexts on behalf of IshwarKanse: ci/prow/upstream-amd64-aws-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
262fd05
into
openshift:release-0.4
I cherry-picked all recent changes and adapted them to PatternFly 5, to support OCP 4.15 - OCP 4.18. The diff of
release-0.4withmainbranch is now fairly small, making future backports easy.For the PR review it's probably sufficient to look at the last commit (
Revert PF6 changes) only, which shows the diff of PF5 (release-0.4branch) and PF6 (mainbranch) changes.