Skip to content

OU-805: account for selected time range when showing attribute values #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025
Merged

OU-805: account for selected time range when showing attribute values #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions web/src/hooks/useTagValues.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,16 @@ export function useTagValues(
tag: string,
query: string,
enabled: boolean,
start?: number,
end?: number,
) {
return useQuery({
queryKey: ['useTagValues', tempo, tag, query],
queryKey: ['useTagValues', tempo, tag, query, start, end],
enabled,
queryFn: async function () {
if (!tempo) return [];
const client = TempoDatasource.createClient({ directUrl: getProxyURLFor(tempo) }, {});
const values = await client.searchTagValues({ tag, q: query });
const values = await client.searchTagValues({ tag, q: query, start, end });
return values.tagValues
.map((tagValue) => ({
content: tagValue.value,
Expand Down
13 changes: 13 additions & 0 deletions web/src/pages/TracesPage/Toolbar/AttributeFilters.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ import { traceQLToFilter } from './Filter/traceql_to_filter';
import { TypeaheadCheckboxSelect } from '../../../components/TypeaheadCheckboxSelect';
import { DurationField, Filter, splitByUnquotedWhitespace } from './Filter/filter';
import { useTagValues } from '../../../hooks/useTagValues';
import { useTimeRange } from '@perses-dev/plugin-system';
import { isAbsoluteTimeRange, toAbsoluteTimeRange } from '@perses-dev/core';

const serviceNameFilter = { content: 'Service Name', value: 'serviceName' };
const spanNameFilter = { content: 'Span Name', value: 'spanName' };
Expand Down Expand Up @@ -63,23 +65,34 @@ export function AttributeFilters(props: AttributeFiltersProps) {
setQuery(filterToTraceQL(filter));
};

const { timeRange } = useTimeRange();
const absTimeRange = !isAbsoluteTimeRange(timeRange) ? toAbsoluteTimeRange(timeRange) : timeRange;
const startTime = Math.round(absTimeRange.start.getTime() / 1000);
const endTime = Math.round(absTimeRange.end.getTime() / 1000);

const { data: serviceNameOptions } = useTagValues(
tempo,
'resource.service.name',
filterToTraceQL({ ...filter, serviceName: [] }),
activeFilter === serviceNameFilter.value,
startTime,
endTime,
);
const { data: spanNameOptions } = useTagValues(
tempo,
'name',
filterToTraceQL({ ...filter, spanName: [] }),
activeFilter === spanNameFilter.value,
startTime,
endTime,
);
const { data: namespaceOptions } = useTagValues(
tempo,
'resource.k8s.namespace.name',
filterToTraceQL({ ...filter, namespace: [] }),
activeFilter === namespaceFilter.value,
startTime,
endTime,
);

return (
Expand Down