Skip to content

OU-385: Update perses-dev plugins to v45 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jgbernalp merged 1 commit into from
May 21, 2024
Merged

OU-385: Update perses-dev plugins to v45 #5

jgbernalp merged 1 commit into from
May 21, 2024

Conversation

@zhuje
Copy link
Contributor

@zhuje zhuje commented May 20, 2024

Update perses-dev plugins to v45 this includes that fix allows the sc…atter plot plugins to appear as an embedded component.

NOTE: only the package-lock.json is update and not the yarn.lock because usage of yarn will be retired. This is because npm has better tooling for CI processes.

@zhuje
Update perses-dev plugins to v45 this includes that fix allows the sc…
e9fc996 
…atter plot plugins to appear as an embedded component.

NOTE: only the package-lock.json is update and not the yarn.lock because usage of `yarn` will be retired. This is because npm has better tooling for CI processes.

Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 20, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 20, 2024 •
edited by openshift-ci bot
Loading

@zhuje: This pull request references OU-385 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to this:

Update perses-dev plugins to v45 this includes that fix allows the sc…atter plot plugins to appear as an embedded component.

NOTE: only the package-lock.json is update and not the yarn.lock because usage of yarn will be retired. This is because npm has better tooling for CI processes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from PeterYurkovich and kyoto May 20, 2024 18:56
jgbernalp
jgbernalp approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@jgbernalp jgbernalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
@jgbernalp jgbernalp merged commit 508f84f into openshift:main May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgbernalp jgbernalp jgbernalp approved these changes

@kyoto kyoto Awaiting requested review from kyoto

@PeterYurkovich PeterYurkovich Awaiting requested review from PeterYurkovich

Assignees

@jgbernalp jgbernalp

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhuje @openshift-ci-robot @jgbernalp