Skip to content

Conversation

@andreasgerstmayr
Copy link
Contributor

Fixes the following warnings:

LOG from @openshift-console/dynamic-plugin-sdk-webpack/lib/webpack/loaders/dynamic-module-import-loader ../node_modules/ts-loader/index.js??ruleSet[1].rules[0].use[0]!./components/TypeaheadSelect.tsx
<w> Non-index and non-dynamic module import @patternfly/react-icons/dist/esm/icons/times-icon

and

WARNING in shared module @patternfly/react-icons/dist/dynamic/icons/plus-circle-icon
No required version specified and unable to automatically determine one. Unable to find required version for "@patternfly/react-icons" in description file (/home/agerstmayr/redhat/dev/distributed-tracing-console-plugin/web/package.json). It need to be in dependencies, devDependencies or peerDependencies.

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
@openshift-ci openshift-ci bot requested review from IshwarKanse and jgbernalp April 17, 2025 15:28
@PeterYurkovich
Copy link
Contributor

/lgtm

@PeterYurkovich
Copy link
Contributor

/label ux-approved
no ux changes

@openshift-ci openshift-ci bot added the ux-approved Signifies that UX has signed off on this PR label Apr 17, 2025
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 17, 2025
Copy link
Contributor

@zhuje zhuje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Apr 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreasgerstmayr, PeterYurkovich, zhuje

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [PeterYurkovich,zhuje]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhuje zhuje changed the title [chore] fix build-time warnings NO-JIRA: [chore] fix build-time warnings Apr 22, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 22, 2025
@openshift-ci-robot
Copy link

@andreasgerstmayr: This pull request explicitly references no jira issue.

In response to this:

Fixes the following warnings:

LOG from @openshift-console/dynamic-plugin-sdk-webpack/lib/webpack/loaders/dynamic-module-import-loader ../node_modules/ts-loader/index.js??ruleSet[1].rules[0].use[0]!./components/TypeaheadSelect.tsx
<w> Non-index and non-dynamic module import @patternfly/react-icons/dist/esm/icons/times-icon

and

WARNING in shared module @patternfly/react-icons/dist/dynamic/icons/plus-circle-icon
No required version specified and unable to automatically determine one. Unable to find required version for "@patternfly/react-icons" in description file (/home/agerstmayr/redhat/dev/distributed-tracing-console-plugin/web/package.json). It need to be in dependencies, devDependencies or peerDependencies.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jgbernalp
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 29, 2025
@openshift-ci
Copy link

openshift-ci bot commented Apr 29, 2025

@andreasgerstmayr: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 7118ab6 into openshift:main Apr 29, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR ux-approved Signifies that UX has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants