Skip to content

Conversation

fhlavac
Copy link
Contributor

@fhlavac fhlavac commented Jul 20, 2022

https://issues.redhat.com/browse/HAC-1855

Enabled info option for ListView column

Screenshot from 2022-07-20 10-08-29

@florkbr
@vidyanambiar

@openshift-ci openshift-ci bot requested review from karelhala and vojtechszocs July 20, 2022 08:12
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2022

@fhlavac: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@vidyanambiar vidyanambiar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks @fhlavac!
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2022
@vojtechszocs
Copy link
Contributor

/lgtm

@vojtechszocs
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fhlavac, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2022
@openshift-merge-robot openshift-merge-robot merged commit e825c85 into openshift:main Jul 21, 2022
@fhlavac fhlavac deleted the info branch July 22, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants