Skip to content

Enable info tooltip/popover in ListView #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2022
Merged

Enable info tooltip/popover in ListView #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
deb8df2
Enable info tooltip/popover
fhlavac Jul 20, 2022
65b7a72
Add info tooltip to ListView story
fhlavac Jul 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/lib-utils/src/components/list-view/ListView.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,12 @@ Primary.args = {
props: {
className: '',
},
info: {
tooltip: 'More information about Kind',
tooltipProps: {
isContentLeftAligned: true,
},
},
},
{
title: 'Labels',
Expand Down
6 changes: 5 additions & 1 deletion packages/lib-utils/src/components/table/VirtualizedTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,10 @@ const VirtualizedTable: React.FC<VirtualizedTableProps<AnyObject>> = ({
}}
/>
{columns.map(
({ title, props: properties, sort, transforms, visibility, id }, columnIndex) => {
(
{ title, props: properties, sort, transforms, visibility, id, info },
columnIndex,
) => {
const isSortable = !!transforms?.find((item) => item?.name === 'sortable');
const defaultSort = {
sortBy: {
Expand All @@ -186,6 +189,7 @@ const VirtualizedTable: React.FC<VirtualizedTableProps<AnyObject>> = ({
<Th
// eslint-disable-next-line react/no-array-index-key
key={`column-${columnIndex}-${id}`}
info={info}
sort={isSortable ? defaultSort : sort}
visibility={visibility}
// eslint-disable-next-line react/jsx-props-no-spreading
Expand Down
3 changes: 3 additions & 0 deletions packages/lib-utils/src/components/table/VirtualizedTableBody.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { Td } from '@patternfly/react-table';
import type { ICell, SortByDirection, ThProps } from '@patternfly/react-table';
import type { ThInfoType } from '@patternfly/react-table/dist/esm/components/Table/base';
import { VirtualTableBody } from '@patternfly/react-virtualized-extension';
import type { Scroll } from '@patternfly/react-virtualized-extension/dist/js/components/Virtualized/types';
import * as React from 'react';
Expand All @@ -20,6 +21,8 @@ export type TableColumn<D> = ICell & {
sort?: ((data: D[], sortDirection: SortByDirection) => D[]) | ThProps['sort'] | string;
/** Optional visibility. */
visibility?: string[];
/** Optional info tooltip or popover. */
info?: ThInfoType;
};

export type TableRowProps = {
Expand Down