Skip to content

Bringing over recent changes from master to master-post-release #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 15, 2019
Merged

Bringing over recent changes from master to master-post-release #121

merged 8 commits into from
Apr 15, 2019

Conversation

@ewolinetz
Copy link
Contributor

@ewolinetz ewolinetz commented Apr 12, 2019

No description provided.

ewolinetz and others added 8 commits March 29, 2019 16:22
@ewolinetz
checking if nodeselectors have changed
cf10735
@openshift-merge-robot
Merge pull request openshift#114 from ewolinetz/nodeselector_change
7e39ced 
Bug 1694097 - Check if nodeselectors have changed
Fix 1662273 - cant find es metrics
fcb9aee 
Mismatch between labels and port name in metrics svc
and service monitor.
@openshift-merge-robot
Merge pull request openshift#115 from josefkarasek/bz1662273-es-metrics
ee7a585 
Fix 1662273 - cant find es metrics
@ewolinetz
fixing desired changes being blown away on accident
dbaf107
@openshift-merge-robot
Merge pull request openshift#116 from ewolinetz/fix_changes_recognized
fad8f7b 
Bug 1686173 - Correctly evaluate case where node previously existed
@ewolinetz
fixing check for pod being unschedulable
8dc75bb
@openshift-merge-robot
Merge pull request openshift#117 from ewolinetz/fixup_unscheduled_check
9c581a4 
Fixing check for pod being unschedulable
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 12, 2019
@jcantrill
Copy link
Contributor

jcantrill commented Apr 12, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ewolinetz, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ewolinetz,jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@richm
Copy link
Contributor

richm commented Apr 12, 2019

/test e2e-operator

@ewolinetz
Copy link
Contributor Author

ewolinetz commented Apr 12, 2019

/test e2e-aws

@ewolinetz ewolinetz mentioned this pull request Apr 12, 2019
Merged
@ewolinetz
Copy link
Contributor Author

ewolinetz commented Apr 15, 2019

/test e2e-aws

@openshift-merge-robot openshift-merge-robot merged commit 028a12f into openshift:master-post-release Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josefkarasek josefkarasek Awaiting requested review from josefkarasek

@lukas-vlcek lukas-vlcek Awaiting requested review from lukas-vlcek

Assignees

@jcantrill jcantrill

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ewolinetz @jcantrill @openshift-ci-robot @richm @openshift-merge-robot