Skip to content

Conversation

@ewolinetz
Copy link
Contributor

@ewolinetz ewolinetz commented Apr 30, 2019

Addresses https://jira.coreos.com/browse/LOG-377

compared to:

$ oc exec -c elasticsearch example-elasticsearch-cdm-pjdp5067-1-bc779dd6d-2g8p9 -- es_util --query=_cluster/health?pretty
{
  "cluster_name" : "example-elasticsearch",
  "status" : "green",
  "timed_out" : false,
  "number_of_nodes" : 2,
  "number_of_data_nodes" : 2,
  "active_primary_shards" : 1,
  "active_shards" : 1,
  "relocating_shards" : 0,
  "initializing_shards" : 0,
  "unassigned_shards" : 0,
  "delayed_unassigned_shards" : 0,
  "number_of_pending_tasks" : 0,
  "number_of_in_flight_fetch" : 0,
  "task_max_waiting_in_queue_millis" : 0,
  "active_shards_percent_as_number" : 100.0
}
status:
  clusterHealth:
    activePrimaryShards: 1
    activeShards: 1
    initializingShards: 0
    numDataNodes: 2
    numNodes: 2
    pendingTasks: 0
    relocatingShards: 0
    status: green
    unassignedShards: 0
  conditions: []
  nodes:
  - deploymentName: example-elasticsearch-cdm-pjdp5067-1
    upgradeStatus: {}
  - deploymentName: example-elasticsearch-cdm-pjdp5067-2
    upgradeStatus: {}
  pods:
    client:
      failed: []
      notReady: []
      ready:
      - example-elasticsearch-cdm-pjdp5067-1-bc779dd6d-2g8p9
      - example-elasticsearch-cdm-pjdp5067-2-67b494ff69-z9q9k
    data:
      failed: []
      notReady: []
      ready:
      - example-elasticsearch-cdm-pjdp5067-1-bc779dd6d-2g8p9
      - example-elasticsearch-cdm-pjdp5067-2-67b494ff69-z9q9k
    master:
      failed: []
      notReady: []
      ready:
      - example-elasticsearch-cdm-pjdp5067-1-bc779dd6d-2g8p9
      - example-elasticsearch-cdm-pjdp5067-2-67b494ff69-z9q9k
  shardAllocationEnabled: all

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 30, 2019
@ewolinetz
Copy link
Contributor Author

requires #122 to be merged in first

@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 30, 2019
@richm
Copy link
Contributor

richm commented May 1, 2019

/test e2e-aws

@ewolinetz ewolinetz requested review from jcantrill and josefkarasek and removed request for brancz May 1, 2019 18:57
@ewolinetz
Copy link
Contributor Author

@jcantrill should i also update the manifest to expose these status fields for the console?

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 8, 2019
if allocationString, ok := value.(string); ok {
allocation = allocationString
}
allocation := parseString("transient.cluster.routing.allocation.enable", payload.ResponseBody)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to reuse an existing library over writing our own?
Ref:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really... less to vendor in for a single file?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are comfortable it won't come back to bite us and we can support given our needs, its probably fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can make it a tech debt item to investigate further

@ewolinetz ewolinetz changed the base branch from master-post-release to master May 17, 2019 15:59
Copy link
Contributor

@richm richm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - @jcantrill

@ewolinetz ewolinetz changed the title [WIP] Scrape more information from _cluster/health es end point Scrape more information from _cluster/health es end point May 17, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 17, 2019
Copy link

@portante portante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; not sure I understand all the reason for the function renames.

path: nodeSpec.resources
x-descriptors:
- 'urn:alm:descriptor:com.tectonic.ui:resourceRequirements'
statusDescriptors:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you have a mix of partial Elasticsearch cluster health data with other kube level stats. Perhaps any way to group these in the file so that in the future folks know that the ES cluster health stats are together?

And are you going to add the rest of them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is simply information that gets exposed at the console level. this will configure it to know where to scrape it from on the CR and what to label it as.

@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 17, 2019
valueFrom:
fieldRef:
fieldPath: metadata.annotations['olm.targetNamespaces']
- name: POD_NAME
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't necessary for 4.1.0 -- required for 4.2 as part of the sdk bump

@josefkarasek
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ewolinetz, josefkarasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ewolinetz,josefkarasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 017edd1 into openshift:master May 20, 2019
@ewolinetz ewolinetz deleted the expanded_status branch December 1, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants