Skip to content

Conversation

@ewolinetz
Copy link
Contributor

@ewolinetz ewolinetz commented Jul 24, 2019

As part of doing a redeploy due to certs being updated we need to do a full cluster restart otherwise nodes aren't able to rejoin the cluster due to cert mismatching.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 24, 2019
@openshift-ci-robot
Copy link

@ewolinetz: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

[WIP] Bug 1666167: Do a full cluster restart in case of cert redeploy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 24, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2019
@ewolinetz ewolinetz force-pushed the secret_refresh_restart branch from 37a991a to ac6e424 Compare July 24, 2019 22:13
@openshift-ci-robot
Copy link

@ewolinetz: This pull request references a valid Bugzilla bug.

Details

In response to this:

[WIP] Bug 1666167: Do a full cluster restart in case of cert redeploy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ewolinetz ewolinetz force-pushed the secret_refresh_restart branch from e5c751e to 5c77124 Compare July 26, 2019 19:52
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2019
@ewolinetz ewolinetz force-pushed the secret_refresh_restart branch from ffa3e98 to b3e7ba7 Compare September 24, 2019 22:35
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 24, 2019
@ewolinetz ewolinetz force-pushed the secret_refresh_restart branch from b3e7ba7 to 4b6d01c Compare September 25, 2019 16:15
@ewolinetz ewolinetz changed the title [WIP] Bug 1666167: Do a full cluster restart in case of cert redeploy Bug 1666167: Do a full cluster restart in case of cert redeploy Sep 25, 2019
@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 25, 2019
@ewolinetz
Copy link
Contributor Author

/hold
seeing some strangeness when restarting with statefulsets and deployments

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 25, 2019

@ewolinetz: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 0515b0a link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ewolinetz ewolinetz force-pushed the secret_refresh_restart branch from a99558f to e8a8c83 Compare September 26, 2019 00:05
@ewolinetz
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2019
@jcantrill
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ewolinetz, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [ewolinetz,jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 93740b0 into openshift:master Sep 26, 2019
@openshift-ci-robot
Copy link

@ewolinetz: All pull requests linked via external trackers have merged. Bugzilla bug 1666167 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1666167: Do a full cluster restart in case of cert redeploy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ewolinetz ewolinetz deleted the secret_refresh_restart branch December 1, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants