-
Notifications
You must be signed in to change notification settings - Fork 89
Bug 1847413: Fix E2E olm registry migration #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1847413: Fix E2E olm registry migration #395
Conversation
|
/assign @jcantrill |
|
/approve |
|
/test e2e-operator |
22a1b71 to
3ad4404
Compare
| - name: tmpdir | ||
| mountPath: /tmp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
based on operator-framework/operator-registry#332 its unclear to me how mounting /tmp resolves this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, but wouldn't the pod already have a /tmp dir of its own? what does mounting it from the node accomplish?
d4cd51b to
13a8d49
Compare
13a8d49 to
d3788cd
Compare
vimalk78
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcantrill, periklis, vimalk78 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@periklis: This pull request references Bugzilla bug 1847413, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@periklis: An error was encountered adding this pull request to the external tracker bugs for bug 1847413 on the Bugzilla server at https://bugzilla.redhat.com:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@periklis: This pull request references Bugzilla bug 1847413, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/refresh |
|
/refresh |
|
/cherry-pick release-4.5 |
|
@periklis: once the present PR merges, I will cherry-pick it on top of release-4.5 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@periklis: All pull requests linked via external trackers have merged: openshift/elasticsearch-operator#395, openshift/cluster-logging-operator#563. Bugzilla bug 1847413 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@periklis: new pull request created: #396 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR addresses a newly incorporated change in the operator registry image that needs a temporary directory to back the bundles database before migrating. (See operator-framework/operator-registry#332)
Depends on: openshift/cluster-logging-operator#563
Needs backport: release-4.5