Skip to content

Bug 1871737: Upgrade CRD apiVersion apiextensions.k8s.io from v1beta1 to v1 #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2020
Merged

Bug 1871737: Upgrade CRD apiVersion apiextensions.k8s.io from v1beta1 to v1 #447

merged 1 commit into from
Aug 31, 2020

Conversation

@periklis
Copy link
Contributor

@periklis periklis commented Aug 5, 2020 •
edited
Loading

Description

This PR addresses a recommended upgrade of the apiVersion of cluster-logging-operator managed CRDs from apiextensions.k8s.io/v1beta1 to apiextensions.k8s.io/v1. Former is deprecated in upcoming k8s release 1.19 and very likely removed in 1.20. In extent addressing this upgrade sooner than later frees the operator upgrade procedure from limbo to enable installation of version N on an OCP cluster version N-1, where the cluster version has dropped the deprecated versions.

Depends on: #442

Notes for the reviewer

This PR needs to get rebased after #442 is merged. Please consider only the last two commits!

/cc @ewolinetz @blockloop

@periklis
Copy link
Contributor Author

periklis commented Aug 5, 2020

/retest

2 similar comments
@periklis
Copy link
Contributor Author

periklis commented Aug 6, 2020

/retest

@periklis
Copy link
Contributor Author

periklis commented Aug 6, 2020

/retest

@periklis
Copy link
Contributor Author

periklis commented Aug 6, 2020

/retest

@periklis
Copy link
Contributor Author

periklis commented Aug 7, 2020

/retest

4 similar comments
@periklis
Copy link
Contributor Author

periklis commented Aug 7, 2020

/retest

@periklis
Copy link
Contributor Author

periklis commented Aug 7, 2020

/retest

@periklis
Copy link
Contributor Author

periklis commented Aug 8, 2020

/retest

@periklis
Copy link
Contributor Author

periklis commented Aug 10, 2020

/retest

blockloop
blockloop approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@blockloop blockloop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2020
@periklis
Copy link
Contributor Author

periklis commented Aug 10, 2020

/retest

@jcantrill
Copy link
Contributor

jcantrill commented Aug 10, 2020

/approve
This will need a bz if you intend to land in 4.6

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@periklis
Copy link
Contributor Author

periklis commented Aug 11, 2020

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@alanconway
Copy link
Contributor

alanconway commented Aug 26, 2020

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Aug 26, 2020
Merged
@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 27, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 27, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 27, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 27, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 27, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@periklis
Copy link
Contributor Author

periklis commented Aug 27, 2020 •
edited
Loading

/hold This depends on #468 to enable status subresource

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 27, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2020
@periklis periklis force-pushed the crd-v1 branch 2 times, most recently from 6830a21 to b6cc633 Compare August 27, 2020 10:57
@openshift-ci-robot openshift-ci-robot mentioned this pull request Aug 29, 2020
Merged
@lukas-vlcek
Copy link
Contributor

lukas-vlcek commented Aug 31, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 31, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanconway, blockloop, jcantrill, lukas-vlcek, periklis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alanconway,jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@periklis
Copy link
Contributor Author

periklis commented Aug 31, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2020
@periklis
Copy link
Contributor Author

periklis commented Aug 31, 2020

/retest

@openshift-merge-robot openshift-merge-robot merged commit 077fd81 into openshift:master Aug 31, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 31, 2020

@periklis: All pull requests linked via external trackers have merged:

Bugzilla bug 1871737 has been moved to the MODIFIED state.

In response to this:

Bug 1871737: Upgrade CRD apiVersion apiextensions.k8s.io from v1beta1 to v1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ewolinetz ewolinetz Awaiting requested review from ewolinetz

1 more reviewer

@blockloop blockloop blockloop approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lukas-vlcek lukas-vlcek

@blockloop blockloop

@alanconway alanconway

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@periklis @jcantrill @openshift-bot @openshift-ci-robot @ewolinetz @alanconway @lukas-vlcek @blockloop @openshift-merge-robot