Skip to content

Bug 1871737: Update status using subresource /status #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2020
Merged

Bug 1871737: Update status using subresource /status #468

merged 1 commit into from
Aug 29, 2020

Conversation

@periklis
Copy link
Contributor

@periklis periklis commented Aug 27, 2020

Description

This PR addresses a prerequisite to enable CRD v1 generation. In detail, it moves updates to the Elasticsearch CR for status to the status subresource. Furthermore this practice conforms with k8s general api conventions

/cc @ewolinetz @blockloop

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 27, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 27, 2020

@periklis: This pull request references Bugzilla bug 1871737, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1871737: Update status using subresource /status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@periklis periklis force-pushed the status-subresource branch from 0dd27fd to 77ca0e1 Compare August 27, 2020 10:54
@periklis periklis mentioned this pull request Aug 27, 2020
Merged
@periklis
Copy link
Contributor Author

periklis commented Aug 27, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 27, 2020
blockloop
blockloop reviewed Aug 27, 2020
View reviewed changes
bundle/manifests/logging.openshift.io_kibanas_crd.yaml
last transition.
type: string
reason:
description: Unique, one-word, CamelCase reason for the condition's
Copy link
Contributor

@blockloop blockloop Aug 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: CamelCase PascalCase

Copy link
Contributor Author

@periklis periklis Aug 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No chance to change this wording. It comes from deps.

blockloop
blockloop approved these changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@blockloop blockloop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2020
@periklis
Copy link
Contributor Author

periklis commented Aug 27, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 27, 2020
@periklis
Copy link
Contributor Author

periklis commented Aug 27, 2020

/retest

1 similar comment
@periklis
Copy link
Contributor Author

periklis commented Aug 27, 2020

/retest

@ewolinetz
Copy link
Contributor

ewolinetz commented Aug 27, 2020

/approve

@ewolinetz
Copy link
Contributor

ewolinetz commented Aug 27, 2020

/lgtm

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 27, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: blockloop, ewolinetz, periklis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 27, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 28, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 28, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@periklis
Copy link
Contributor Author

periklis commented Aug 28, 2020

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 28, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 28, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 29, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 29, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 21d79f5 into openshift:master Aug 29, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 29, 2020

@periklis: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1871737 has not been moved to the MODIFIED state.

In response to this:

Bug 1871737: Update status using subresource /status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ewolinetz ewolinetz Awaiting requested review from ewolinetz

1 more reviewer

@blockloop blockloop blockloop approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ewolinetz ewolinetz

@blockloop blockloop

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@periklis @openshift-ci-robot @ewolinetz @openshift-bot @blockloop @openshift-merge-robot