-
Notifications
You must be signed in to change notification settings - Fork 90
Bug 1868282: adding redundancy validation based on number of data nodes #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1868282: adding redundancy validation based on number of data nodes #453
Conversation
|
@ewolinetz: This pull request references Bugzilla bug 1868282, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ewolinetz: This pull request references Bugzilla bug 1868282, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
blockloop
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: blockloop, ewolinetz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ewolinetz: All pull requests linked via external trackers have merged: openshift/elasticsearch-operator#453. Bugzilla bug 1868282 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Addresses https://bugzilla.redhat.com/show_bug.cgi?id=1868282
Previously we did validation that the
RedundancyPolicywas validated against the number of data nodes, given that forSingleRedundancewe had at least 2 data nodes. This was mistakenly removed as part of relying on CRD validation to ensure that policies matched a given enum.This change adds it back in and also validates that we have at least 2 data nodes for any redundancy policy other than
ZeroRedundancy.