Skip to content

Conversation

@ewolinetz
Copy link
Contributor

@ewolinetz ewolinetz commented Aug 12, 2020

Addresses https://bugzilla.redhat.com/show_bug.cgi?id=1868282

Previously we did validation that the RedundancyPolicy was validated against the number of data nodes, given that for SingleRedundance we had at least 2 data nodes. This was mistakenly removed as part of relying on CRD validation to ensure that policies matched a given enum.

This change adds it back in and also validates that we have at least 2 data nodes for any redundancy policy other than ZeroRedundancy.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 12, 2020
@openshift-ci-robot
Copy link

@ewolinetz: This pull request references Bugzilla bug 1868282, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1868282: adding redundancy validation based on number of data nodes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2020
@ewolinetz ewolinetz requested review from blockloop, jcantrill and periklis and removed request for alanconway and igor-karpukhin August 12, 2020 17:12
@openshift-ci-robot
Copy link

@ewolinetz: This pull request references Bugzilla bug 1868282, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1868282: adding redundancy validation based on number of data nodes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@blockloop blockloop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: blockloop, ewolinetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 26f50f9 into openshift:master Aug 12, 2020
@openshift-ci-robot
Copy link

@ewolinetz: All pull requests linked via external trackers have merged: openshift/elasticsearch-operator#453. Bugzilla bug 1868282 has been moved to the MODIFIED state.

In response to this:

Bug 1868282: adding redundancy validation based on number of data nodes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ewolinetz ewolinetz deleted the revert_redunancy_check_removal branch December 1, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants