Bug 1866019: Delete indices in batches #454
Conversation
|
/cherrypick release-4.5 |
|
@jcantrill: once the present PR merges, I will cherry-pick it on top of release-4.5 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/severity-high
|
@jcantrill: This pull request references Bugzilla bug 1866019, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
pkg/indexmanagement/scripts.go
Outdated
| indices.sort() | ||
| print ','.join(indices) | ||
| for i in range(0, len(indices), 25): | ||
| print ','.join(indices[i:i+25]) + " " |
There was a problem hiding this comment.
doesn't ', '.join( yield you the same? the trailing " " looks odd to me here
There was a problem hiding this comment.
probably, experimenting in a debug pod wasn't fun so did what i could. ill update it
|
/approve |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
| indices.sort() | ||
| print ','.join(indices) | ||
| for i in range(0, len(indices), 25): | ||
| print ', '.join(indices[i:i+25]) |
There was a problem hiding this comment.
I think the trailing space should be removed. Indices are expected to be joined by comma without spacing. See https://www.elastic.co/guide/en/elasticsearch/reference/current/multi-index.html
There was a problem hiding this comment.
BTW, shouldn't the join be implemented like strings.Join(indices,",") ?
import "strings" // is needed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ewolinetz, jcantrill, lukas-vlcek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jcantrill: All pull requests linked via external trackers have merged: openshift/elasticsearch-operator#454. Bugzilla bug 1866019 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jcantrill: new pull request created: #456 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
This PR:
This PR may not resolve the issue as it looks like there is possibly a security exception related to an expired token. It will add some additional info to the logs to hopefully expose more for debugging
Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1866019