Skip to content

Bug 1866019: Delete indices in batches #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2020
Merged

Bug 1866019: Delete indices in batches #454

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions pkg/indexmanagement/scripts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,11 @@ writeIndices=$(curl -s $ES_SERVICE/${POLICY_MAPPING}-*/_alias/${POLICY_MAPPING}-
-H"Authorization: Bearer $(cat /var/run/secrets/kubernetes.io/serviceaccount/token)" \
-HContent-Type:application/json)

if echo "$writeIndices" | grep "\"error\"" ; then
echo "Error while attemping to determine the active write alias: $writeIndices"
exit 1
fi

CMD=$(cat <<END
import json,sys
r=json.load(sys.stdin)
Expand All @@ -42,6 +47,7 @@ indices=$(curl -s $ES_SERVICE/${POLICY_MAPPING}/_settings/index.creation_date \
-H"Authorization: Bearer $(cat /var/run/secrets/kubernetes.io/serviceaccount/token)" \
-HContent-Type:application/json)

# Delete in batches of 25 for cases where there are a large number of indices to remove
nowInMillis=$(date +%s%3N)
minAgeFromEpoc=$(($nowInMillis - $MIN_AGE))
CMD=$(cat <<END
Expand All @@ -50,8 +56,8 @@ r=json.load(sys.stdin)
indices = [index for index in r if int(r[index]['settings']['index']['creation_date']) < $minAgeFromEpoc ]
if "$writeIndex" in indices:
indices.remove("$writeIndex")
indices.sort()
print ','.join(indices)
for i in range(0, len(indices), 25):
print ', '.join(indices[i:i+25])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the trailing space should be removed. Indices are expected to be joined by comma without spacing. See https://www.elastic.co/guide/en/elasticsearch/reference/current/multi-index.html

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, shouldn't the join be implemented like strings.Join(indices,",") ?
import "strings" // is needed

END
)
indices=$(echo "${indices}" | python -c "$CMD")
Expand All @@ -63,19 +69,20 @@ else
echo deleting indices: "${indices}"
fi

code=$(curl -s $ES_SERVICE/${indices}?pretty \
for sets in ${indices}; do
code=$(curl -s $ES_SERVICE/${sets}?pretty \
-w "%{response_code}" \
--cacert /etc/indexmanagement/keys/admin-ca \
-HContent-Type:application/json \
-H"Authorization: Bearer $(cat /var/run/secrets/kubernetes.io/serviceaccount/token)" \
-o /tmp/response.txt \
-XDELETE )

if [ "$code" == "200" ] ; then
exit 0
if [ $code -ne 200 ] ; then
cat /tmp/response.txt
exit 1
fi
cat /tmp/response.txt
exit 1
done
`

var scriptMap = map[string]string{
Expand Down