Skip to content

Bug 1867461: Adding in cookie refresh and removing prompt for provider button #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2020
Merged

Bug 1867461: Adding in cookie refresh and removing prompt for provider button #467

merged 1 commit into from
Aug 27, 2020

Conversation

@ewolinetz
Copy link
Contributor

@ewolinetz ewolinetz commented Aug 25, 2020 •
edited
Loading

Updating the kibana proxy to attempt to refresh the session cookie if it is at least 10s old.
Updating to no longer display the provide auth button (this created a poor UX when paired with cookie-refresh)
Updating the cookie expire to be 24h rather than the default of 7d

Addresses https://bugzilla.redhat.com/show_bug.cgi?id=1867461

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 25, 2020

@ewolinetz: Bugzilla bug 1866490 is in a bug group that is not in the allowed groups for this repo.
Allowed groups for this repo are:

  • qe_staff
  • redhat

In response to this:

Bug 1866490: Adding in cookie refresh and removing prompt for provider button

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2020
@ewolinetz
Copy link
Contributor Author

ewolinetz commented Aug 25, 2020

cc @sichvoge

jcantrill
jcantrill reviewed Aug 25, 2020
View reviewed changes
pkg/k8shandler/kibana/reconciler.go
fmt.Sprintf("-client-id=system:serviceaccount:%s:kibana", cluster.cluster.Namespace),
"-client-secret-file=/var/run/secrets/kubernetes.io/serviceaccount/token",
"-cookie-secret-file=/secret/session-secret",
"-cookie-refresh=10s",
Copy link
Contributor

@jcantrill jcantrill Aug 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a matching test for this or is that a different proxy conf for maybe the es-proxy?

otherwise /lgtm

Copy link
Contributor Author

@ewolinetz ewolinetz Aug 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcantrill i think that is a different proxy conf

@ewolinetz
Copy link
Contributor Author

ewolinetz commented Aug 25, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 25, 2020

@ewolinetz: Bugzilla bug 1866490 is in a bug group that is not in the allowed groups for this repo.
Allowed groups for this repo are:

  • qe_staff
  • redhat

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ewolinetz ewolinetz changed the title Bug 1866490: Adding in cookie refresh and removing prompt for provider button Bug 1867461: Adding in cookie refresh and removing prompt for provider button Aug 25, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 25, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 25, 2020

@ewolinetz: This pull request references Bugzilla bug 1867461, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1867461: Adding in cookie refresh and removing prompt for provider button

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ewolinetz
Copy link
Contributor Author

ewolinetz commented Aug 25, 2020

/refresh

periklis
periklis approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

blockloop
blockloop approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@blockloop blockloop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 26, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: blockloop, ewolinetz, periklis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2020
@ewolinetz
Copy link
Contributor Author

ewolinetz commented Aug 26, 2020

/retest

1 similar comment
@ewolinetz
Copy link
Contributor Author

ewolinetz commented Aug 26, 2020

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 27, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 27, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 27, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 27, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 1bcf62a into openshift:master Aug 27, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 27, 2020

@ewolinetz: All pull requests linked via external trackers have merged:

Bugzilla bug 1867461 has been moved to the MODIFIED state.

In response to this:

Bug 1867461: Adding in cookie refresh and removing prompt for provider button

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ewolinetz
Copy link
Contributor Author

ewolinetz commented Aug 27, 2020

/cherry-pick release-4.5

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 27, 2020
Closed
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Aug 27, 2020

@ewolinetz: new pull request created: #469

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@periklis periklis mentioned this pull request Sep 1, 2020
Merged
@jcantrill jcantrill mentioned this pull request Sep 12, 2020
Merged
@ewolinetz ewolinetz deleted the kibana_session_timeout branch December 1, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcantrill jcantrill jcantrill left review comments

@alanconway alanconway Awaiting requested review from alanconway

@syedriko syedriko Awaiting requested review from syedriko

+2 more reviewers

@periklis periklis periklis approved these changes

@blockloop blockloop blockloop approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@blockloop blockloop

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@ewolinetz @openshift-ci-robot @openshift-bot @openshift-cherrypick-robot @periklis @blockloop @jcantrill @openshift-merge-robot